Ens fix 1210 #458
Ens fix 1210 #458
Conversation
chunhuazhou
requested review from
christinaholtNOAA,
CurtisAlexander-NOAA,
hu5970,
JeffBeck-NOAA,
terraladwig,
TrevorAlcott-NOAA,
guoqing-noaa and
daviddowellNOAA
as code owners
chunhuazhou
force-pushed
the
Ens_fix_1210
branch
from
f0ec682
to
3e94362
Compare
chunhuazhou
force-pushed
the
Ens_fix_1210
branch
from
3e94362
to
1684e4c
Compare
| @@ -944,13 +944,14 @@ if [ $binary_diag = ".true." ]; then | |||
| fi | |||
|
|
|||
| if [ $netcdf_diag = ".true." ]; then | |||
| nc_diag_cat="${EXECDIR}/nc_diag_cat.x" | |||
There was a problem hiding this comment.
this is not needed from the latest update after APP load ncidag module.
| listall_cnv="conv_ps conv_q conv_t conv_uv conv_pw conv_rw conv_sst conv_dbz" | ||
| listall_rad="hirs2_n14 msu_n14 sndr_g08 sndr_g11 sndr_g11 sndr_g12 sndr_g13 sndr_g08_prep sndr_g11_prep sndr_g12_prep sndr_g13_prep sndrd1_g11 sndrd2_g11 sndrd3_g11 sndrd4_g11 sndrd1_g15 sndrd2_g15 sndrd3_g15 sndrd4_g15 sndrd1_g13 sndrd2_g13 sndrd3_g13 sndrd4_g13 hirs3_n15 hirs3_n16 hirs3_n17 amsua_n15 amsua_n16 amsua_n17 amsua_n18 amsua_n19 amsua_metop-a amsua_metop-b amsua_metop-c amsub_n15 amsub_n16 amsub_n17 hsb_aqua airs_aqua amsua_aqua imgr_g08 imgr_g11 imgr_g12 pcp_ssmi_dmsp pcp_tmi_trmm conv sbuv2_n16 sbuv2_n17 sbuv2_n18 omi_aura ssmi_f13 ssmi_f14 ssmi_f15 hirs4_n18 hirs4_metop-a mhs_n18 mhs_n19 mhs_metop-a mhs_metop-b mhs_metop-c amsre_low_aqua amsre_mid_aqua amsre_hig_aqua ssmis_las_f16 ssmis_uas_f16 ssmis_img_f16 ssmis_env_f16 iasi_metop-a iasi_metop-b iasi_metop-c seviri_m08 seviri_m09 seviri_m10 seviri_m11 cris_npp atms_npp ssmis_f17 cris-fsr_npp cris-fsr_n20 atms_n20 abi_g16" | ||
|
|
||
| for type in $listall_cnv; do | ||
| count=$(ls pe*.${type}_${loop}.nc4 | wc -l) | ||
| if [[ $count -gt 0 ]]; then | ||
| ${APRUN} nc_diag_cat.x -o diag_${type}_${string}.${YYYYMMDDHH}.nc4 pe*.${type}_${loop}.nc4 | ||
| ${APRUN} ${nc_diag_cat} -o diag_${type}_${string}.${YYYYMMDDHH}.nc4 pe*.${type}_${loop}.nc4 |
| @@ -960,7 +961,7 @@ if [ $netcdf_diag = ".true." ]; then | |||
| for type in $listall_rad; do | |||
| count=$(ls pe*.${type}_${loop}.nc4 | wc -l) | |||
| if [[ $count -gt 0 ]]; then | |||
| ${APRUN} nc_diag_cat.x -o diag_${type}_${string}.${YYYYMMDDHH}.nc4 pe*.${type}_${loop}.nc4 | |||
| ${APRUN} ${nc_diag_cat} -o diag_${type}_${string}.${YYYYMMDDHH}.nc4 pe*.${type}_${loop}.nc4 | |||
| else | ||
| run_dir="${CYCLE_DIR}${SLASH_ENSMEM_SUBDIR}/fcst_fv3lam" | ||
| nwges_dir="${NWGES_DIR}${SLASH_ENSMEM_SUBDIR}/fcst_fv3lam" | ||
| fi |
There was a problem hiding this comment.
Do we need so many checks? This only save INPUT from prod cycle.
It does need to generate a nwges directory that has different name from prod.
ush/setup.sh
Outdated
| fi | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # |
There was a problem hiding this comment.
Please check 471-485 to see if you can add this one as to the list that makes the same changes.
ush/templates/FV3LAM_wflow.xml
Outdated
| @@ -2342,6 +2317,78 @@ MODULES_RUN_TASK_FP script. | |||
| </task> | |||
|
|
|||
| {%- endif %} | |||
|
|
|||
| {%- if do_save_input %} | |||
There was a problem hiding this comment.
This should only save 9 members instead of 30 members, right?
|
@chunhuazhou please review PR 457 and sync your PR with 457. |
|
@chunhuazhou Please check nd_diag issue in GSI and resolve conflict in setup.sh. Thanks, Ming |
Thanks Ming for all the comments! I will reverse this change later when I am done with other changes, since I need this for my retro runs on Jet (I don't want to update the app for the retro runs yet). Will address this later. |
DESCRIPTION OF CHANGES:
Minor fix for running ensemble data assimilation.
Adding task save_input to save DA anslysis to nwges, if needed, in preparation for the ensemble free forecast.
TESTS CONDUCTED:
Tests conducted on Hera for CONUS_13km.
DEPENDENCIES:
DOCUMENTATION:
ISSUE (optional):
CONTRIBUTORS (optional):
If others have contributed to this work aside from the PR author, list them here