Limit time series display to 2 weeks #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt to keep memory usage under control in production where we have a long history of data, so we can’t just show you the history of all the model runs for which we have records. For now, we have a hard-coded limit of two weeks of data, but eventually we may parameterize the start and end dates.
This is an example of our test setup becoming out of sync with how our data pipeline actually writes the data, I think. The tests were passing comparing strings, but the actual application failed, because our real data is written out as timestamps. I updated the tests to ensure we're creating Parquet files with timestamps, and fixed the comparison in the diag.history function. Now the application appears to work as well as all the tests passing.
esheehan-gsl
force-pushed
the
443-gateway-errors-in-production
branch
from
46c7ab8
to
f036ac2
Compare
Minimum allowed line rate is |
ian-noaa
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit the amount of data read in for the historical data to just two weeks prior to the initialization time. This should reduce memory usage in production and allow the application to continue working, solving #443 (I hope).
In future, we may make this range configurable by users, instead of hard-coding a two week limit.