Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit time series display to 2 weeks #446

Merged
merged 5 commits into from
Nov 16, 2023
Merged

Limit time series display to 2 weeks #446

merged 5 commits into from
Nov 16, 2023

Commits on Nov 16, 2023

  1. Add a default 2 week range for the historical data 

    This is an attempt to keep memory usage under control in production
where we have a long history of data, so we can’t just show you the
history of all the model runs for which we have records. For now, we
have a hard-coded limit of two weeks of data, but eventually we may
parameterize the start and end dates.
    @esheehan-gsl
    esheehan-gsl committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    575e864 View commit details
    Browse the repository at this point in the history

  2. Parse init time from request args for historical data

    @esheehan-gsl
    esheehan-gsl committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    fea7c6b View commit details
    Browse the repository at this point in the history

  3. Add init time parameter to time series src URL

    @esheehan-gsl
    esheehan-gsl committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    4e0b601 View commit details
    Browse the repository at this point in the history

  4. Fix test data to use real dates, not strings 

    This is an example of our test setup becoming out of sync with how our
data pipeline actually writes the data, I think. The tests were passing
comparing strings, but the actual application failed, because our real
data is written out as timestamps. I updated the tests to ensure we're
creating Parquet files with timestamps, and fixed the comparison in the
diag.history function. Now the application appears to work as well as
all the tests passing.
    @esheehan-gsl
    esheehan-gsl committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    e30dd27 View commit details
    Browse the repository at this point in the history

  5. Fix formatting

    @esheehan-gsl
    esheehan-gsl committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    f036ac2 View commit details
    Browse the repository at this point in the history