Update bundled g2c from 1.6.2 to 1.6.4 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing __64BIT__ macro definition for g2clib. As of v1.6.4, this has been removed.
Updated bundled g2c v1.6.4 source to continue support for 32-bit ints. This is needed for void functions mkieee() and rdieee(). In grib2.h, added g2int32 and g2int32u.
- Updated g2clib.pyx to include the newly defined g2int32. - All returned integer arrays are now 64-bit int. - Generated new g2clib.c using cython.
- Updated grib2io.py to define any numpy integer arrays as 64-bit ints where necessary to be compatible with g2c v1.6.4.
Remove __64BIT__ macro. This is no longer needed for g2c v1.6.4 and newer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request to update the bundled g2c library from v1.6.2 to v1.6.4. With that, some updates to the g2clib.pyx and grib2io source were required to be compatible with g2c v1.6.4 now defining all ints as 64-bit.
NOTE: Some of the g2c v1.6.4 source files were further modified here beyond their actual release state. More specifically, the source files updated are
grib2.h,mkieee.c, andrdieee.c. See commit 091253a for those details.