Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-activate unit tests for PartialRealizationConfig #317

Open
robertbartel opened this issue Apr 4, 2023 · 0 comments
Open

Re-activate unit tests for PartialRealizationConfig #317

robertbartel opened this issue Apr 4, 2023 · 0 comments
Labels
bug Something isn't working maas MaaS Workstream

Comments

@robertbartel
Copy link
Contributor

This issue tracks the reactivation of the unit tests for PartialRealizationConfig, added in #316 but marked as skipped.

PR #316 includes unit tests for the new PartialRealizationConfig class. However, some problems initially prevented the tests from functioning as needed. These problems relate to the dependency on the ngen-config package, and in part specifically to ngen-cal#34.

These tests passed locally after installing a manually patched version of ngen-config, adjusting example data files to comply with ngen-config syntax requirements, and fixing problems with PartialRealizationConfig uncovered by the tests. To allow the PR to proceed, for the time being, the committed code must skip the unit tests for PartialRealizationConfig, but we eventually need to activate those.

@robertbartel robertbartel added bug Something isn't working maas MaaS Workstream labels Apr 4, 2023
robertbartel added a commit to robertbartel/DMOD that referenced this issue Apr 4, 2023
robertbartel added a commit to robertbartel/DMOD that referenced this issue Apr 27, 2023
robertbartel added a commit to robertbartel/DMOD that referenced this issue Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maas MaaS Workstream
Projects
None yet
Development

No branches or pull requests

1 participant