Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress NWIS Client value_time warning #187

Merged
merged 3 commits into from
Mar 23, 2022
Merged

Suppress NWIS Client value_time warning #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8bb2030
remove nwis value_time warning
jarq6c Mar 23, 2022
1533a47
catch empty nwis dataframe warning in test
jarq6c Mar 23, 2022
5be6b2b
advance nwis client patch version
jarq6c Mar 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/nwis_client/src/hydrotools/nwis_client/_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "3.2.0"
__version__ = "3.2.1"
7 changes: 1 addition & 6 deletions python/nwis_client/src/hydrotools/nwis_client/iv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,12 +116,7 @@ def __init__(self, *,
cache_filename=str(cache_filename),
cache_expire_after=cache_expire_after,
)
if value_time_label == None:
self._value_time_label = "value_date"
warning_message = "Setting value_time_label to value_date. Future versions will default to value_time. To silence this warning set value_time_label."
warnings.warn(warning_message, UserWarning)
else:
self._value_time_label = value_time_label
self._value_time_label = value_time_label

@verify_case_insensitive_kwargs(handler=_verify_case_insensitive_kwargs_handler)
def get(
Expand Down
17 changes: 9 additions & 8 deletions python/nwis_client/tests/test_nwis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,15 +463,16 @@ def test_splitting_bbox(test, validation):
def test_get_returns_empty_canonical_dataframe(setup_iv_value_time, monkeypatch):
"""Verify that `get` can returns an empty canonical dataframe."""

def get_raw_mock(*args, **kwargs):
return [{"values": []}]
with pytest.warns(UserWarning):
def get_raw_mock(*args, **kwargs):
return [{"values": []}]

monkeypatch.setattr(iv.IVDataService, "get_raw", get_raw_mock)
df = setup_iv_value_time.get(
sites=["01189000"], startDT="2015-12-01T00:00", endDT="2015-12-31T23:45"
)
canonical_df = iv._create_empty_canonical_df()
assert df.equals(canonical_df)
monkeypatch.setattr(iv.IVDataService, "get_raw", get_raw_mock)
df = setup_iv_value_time.get(
sites=["01189000"], startDT="2015-12-01T00:00", endDT="2015-12-31T23:45"
)
canonical_df = iv._create_empty_canonical_df()
assert df.equals(canonical_df)

def test_nwis_client_get_throws_warning_for_kwargs(mocked_iv):
from packaging import version
Expand Down