Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Pdm03 #29

Closed
hellkite500 opened this issue Mar 24, 2020 · 1 comment
Closed

Refactor Pdm03 #29

hellkite500 opened this issue Mar 24, 2020 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@hellkite500
Copy link
Member

In PR #27 a new flux/physics kernel module was added, Pdm03.h
This kernel needs to be updated to comply with naming conventions and the file itself should get a more descriptive name.

Current behavior

Pdm03.h is not up to standard for naming conventions.

Expected behavior

More clear file, interface, and variable names.
@hellkite500 hellkite500 mentioned this issue Apr 3, 2020
Closed
@hellkite500 hellkite500 added the duplicate This issue or pull request already exists label Apr 3, 2020
@hellkite500
Copy link
Member Author

Duplicate of #41.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hellkite500