Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pdm03 kernel code to conform to naming conventions. #41

Closed
hellkite500 opened this issue Apr 3, 2020 · 3 comments
Closed

Update pdm03 kernel code to conform to naming conventions. #41

hellkite500 opened this issue Apr 3, 2020 · 3 comments
Labels
enhancement New feature or request invalid This doesn't seem right

Comments

@hellkite500
Copy link
Member

ngen/models/kernels/Pdm03.h

Line 14 in ec38b1a

double Cpar;

All the variables in this model kernel need to be renamed and documented to be clear, meaningful names with units.
This was referenced Apr 3, 2020
Closed
Closed
@hellkite500 hellkite500 added enhancement New feature or request invalid This doesn't seem right labels Apr 3, 2020
@hellkite500
Copy link
Member Author

Need some clarity on this function:

ngen/models/kernels/Pdm03.h

Line 124 in 8283f32

inline double calculateHamonPE(double avgTemp, double Latitude, int day_of_year)

Really just need to update the interface and naming to make it clear and add better inline documentation on inputs/outputs/usage ect...

Don't really need detailed academic documentation, just better code.

@stcui007
Copy link
Contributor

stcui007 commented May 8, 2020

This requested change is done in the latest version of Pdm03.h.

@hellkite500
Copy link
Member Author

Closed by #102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hellkite500 @stcui007