Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hymod et interface naming #42

Closed
hellkite500 opened this issue Apr 3, 2020 · 1 comment
Closed

Fix hymod et interface naming #42

hellkite500 opened this issue Apr 3, 2020 · 1 comment
Labels
enhancement New feature or request invalid This doesn't seem right

Comments

@hellkite500
Copy link
Member

ngen/models/hymod/include/Hymod.h

Line 96 in ec38b1a

static double calc_et2(double soil_m, void* et_params)

Related to #29 and #41. Need a more descriptive public interface function from pdm03, an the calling wrapper here should reflect a similar, if not verbatim, name.
@hellkite500 hellkite500 added enhancement New feature or request invalid This doesn't seem right labels Apr 3, 2020
@hellkite500
Copy link
Member Author

Address in part by #100, #102. not completely aligned with pdm_wrapper which isn't clear that calc_et is doing evapotranspiration computations, but this issue is reasonably addressed for now. Future refactoring and alignment can be tracked in a new issue if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hellkite500