Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text box constraints #553

Closed
LordPyrex opened this issue Jun 28, 2017 · 28 comments
Closed

Text box constraints #553

LordPyrex opened this issue Jun 28, 2017 · 28 comments
Milestone

Comments

@LordPyrex
Copy link
Collaborator

I've noticed that some of the text box constraints are causing fit issues. Is this still ongoing or is this just something that is on my end. Using v1.3

@NPBruce
Copy link
Owner

NPBruce commented Jun 28, 2017

Are you talking about in the editor or while playing? Which boxes? in 1.4 I am changing the editor text boxes to grow/shrink to fit the text size.

@LordPyrex
Copy link
Collaborator Author

In play. I'm sure with the next roll out it won't be a problem.

@NPBruce
Copy link
Owner

NPBruce commented Jun 28, 2017

I am not aware of any issues in play, if you can reproduce one please tell me where, and and what resolution you are running.

@LordPyrex
Copy link
Collaborator Author

constraint
I'm not sure if it's just quantity based, but I was able to reproduce on 1920x1200 windowed and 3840x2160 Fullscreen

@NPBruce
Copy link
Owner

NPBruce commented Jun 28, 2017

Can you provide the scenario? I don't have a monitor that big so I will do what I can do find out what is going on.

@NPBruce
Copy link
Owner

NPBruce commented Jun 28, 2017

I just want the event text to reproduce the problem... though it may be tricky if it doesn't occur at lower resolutions.

@LordPyrex
Copy link
Collaborator Author

Just the event.ini?

@LordPyrex
Copy link
Collaborator Author

Or the actual text from the event

@NPBruce
Copy link
Owner

NPBruce commented Jun 28, 2017

Doesn't matter, I will pull it from you scenario.

@LordPyrex
Copy link
Collaborator Author

I've been able to eliminate it by adding a leading blank line, but noticed it happen on other events. I'll check the next alpha to see how that affects things before doing some over hauling

@NPBruce
Copy link
Owner

NPBruce commented Jun 28, 2017

The development branch has no changes in this area.

@EtiCarasoft
Copy link

I've found this problem using 1.3 version too but in spanish version for the lower menu:
1440x900 Windowed
captura de pantalla 2017-06-28 a les 19 35 14

@redwolf2
Copy link
Collaborator

@EtiCarasoft

You can change the ...
https://github.com/NPBruce/valkyrie/blob/development/unity/Assets/Resources/Text/Localization.txt

... and have to change:
ITEMS_SMALL and SET

@LordPyrex
Copy link
Collaborator Author

@NPBruce I think that this has been resolved with any current iterations. I feel at this point this thread could be closed unless there are other issues floating around out there.

@NPBruce
Copy link
Owner

NPBruce commented Jul 16, 2017

@LordPyrex I haven't changed anything here since 1.3, so I am not sure how/why this is fixed. Are you no longer able to produce the issue shown in the screen shot above?

@LordPyrex
Copy link
Collaborator Author

Well, as quickly as I said that I noticed another box with this issue.... never mind for now...

@Indoy
Copy link

Indoy commented Dec 1, 2017

@NPBruce
Hi!
I also have some trouble to fit correctly text window with my translations. Most of the time it's out the frame. I did not catch if there's any issue for that? I have tried to delete some "\n", maximised my translation w/o loosing original meanings...don't know what to do.
Thank you
Here, the upper sentence is unseen.
image

@NPBruce
Copy link
Owner

NPBruce commented Dec 1, 2017

In this case that is the maximum size available.

The scenario could be reworked to split this into two.

@redwolf2
Copy link
Collaborator

redwolf2 commented Dec 2, 2017

Can't we just show scrollbars on demand?

@NPBruce
Copy link
Owner

NPBruce commented Dec 2, 2017

No because of the black text unity bug. In general though, I'm not sure that such a wall of text in a single event is a great idea.

If someone wants this add as a feature request (this is not related to this issue).

@Indoy
Copy link

Indoy commented Dec 2, 2017

OK! nevermind, in the future i'll ensure to the translated text fill the box... even if i have to cut a little the original idea!
Thx

@bluefishj
Copy link

bluefishj commented May 7, 2018

I've had the same issues with my scenario, The Experiment. I was had not looked it up and was hoping it was a known issues that would be fixed in 2.0, but I'm still able to reproduce it. I've tested it on different resolutions on Mac, PC, and Android, all able to reproduce. Start scenario, two token in middle of room, dagger -> stab -> triggers EventInvestigatorAwakes, takes less than a minute to reproduce. If I open the event, add and remove a space in the text box, then save and test, it fixes it, but doesn't fix it for the exported package. It will stay fixed if I go play in the app right after using the editor, but if I quit the app an then reopen, the text has problems again. I think there were at least a few instances of this when I was testing, but didn't write them down at the time. I know it happens again when you threaten the first NPC. The text boxes are smaller than other text boxes in the scenario, so they should fit. Not sure why they are getting cropped.

screen shot 2018-05-06 at 11 59 08 pm

@Bakajao
Copy link

Bakajao commented Jul 10, 2018

Hi all...i had the same problem about the boxes text fit...i investigated why happens and i discover that it fix changing the languaje in quest.ini file....
I hope that solution solve the problems

@BenRQ
Copy link
Collaborator

BenRQ commented Jul 10, 2018

Hi @Bakajao, I have the same issue and I tried to change the default language but it did not fix the issue.
I set DefaultLanguage to French, and my text is in French.
Valkyrie version 2.0.1

Can you give more details on your fix ?

momtextsize

BenRQ added a commit to BenRQ/valkyrie that referenced this issue Jul 12, 2018
GameObject needs to be new for Unity to provide a proper height.
Apply to width too just in case.
@BenRQ
Copy link
Collaborator

BenRQ commented Jul 12, 2018

@NPBruce @redwolf2 I have a fix to propose on this one.

It seems that Unity may not provide a correct height when using GetPreferredHeight in some cases.
I tried to attach the object and use Canvas.ForceUpdateCanvases(); to see if it was related but it's not.

It does work fine when using the UIElement that you are going to display though.
So I changed the functions so they are not static anymore, but using the Object itself.
And it works just fine now :)

image

Tell me if you are happy with this fix, I will pull this to development.

@redwolf2
Copy link
Collaborator

You can always make a pull request. Seems fine by me.

BenRQ added a commit to BenRQ/valkyrie that referenced this issue Jul 17, 2018
BenRQ added a commit to BenRQ/valkyrie that referenced this issue Jul 17, 2018
BenRQ added a commit to BenRQ/valkyrie that referenced this issue Jul 18, 2018
GameObject needs to be new for Unity to provide a proper height.
Apply to width too just in case.
@BenRQ
Copy link
Collaborator

BenRQ commented Jul 18, 2018

Pull request #866

BenRQ added a commit to BenRQ/valkyrie that referenced this issue Jul 18, 2018
BenRQ added a commit to BenRQ/valkyrie that referenced this issue Sep 3, 2018
*  NPBruce#553 Fix issue with text box height
GameObject needs to be new for Unity to provide a proper height.
Apply to width too just in case.
@BenRQ
Copy link
Collaborator

BenRQ commented Sep 3, 2018

Beta test version is now available with implementation of this issue:
https://github.com/BenRQ/valkyrie/releases/tag/release%2F2.1%2FBrynhildr_2.1.0b

Please close if you are happy with the fix

@redwolf2 redwolf2 added this to the 2.1 milestone Oct 5, 2018
BenRQ added a commit that referenced this issue Oct 7, 2018
*  #553 Fix issue with text box height
GameObject needs to be new for Unity to provide a proper height.
Apply to width too just in case.
@redwolf2 redwolf2 closed this as completed Oct 8, 2018
BenRQ added a commit that referenced this issue Oct 12, 2018
*  #553 Fix issue with text box height
GameObject needs to be new for Unity to provide a proper height.
Apply to width too just in case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants