Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade rusqlite@0.14 #14

Merged
merged 2 commits into from
Nov 14, 2018
Merged

upgrade rusqlite@0.14 #14

merged 2 commits into from
Nov 14, 2018

Conversation

hdhoang
Copy link
Contributor

@hdhoang hdhoang commented Nov 3, 2018

this helps with rust-lang/rust#49799. rusqlite 0.15 is a bit complicated, so I have stopped here.

I have the same test failure as before upgrading:

--------------
#7: .ignore
--------------
thread 'meta_tags' panicked at 'assertion failed: `(left == right)`
  left: `["done", "hidden", "archived", "paused"]`,
 right: `[]`', tests/tags.rs:46:5

@NQNStudios
Copy link
Owner

I wasn't aware anyone else was using Da Vinci Bot at all. 👍

Looking into the PR, and also fixing the test failure which I've noticed causes command shortcuts to fail sometimes.

@NQNStudios NQNStudios merged commit 8ee9813 into NQNStudios:master Nov 14, 2018
@NQNStudios NQNStudios mentioned this pull request Nov 14, 2018
@hdhoang hdhoang deleted the rusqlite-upgrade branch November 14, 2018 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants