Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some changes are only applied when restarting node-red, not when re-deploying #12

Open
oliverrahner opened this issue May 18, 2018 · 16 comments

Comments

Projects
9 participants
@oliverrahner
Copy link
Collaborator

commented May 18, 2018

Those issues are related to KhaosT/HAP-NodeJS#580.

I don't know of a clean way to solve this, yet.

Things not working are:

  • name changes for service nodes are not always published
  • removing service nodes does not remove them from the Home app
  • state changes "into" the homekit node are not sent out or received by the Home app anymore

All of those issues are always fixed after restarting node-red, so they are "only" a pain when changing something, not during actual usage.

@schford

This comment has been minimized.

Copy link

commented Jun 28, 2018

I too have this issue of state change into the homekit node - which is solved by restarting node red.

@ipa64

This comment has been minimized.

Copy link

commented Jul 31, 2018

Hi nothing new about this annoying bug ?

@YinHangCode

This comment has been minimized.

Copy link

commented Dec 10, 2018

I also have the same problem.

@Hirschenberger-S

This comment has been minimized.

Copy link

commented Dec 30, 2018

Same here

@oliverrahner

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 25, 2019

As KhaosT/HAP-NodeJS#580 is now resolved, I'll start working on a possible fix when I have some spare time in the next days (or maybe weeks :-/)

@Shaquu

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

For the record. I have implemented change made in KhaosT/HAP-NodeJS#580

@radokristof

This comment has been minimized.

Copy link

commented Mar 7, 2019

So don’t need to restart nodered? Which version includes this?
Is this true for new Device in HomeKit as well? It will show up after re-deployment?

@Shaquu

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

@radokristof I have implemented change but I think that doesn't help.
I have some ideas what's going on though.

@Shaquu Shaquu added this to the Release 0.7.0 milestone Mar 8, 2019

@Shaquu Shaquu added this to To do in Release 0.7.0 Mar 12, 2019

@Shaquu Shaquu added this to To do in Release 0.7.0 Mar 12, 2019

@oliverrahner

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 18, 2019

@Shaquu when I mentioned KhaosT/HAP-NodeJS#580 had been implemented, I hoped that KhaosT would have done it in a way that solves the issues that he mentioned (KhaosT/HAP-NodeJS#580 (comment)). Unfortunately, that was not the case. The change that he made was the same that I had in place as a workaround, which didn't work :(

@Shaquu

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

@oliverrahner I know I know. Unfortunately I still cannot find the problem.

@oliverrahner

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 18, 2019

Just wanted to clarify, so you don't repeat all the mistakes I made ;)

@Shaquu

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

I have an idea which make unpublish() useless.
I think I have to change this:

this.on("close", function (removed, done) {
            if (removed) {
                // This node has been deleted
                bridge.destroy();
            } else {
                // This node is being restarted
                bridge.unpublish();
                bridge = null;
                this.published = false;
            }
            done();
        });

to this:

this.on("close", function (removed, done) {
            bridge.destroy();
            bridge = null;
            self.published = false;
            done();
        });

Why? Since we "create" new Bridge every time then we should destroy connection every time.

I am pretty sure it will solve a lot...
I will try today evening.

@Shaquu

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

Unpublished (unpublish()) Bridge with working server (not destroyed) could cause #22

I twisted something...

@iRonin

This comment has been minimized.

Copy link

commented Apr 19, 2019

+1 windows stuck in constant opening/closing state…

@Shaquu

This comment has been minimized.

Copy link
Member

commented Apr 19, 2019

@iRonin thanks for feedback. I am still working on it in my free time.

@877dev

This comment has been minimized.

Copy link

commented Apr 25, 2019

Same issue here, you only have to move the node and re-deploy and the output stops "outputting".
Works fine after re-starting node red (running on Pi3).

Thanks guys for the node and hope you find the bug! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.