some changes are only applied when restarting node-red, not when re-deploying #12

oliverrahner · 2018-05-18T07:15:03Z

Those issues are related to KhaosT/HAP-NodeJS#580.

I don't know of a clean way to solve this, yet.

Things not working are:

name changes for service nodes are not always published
removing service nodes does not remove them from the Home app
state changes "into" the homekit node are not sent out or received by the Home app anymore

All of those issues are always fixed after restarting node-red, so they are "only" a pain when changing something, not during actual usage.

schford · 2018-06-28T13:35:03Z

I too have this issue of state change into the homekit node - which is solved by restarting node red.

ipa64 · 2018-07-31T12:06:56Z

Hi nothing new about this annoying bug ?

YinHangCode · 2018-12-10T02:36:38Z

I also have the same problem.

Flashmueller · 2018-12-30T12:51:29Z

Same here

oliverrahner · 2019-01-25T16:45:18Z

As KhaosT/HAP-NodeJS#580 is now resolved, I'll start working on a possible fix when I have some spare time in the next days (or maybe weeks :-/)

Shaquu · 2019-03-04T11:20:05Z

For the record. I have implemented change made in KhaosT/HAP-NodeJS#580

radokristof · 2019-03-07T08:31:33Z

So don’t need to restart nodered? Which version includes this?
Is this true for new Device in HomeKit as well? It will show up after re-deployment?

Shaquu · 2019-03-07T08:39:19Z

@radokristof I have implemented change but I think that doesn't help.
I have some ideas what's going on though.

oliverrahner · 2019-03-18T07:02:04Z

@Shaquu when I mentioned KhaosT/HAP-NodeJS#580 had been implemented, I hoped that KhaosT would have done it in a way that solves the issues that he mentioned (https://github.com/KhaosT/HAP-NodeJS/pull/580#issuecomment-386829810). Unfortunately, that was not the case. The change that he made was the same that I had in place as a workaround, which didn't work :(

Shaquu · 2019-03-18T11:17:07Z

@oliverrahner I know I know. Unfortunately I still cannot find the problem.

oliverrahner · 2019-03-18T11:18:07Z

Just wanted to clarify, so you don't repeat all the mistakes I made ;)

Shaquu · 2019-03-18T16:40:29Z

I have an idea which make unpublish() useless.
I think I have to change this:

this.on("close", function (removed, done) {
            if (removed) {
                // This node has been deleted
                bridge.destroy();
            } else {
                // This node is being restarted
                bridge.unpublish();
                bridge = null;
                this.published = false;
            }
            done();
        });

to this:

this.on("close", function (removed, done) {
            bridge.destroy();
            bridge = null;
            self.published = false;
            done();
        });

Why? Since we "create" new Bridge every time then we should destroy connection every time.

I am pretty sure it will solve a lot...
I will try today evening.

Shaquu · 2019-03-18T16:44:10Z

Unpublished (unpublish()) Bridge with working server (not destroyed) could cause #22

I twisted something...

iRonin · 2019-04-19T12:43:08Z

+1 windows stuck in constant opening/closing state…

Shaquu · 2019-04-19T12:55:15Z

@iRonin thanks for feedback. I am still working on it in my free time.

877dev · 2019-04-25T19:43:48Z

Same issue here, you only have to move the node and re-deploy and the output stops "outputting".
Works fine after re-starting node red (running on Pi3).

Thanks guys for the node and hope you find the bug! :)

Appelg · 2019-05-26T14:29:05Z

Is it possible to at least document this someplace (maybe in the INFO tab for the affected sensors?). As a new user, I just spent a couple of hours trying to figure out why my temp-sensors stopped updating :P

radokristof · 2019-05-26T14:38:04Z

All sensors/accesories are affected. Will look into it.

…

Sent from my iPhone

On 2019. May 26., at 16:29, Appelg ***@***.***> wrote: Is it possible to at least document this someplace (maybe in the INFO tab for the affected sensors?). As a new user, I just spent a couple of hours trying to figure out why my temp-sensors stopped updating :P — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

Appelg · 2019-06-12T04:22:59Z

I don't know if this is obvious, but a friend of mine told me that if you choose the deploy-mode "Modified Nodes", this bug won't trigger. I just tested it and it works, so as long as you just are tweaking node settings, you don't need to restart node-red every single deploy :)

877dev · 2019-06-12T14:50:28Z

@Appelg that’s a great tip, I had not thought of that.

I wonder if there’s any progress on a bug fix? I’d be happy to test.

radokristof · 2019-06-12T14:51:55Z

@Appelg thanks however I knew that. But this will only help if you mess around with other nodes. As soon as you change something in one of your HomeKit nodes, it won't get updated (it gets updated 1 time, but not for the second time, you need to restart Node-RED again).

Corrections regarding issue #12

Shaquu · 2020-01-14T09:10:41Z

#184 got merged into dev branch
Please test fixes npm i node-red-contrib-homekit-bridged@1.0.0-dev.3
Remember that dev version has latest patches but can be unstable and without backward compatibility.
Current dev is not compatible with latest master release - you will have to re-add all accessories in home.app.

radokristof · 2020-01-14T09:12:25Z

@Shaquu I need to re-add my accessories after update?

Shaquu · 2020-01-14T12:14:18Z

@radokristof yes, unfortunately dev (and next release) is not backward compatible.

Changelog here (should be complete but you know...)

@radokristof

## [1.0.0] - 2020.02.23 Lost backward compatibility. In order to make it work read this [notice](#163 (comment)). ### Fixed - Node id macify algorithm changed [#170](#170) - Corrections regarding issue [#12](#12) so that changes can be deployed without restarting node-red - Automatically creating a new service and replacing the old one if the service type changed - Automatically replacing an accessory with a new one if the accessory information changes (e.g. Name, Manufacturer, ...) - Video Filter value in Camera Control is now optional [#194](#194) (can be empty, before it was generated if was empty) - Removed updateReachability as it is deprecated (and doesn't make a difference) ### Added - After Service selection in node configuration Category will be automatically set to default for Service - Interface Name for Camera Service configuration - Support for new TV Remote services - Now first output is for onChange, second for onSet and third for camera snapshot. [#200](#200) - Sponsor Button on repository page ### Changed - Accessory Category in node configuration moved under Service selection - Clarify NO_RESPONSE in README - Update node-red version in dependencies - Camera Service source code to match newest improvements in homebridge-camera-ffmpeg - Update to latest HAP-NodeJS - Removed unnecessary accessory category from service node - Removed fields Manufacturer, Serial Number and Model from linked service nodes - Moved eslint and prettier configuration to package.json - Added automatic linting on pre-commit Thanks to all contributors! @radokristof @NorthernMan54 @gotofoo And thanks to those who also helped in testing! @crxporter @sjorge

Shaquu · 2020-03-01T22:33:28Z

So how do you feel. Can it be closed now after 1.0.X release?

crxporter · 2020-03-01T22:36:36Z

Coming up on the 2 year mark on this one!

As far as I’ve seen it’s done, I couldn’t make the redeploy bug come up on the dev branch but I haven’t actually moved to the 1 release.

Shaquu · 2020-03-01T22:45:39Z

@crxporter please tell me how could I make it more comfortable for you to upgrade to latest release.

crxporter · 2020-03-01T22:53:25Z

@Shaquu I’m in the middle of replacing my Insteon hardware with zwave. My approach for a while was “don’t poke the Insteon bear” so I haven’t done much. Over the next couple of days I’ll be shutting down my old setup and building fresh with 1.0.

Might cut house power this afternoon and replace a bunch of switches...

crxporter · 2020-03-01T23:21:23Z

Alright I did one small step. Sprinklers are 100% updated to 1.0.3 (and new node red). My other pi's will be more difficult projects.

Redeploy bug is dead, upgrade went great.

crxporter · 2020-04-15T23:03:29Z

@Shaquu let's close it!

This is a huge one to close. Congratulations, sir and excellent work!

oliverrahner mentioned this issue May 24, 2018

accessory becomes unavailable after re-deployment #14

Closed

oliverrahner added the bug 🐛 There is at least high chance that it is a bug! label May 25, 2018

oliverrahner mentioned this issue Jun 23, 2018

not working... #19

Closed

oliverrahner mentioned this issue Jan 12, 2019

Feedback of Garagedoor not working #33

Closed

Shaquu added this to the Release 0.7.0 milestone Mar 8, 2019

Shaquu added this to To do in Release 0.7.0 Mar 12, 2019

This was referenced Mar 18, 2019

Crash upon removing bridge from Home #22

Closed

Temperature / Humidity sensors not refreshing #73

Closed

radokristof mentioned this issue May 26, 2019

WIP: Added warning about the redeploy bug #117

Closed

Shaquu removed this from the Release 0.7.0 milestone Jun 6, 2019

Shaquu mentioned this issue Jun 28, 2019

[FEATURE] Camera Service #16

Closed

Shaquu added this to To Do in Release v1.0.0 Oct 16, 2019

gotofoo mentioned this issue Nov 29, 2019

Fix unpublish function to close all open connections and allow republish homebridge/HAP-NodeJS#759

Merged

oliverrahner mentioned this issue Dec 13, 2019

Update hap-nodejs to the latest version 🚀 #183

Closed

gotofoo mentioned this issue Dec 13, 2019

Corrections regarding issue #12 #184

Merged

gotofoo added a commit to gotofoo/node-red-contrib-homekit-bridged that referenced this issue Dec 16, 2019

Changes for HAP-NodeJS 0.5.4 and issue NRCHKB#12

820f157

gotofoo mentioned this issue Dec 22, 2019

Automatically update configuration after specific characteristics change homebridge/HAP-NodeJS#768

Closed

gotofoo added a commit to gotofoo/node-red-contrib-homekit-bridged that referenced this issue Jan 13, 2020

Corrections for NRCHKB#12 and unnecessary code removed

0d96d32

Shaquu added a commit that referenced this issue Jan 14, 2020

Merge pull request #184 from gotofoo/fix-for-hap-nodejs-0.5.4

b690700

Corrections regarding issue #12

Shaquu mentioned this issue Jan 17, 2020

Version 1.0.0 #163

Merged

Shaquu closed this as completed Apr 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

some changes are only applied when restarting node-red, not when re-deploying #12

some changes are only applied when restarting node-red, not when re-deploying #12

oliverrahner commented May 18, 2018 •

edited

schford commented Jun 28, 2018

ipa64 commented Jul 31, 2018

YinHangCode commented Dec 10, 2018

Flashmueller commented Dec 30, 2018

oliverrahner commented Jan 25, 2019

Shaquu commented Mar 4, 2019

radokristof commented Mar 7, 2019

Shaquu commented Mar 7, 2019

oliverrahner commented Mar 18, 2019

Shaquu commented Mar 18, 2019

oliverrahner commented Mar 18, 2019

Shaquu commented Mar 18, 2019 •

edited

Shaquu commented Mar 18, 2019 •

edited

iRonin commented Apr 19, 2019

Shaquu commented Apr 19, 2019

877dev commented Apr 25, 2019

Appelg commented May 26, 2019

radokristof commented May 26, 2019 via email

Appelg commented Jun 12, 2019

877dev commented Jun 12, 2019 •

edited

radokristof commented Jun 12, 2019

Shaquu commented Jan 14, 2020 •

edited

radokristof commented Jan 14, 2020

Shaquu commented Jan 14, 2020

Shaquu commented Mar 1, 2020

crxporter commented Mar 1, 2020

Shaquu commented Mar 1, 2020

crxporter commented Mar 1, 2020

crxporter commented Mar 1, 2020

crxporter commented Apr 15, 2020

some changes are only applied when restarting node-red, not when re-deploying #12

some changes are only applied when restarting node-red, not when re-deploying #12

Comments

oliverrahner commented May 18, 2018 • edited

schford commented Jun 28, 2018

ipa64 commented Jul 31, 2018

YinHangCode commented Dec 10, 2018

Flashmueller commented Dec 30, 2018

oliverrahner commented Jan 25, 2019

Shaquu commented Mar 4, 2019

radokristof commented Mar 7, 2019

Shaquu commented Mar 7, 2019

oliverrahner commented Mar 18, 2019

Shaquu commented Mar 18, 2019

oliverrahner commented Mar 18, 2019

Shaquu commented Mar 18, 2019 • edited

Shaquu commented Mar 18, 2019 • edited

iRonin commented Apr 19, 2019

Shaquu commented Apr 19, 2019

877dev commented Apr 25, 2019

Appelg commented May 26, 2019

radokristof commented May 26, 2019 via email

Appelg commented Jun 12, 2019

877dev commented Jun 12, 2019 • edited

radokristof commented Jun 12, 2019

Shaquu commented Jan 14, 2020 • edited

radokristof commented Jan 14, 2020

Shaquu commented Jan 14, 2020

Shaquu commented Mar 1, 2020

crxporter commented Mar 1, 2020

Shaquu commented Mar 1, 2020

crxporter commented Mar 1, 2020

crxporter commented Mar 1, 2020

crxporter commented Apr 15, 2020

oliverrahner commented May 18, 2018 •

edited

Shaquu commented Mar 18, 2019 •

edited

Shaquu commented Mar 18, 2019 •

edited

877dev commented Jun 12, 2019 •

edited

Shaquu commented Jan 14, 2020 •

edited