Fix unpublish function to close all open connections and allow republish #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After calling unpublish the HTTP server will be stopped but all clients stay connected which you can see if you call netstat. Any data which will be sent from those connected clients will still be processed even though the bridge should not be published anymore at this point. The process must be killed to close those open connections.
This makes it impossible to unpublish and republish a bridge. Furthermore the publish method cannot be called again because the ProtocolInformation service will be added again. The application needs to be restarted in order to be able to publish the bridge again.
Those issues lead to the issue described under NRCHKB/node-red-contrib-homekit-bridged#12 where it is not possible to redeploy a bridge node in Node-RED by calling unpublish and creating a new bridge instance.