-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RTS_GMLC_RT_sys
horizon
#102
Conversation
The PSY3 horizon was 24, here that was incorrectly interpreted as 24 hours rather than as 24*(5 minute resolution) = 2 hours
This was my bad...thanks for fixing. Did you look through the other cases already? If not, I can do that. |
A brief search only revealed one other case in PSB where we were specifying the horizon manually this way and there the resolution happened to be an hour so it worked out. It'd be great if you could double-check. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
=======================================
Coverage 94.29% 94.29%
=======================================
Files 15 15
Lines 3312 3312
=======================================
Hits 3123 3123
Misses 189 189
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There is one other change in https://github.com/NREL-Sienna/PowerSystemCaseBuilder.jl/pull/90/files that looks suspicious. @jd-lara You should probably re-review that PR. |
|
In PSY3, a time series' horizon was specified as a multiple of its resolution; in PSY4 it's its own
TimePeriod
. Withinbuild_RTS_GMLC_RT_sys
, the horizon of 24 was incorrectly migrated to 24 hours rather than to 24*(5 minute resolution) = 2 hours.This may be my smallest ever pull request. Several hours of head scratching went into that one deleted character….