Pass horizon as Period in transform_single_time_series #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd-lara
approved these changes
May 15, 2024
daniel-thom
commented
Jul 3, 2024
| @@ -616,7 +616,7 @@ end | |||
|
|
|||
| function build_modified_RTS_GMLC_RT_sys(; kwargs...) | |||
| sys = build_modified_RTS_GMLC_realization_sys(; kwargs...) | |||
| PSY.transform_single_time_series!(sys, 12, Minute(15)) | |||
There was a problem hiding this comment.
@jd-lara Was this change correct?
jd-lara
reviewed
Jul 3, 2024
| @@ -310,7 +310,7 @@ function build_5_bus_hydro_ed_sys(; raw_data, kwargs...) | |||
| time_series_in_memory = true, | |||
| sys_kwargs..., | |||
| ) | |||
| PSY.transform_single_time_series!(c_sys5_hy_ed, 12, Hour(1)) | |||
| PSY.transform_single_time_series!(c_sys5_hy_ed, Hour(12), Hour(1)) | |||
There was a problem hiding this comment.
@GabrielKS this should be Hour(1). My bad when I did the review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.