Skip to content

Commit

Permalink
Initial changes to VS coils
Browse files Browse the repository at this point in the history
  • Loading branch information
rraustad committed Sep 3, 2015
1 parent 8a9575f commit 26117aa
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 8 deletions.
14 changes: 7 additions & 7 deletions src/EnergyPlus/HVACUnitarySystem.cc
Expand Up @@ -6794,13 +6794,13 @@ namespace HVACUnitarySystem {

// Calculate residual based on output calculation flag
if ( SensibleLoad ) {
if ( std::abs( LoadToBeMet ) < 100.0) {
if ( std::abs( LoadToBeMet ) == 0.0) {
Residuum = ( SensOutput - LoadToBeMet ) / 100.0;
} else {
Residuum = 100.0 * ( SensOutput - LoadToBeMet ) / LoadToBeMet;
Residuum = ( SensOutput - LoadToBeMet ) / LoadToBeMet;
}
} else {
if ( std::abs( LoadToBeMet ) < 100.0 ) {
if ( std::abs( LoadToBeMet ) == 0.0 ) {
Residuum = ( LatOutput - LoadToBeMet ) / 100.0;
} else {
Residuum = ( LatOutput - LoadToBeMet ) / LoadToBeMet;
Expand Down Expand Up @@ -10537,7 +10537,7 @@ namespace HVACUnitarySystem {
assert( false );
}}

Residuum = ( Par( 2 ) - OutletAirTemp ) * 10.0; // need tight control on temperature
Residuum = Par( 2 ) - OutletAirTemp;

return Residuum;
}
Expand Down Expand Up @@ -10660,7 +10660,7 @@ namespace HVACUnitarySystem {
assert( false );
}}

Residuum = ( Par( 2 ) - OutletAirTemp ) * 10.0; // need tight control on temperature
Residuum = Par( 2 ) - OutletAirTemp;

return Residuum;
}
Expand Down Expand Up @@ -10883,7 +10883,7 @@ namespace HVACUnitarySystem {
assert( false );
}}

Residuum = ( Par( 2 ) - OutletAirTemp ) * 10.0; // need tight control on temperature
Residuum = Par( 2 ) - OutletAirTemp;

return Residuum;
}
Expand Down Expand Up @@ -11015,7 +11015,7 @@ namespace HVACUnitarySystem {
assert( false );
}}

Residuum = ( Par( 2 ) - OutletAirTemp ) * 10.0; // need tight control on temperature
Residuum = Par( 2 ) - OutletAirTemp;

return Residuum;
}
Expand Down
5 changes: 4 additions & 1 deletion tst/EnergyPlus/unit/Fixtures/EnergyPlusFixture.cc
Expand Up @@ -21,7 +21,10 @@
#include <EnergyPlus/GlobalNames.hh>
#include <EnergyPlus/HeatBalanceManager.hh>

#include <EnergyPlus/HVACVariableRefrigerantFlow.hh>#include <EnergyPlus/HVACUnitarySystem.hh>#include <EnergyPlus/MixedAir.hh>#include <EnergyPlus/InputProcessor.hh>
#include <EnergyPlus/HVACVariableRefrigerantFlow.hh>
#include <EnergyPlus/HVACUnitarySystem.hh>
#include <EnergyPlus/MixedAir.hh>
#include <EnergyPlus/InputProcessor.hh>
#include <EnergyPlus/OutputProcessor.hh>
#include <EnergyPlus/ScheduleManager.hh>

Expand Down

7 comments on commit 26117aa

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5067-CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFit-inside-AirLoopHVACUnitarySystem (rraustad) - x86_64-MacOS-10.9-clang: OK (1810 of 1811 tests passed)

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5067-CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFit-inside-AirLoopHVACUnitarySystem (rraustad) - i386-Windows-7-VisualStudio-12: OK (1816 of 1817 tests passed)

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5067-CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFit-inside-AirLoopHVACUnitarySystem (rraustad) - Win64-Windows-7-VisualStudio-12: OK (1816 of 1817 tests passed)

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5067-CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFit-inside-AirLoopHVACUnitarySystem (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1816 of 1817 tests passed)

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5067-CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFit-inside-AirLoopHVACUnitarySystem (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

Build Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5067-CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFit-inside-AirLoopHVACUnitarySystem (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (763 of 763 tests passed)

Build Badge Test Badge Coverage Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5067-CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFit-inside-AirLoopHVACUnitarySystem (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1291 of 1291 tests passed)

Build Badge Test Badge Coverage Badge

Please sign in to comment.