Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coil:Cooling:WaterToAirHeatPump:VariableSpeedEquationFit inside AirLoopHVAC:UnitarySystem #5067

Closed
kbenne opened this issue Aug 3, 2015 · 11 comments
Closed

Coil:Cooling:WaterToAirHeatPump:VariableSpeedEquationFit inside AirLoopHVAC:UnitarySystem #5067

kbenne opened this issue Aug 3, 2015 · 11 comments
Assignees
@rraustad
Labels
Defect Includes code to repair a defect in EnergyPlus PriorityLow This defect or feature has been declared low priority SeverityMedium This defect is medium severity, indicating moderate impact and generally no workaround available
Milestone
EnergyPlus 8.4.0

Comments

@kbenne
Copy link
Contributor

kbenne commented Aug 3, 2015

A Coil:Cooling:WaterToAirHeatPump:VariableSpeedEquationFit instance placed inside of AirLoopHVAC:UnitarySystem with setpoint control option turned on does not work. That is to say the coil appears to be non participating. This is possibly a sizing issue where the component is not given any capacity, but I have not confirmed. Defect file has been uploaded.

UnmetHours Post
@EnergyArchmage
Copy link
Contributor

I concur, ran into this during a recent study and reverted to CoilSystem approach.

Also likely related to #4861 (where VS DX coil has same problem).

@EnergyArchmage
Copy link
Contributor

Also, this can be affected by #4915 when mixing coil types in the same input file.

@Myoldmopar Myoldmopar added this to the EnergyPlus 8.4.0 milestone Aug 13, 2015
@rraustad
Copy link
Contributor

@kbenne I don't see a defect file for this.

@kbenne
Copy link
Contributor Author

kbenne commented Aug 24, 2015

@rraustad that's because I forgot to push it. Here it is now.

https://github.com/NREL/EnergyPlusDevSupport/tree/master/DefectFiles/5000s/5067

nrel-bot referenced this issue Aug 26, 2015
@rraustad
5067 & 4861 Issues with VS coils (Coil:*:WaterToAirHeatPump:VariableS…
804d210 
…peedEquationFit & Coil:*:DX:VariableSpeed)
@rraustad
Copy link
Contributor

Cooling coil is now operating (and from what I can tell, correctly now).
There is something going on in this file that doesn't meet the zone temperature set point "perfectly". Since this is a huge file, I believe the zone temp control issue is elsewhere.

The coil (1.5MW) is turning on now which meets the problem statement.

5067_defectfile_modifiedrunperiod

@mjwitte
Copy link
Contributor

mjwitte commented Sep 1, 2015

@rraustad Why does the predicted load matter when using setpoint control in the unitary system?

@rraustad
Copy link
Contributor

rraustad commented Sep 1, 2015

This test is using LoadBased control ( 5067). The SP models are working well now. I wanted to see if I broke anything and am checking to see if 4861 is also fixed (I think it is).

I inadvertently deleted the last comment. The issue I see is when the HVAC time step is less than the Zone time step. For some reason Predictor does not result in a smooth transition between predictions at the zone time step. The figure below shows the detailed time step predicted load (blue line), with red circles denoting the prediction at the zone time step. I added in the Zone Air System Sensible Cooling Rate to show a time when the simulation downshifts and the UnitarySystem cannot meet the load. However, when I single step at this time, the system is meeting the load to within 1 W.

This is a different issue than what is described in 5067 and 4861. I'm just documenting what I found while investigating poor zone temperature control for 4861..

predictoratreducedtimesteps

@rraustad
Copy link
Contributor

rraustad commented Sep 1, 2015

SP based control appears to be working well now.

Defect file #4861 uses Coil:Cooling:DX:VariableSpeed with SetPoint control. This defect file is compared to a CoilsSystem version with identical results.

4861_results_vscoil

Another file was created to use both a heating and cooling coil. This file controls to the SP as desired. This file uses Coil:*:WaterToAirHeatPump:VariableSpeedEquationFit coils.

5067_testresults_coolheatvscoil

@rraustad
Copy link
Contributor

rraustad commented Sep 1, 2015

Original figure above (5067-testFileZoneLoad_8-3 (Modified RunPeriod)) used load-based control. this figure shows that file when SP control used instead. Much better zone temperature control.

5067_results_vscoil_spcontrol

rraustad added a commit that referenced this issue Sep 2, 2015
@rraustad
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into #5067…
d1df8ac 
…-CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFit-inside-AirLoopHVACUnitarySystem
rraustad added a commit that referenced this issue Sep 2, 2015
@rraustad
Merge branch '#5067-CoilCoolingWaterToAirHeatPumpVariableSpeedEquatio…
fd953a3 
…nFit-inside-AirLoopHVACUnitarySystem' into #4952-VRF-hard-crash-if-terminal-unit-list-error
rraustad added a commit that referenced this issue Sep 2, 2015
@rraustad
Revert "Merge branch '#5067-CoilCoolingWaterToAirHeatPumpVariableSpee…
eaab210 
…dEquationFit-inside-AirLoopHVACUnitarySystem' into #4952-VRF-hard-crash-if-terminal-unit-list-error"

This reverts commit fd953a3, reversing
changes made to 44aca4f.
rraustad added a commit that referenced this issue Sep 3, 2015
@rraustad
Merge branch 'develop' into #5067-CoilCoolingWaterToAirHeatPumpVariab…
8a9575f 
…leSpeedEquationFit-inside-AirLoopHVACUnitarySystem

Conflicts:
	tst/EnergyPlus/unit/Fixtures/EnergyPlusFixture.cc
	tst/EnergyPlus/unit/Fixtures/HVACFixture.hh
	tst/EnergyPlus/unit/HVACUnitarySystem.unit.cc
	tst/EnergyPlus/unit/HVACVariableRefrigerantFlow.unit.cc
nrel-bot referenced this issue Sep 3, 2015
@rraustad
Initial changes to VS coils
26117aa
rraustad added a commit that referenced this issue Sep 8, 2015
@rraustad
Merge branch 'develop' into #5067-CoilCoolingWaterToAirHeatPumpVariab…
a5354d6 
…leSpeedEquationFit-inside-AirLoopHVACUnitarySystem

Conflicts:
	src/EnergyPlus/HVACUnitarySystem.cc
	src/EnergyPlus/HVACUnitarySystem.hh
	tst/EnergyPlus/unit/Fixtures/EnergyPlusFixture.cc
	tst/EnergyPlus/unit/Fixtures/HVACFixture.hh
	tst/EnergyPlus/unit/HVACUnitarySystem.unit.cc
nrel-bot referenced this issue Sep 8, 2015
@rraustad
Merged with develop and work on unit test
2798012
rraustad added a commit that referenced this issue Sep 8, 2015
@rraustad
Merge remote-tracking branch 'remotes/origin/develop' into #5067-Coil…
34e264f 
…CoolingWaterToAirHeatPumpVariableSpeedEquationFit-inside-AirLoopHVACUnitarySystem
nrel-bot referenced this issue Sep 8, 2015
@rraustad
2nd try at merging
1e9ec25
rraustad added a commit that referenced this issue Sep 9, 2015
@rraustad
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into #5067…
1c95322 
…-CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFit-inside-AirLoopHVACUnitarySystem
@rraustad
Copy link
Contributor

rraustad commented Sep 9, 2015

Complete. See #5147

nrel-bot referenced this issue Sep 9, 2015
@rraustad
Minor mod to correct call to VS vs Multispeed coils. Minor mode to ne…
c263dc3 
…w VRF example file.
rraustad added a commit that referenced this issue Sep 15, 2015
@rraustad
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into #5067…
13bb435 
…-CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFit-inside-AirLoopHVACUnitarySystem

Conflicts:
	tst/EnergyPlus/unit/Fixtures/EnergyPlusFixture.cc
	tst/EnergyPlus/unit/HVACUnitarySystem.unit.cc
	tst/EnergyPlus/unit/HVACVariableRefrigerantFlow.unit.cc
rraustad added a commit that referenced this issue Sep 16, 2015
@rraustad
Merge remote-tracking branch 'remotes/origin/develop' into #5067-Coil…
c63ccde 
…CoolingWaterToAirHeatPumpVariableSpeedEquationFit-inside-AirLoopHVACUnitarySystem
rraustad added a commit that referenced this issue Sep 16, 2015
@rraustad
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into #5067…
abc2096 
…-CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFit-inside-AirLoopHVACUnitarySystem

Conflicts:
	tst/EnergyPlus/unit/Fixtures/EnergyPlusFixture.cc
mjwitte added a commit that referenced this issue Sep 18, 2015
@mjwitte
Merge remote-tracking branch 'remotes/origin/develop' into #5067-Coil…
78df25e 
…CoolingWaterToAirHeatPumpVariableSpeedEquationFit-inside-AirLoopHVACUnitarySystem
nrel-bot referenced this issue Sep 18, 2015
@mjwitte
5067 clean up trailing spaces and leading spaces vs tabs
d190cbc
@rraustad rraustad added SeverityMedium This defect is medium severity, indicating moderate impact and generally no workaround available Defect Includes code to repair a defect in EnergyPlus PriorityLow This defect or feature has been declared low priority EnergyPlus and removed EnergyPlus labels Sep 18, 2015
mjwitte added a commit that referenced this issue Sep 19, 2015
@mjwitte
Merge pull request #5147 from NREL/#5067-CoilCoolingWaterToAirHeatPum…
00d74be 
…pVariableSpeedEquationFit-inside-AirLoopHVACUnitarySystem

5067 & 4861 Issues with VS coils (Coil:*:WaterToAirHeatPump:VariableS…
@mjwitte
Copy link
Contributor

mjwitte commented Sep 19, 2015

Closed via #5147

@mjwitte mjwitte closed this as completed Sep 19, 2015
@rraustad rraustad mentioned this issue Sep 19, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rraustad rraustad

Labels
Defect Includes code to repair a defect in EnergyPlus PriorityLow This defect or feature has been declared low priority SeverityMedium This defect is medium severity, indicating moderate impact and generally no workaround available
Projects
None yet
Milestone
EnergyPlus 8.4.0
Development

No branches or pull requests
5 participants
@kbenne @Myoldmopar @mjwitte @rraustad @EnergyArchmage