Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZoneInfiltration Airflow Stats Nominal section displaying wrong units #7029

Closed
3 tasks done
luisclv opened this issue Oct 23, 2018 · 2 comments · Fixed by #7032
Closed
3 tasks done

ZoneInfiltration Airflow Stats Nominal section displaying wrong units #7029

luisclv opened this issue Oct 23, 2018 · 2 comments · Fixed by #7032
Assignees
@jmarrec
Labels
Defect Includes code to repair a defect in EnergyPlus

Comments

@luisclv
Copy link

luisclv commented Oct 23, 2018 •
edited by jmarrec
Loading

Issue overview

After changing the OutputControl:Table:Style object Unit Conversion to InchPound, the ZoneInfiltration Airflow Stats Nominal included in the AllSummary report displays some columns in SI units. The values displayed in the columns are the correct entered values in SI units. The fix will be complete when this report does the conversion for this columns.

image

Details

Some additional details for this issue (if relevant):

  • Platform (Operating system, version): Windows 10
  • Version of EnergyPlus (if using an intermediate build, include SHA): Energyplus 8.9.0

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Defect file added : testfiles/5ZoneAutoDXVAV.idf
  • Ticket added to Pivotal for defect (development team task)
  • Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)
@jmarrec
Copy link
Contributor

jmarrec commented Oct 25, 2018 •
edited
Loading

If you take 5ZoneAutoDXVAV.idf which has already AllSumary and InchPound reporting, you'll find a few more missing conversions, such as Zone Internal Gains Nominal and People Internal Gains Nominal still show person/m2 (while ft2/person works fine)

image

@jmarrec jmarrec self-assigned this Oct 25, 2018
jmarrec added a commit to jmarrec/EnergyPlus that referenced this issue Oct 25, 2018
@jmarrec
NREL#7029 - Add person/m2 conversion
8cd62a8
jmarrec added a commit to jmarrec/EnergyPlus that referenced this issue Oct 25, 2018
@jmarrec
NREL#7029 - Properly format unit to be X/Y-Z and not X/Y/Z or unit co…
c1fecbc 
…nversion fails
@jmarrec jmarrec mentioned this issue Oct 25, 2018
Merged
18 tasks
@jmarrec jmarrec added the Defect Includes code to repair a defect in EnergyPlus label Oct 25, 2018
Myoldmopar added a commit that referenced this issue Nov 13, 2018
@Myoldmopar
Merge pull request #7032 from jmarrec/PR_opened/7029_IPConversionReport
34b1cf1 
#7029 - Fix IP conversion report units
@Myoldmopar
Copy link
Member

Closed via #7032

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmarrec jmarrec

Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #7029 - IP conversion report units jmarrec/EnergyPlus
3 participants
@Myoldmopar @jmarrec @luisclv