Fix #7029 - IP conversion report units

[jmarrec]

Pull request overview

Fix #7029: Added "person/m2" to unitConv, and modified some units for eg m3/s/m2 to be m3/s-m2 to be correctly picked up for conversion. Added the new unitConv to an existing Gtest.

After changes it correctly converts the units (the before can be seen in #7029) (both label and conversion factor are ok).

Work Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• At least one of the following appropriate labels must be added to this PR to be consumed into the changelog:
  • Defect: This pull request repairs a github defect issue. The github issue should be referenced in the PR description
  • Refactoring: This pull request includes code changes that don't change the functionality of the program, just perform refactoring
  • NewFeature: This pull request includes code to add a new feature to EnergyPlus
  • Performance: This pull request includes code changes that are directed at improving the runtime performance of EnergyPlus
  • DoNoPublish: This pull request includes changes that shouldn't be included in the changelog

Review Checklist

This will not be exhaustively relevant to every PR.

• Functional code review (it has to work!)
• If defect, results of running current develop vs this branch should exhibit the fix
• CI status: all green or justified
• Performance: CI Linux results include performance check
• Unit Test(s)
• C++ checks:
  • Argument types
  • If any virtual classes, ensure virtual destructor included, other things
• IDD changes:
  • Verify naming conventions and styles, memos and notes and defaults
  • Open windows IDF Editor with modified IDD to check for errors
  • If transition, add to input rules file for interfaces
  • If transition, add transition source
  • If transition, update idfs
• If new idf included, locally check the err file and other outputs
• Required documentation updates?
• ExpandObjects changes?
• If output changes, including tabular output structure, add to output rules file for interfaces

[nrel-bot]

@jmarrec @lgentile it has been 14 days since this pull request was last updated.

[Myoldmopar]

@jmarrec I pulled the latest NREL/develop into this branch to get some fresh, cleaned up, CI results. I'll take a peek at this later today after CI does its runs.

[Myoldmopar]

OK, so m3/s-m2 is already the accepted unit conversion in E+, this output was simply entered incorrectly in this string. 👍

[Myoldmopar]

No problems here.

[Myoldmopar]

CI is looking happy with it so far. I'm building it locally and will mess around with it.

[Myoldmopar]

Tested locally using 1ZoneEvapCooler.idf as the test file.

Baseline branch:

• Ran original file: got {m3/s/m2}
• Changed to InchPound: other units converted, but still got m3/s/m2

This branch:

• Ran original file: got {m3/s-m2} GOOD
• Changed to InchPound: got {ft3/min-ft2} GREAT!

I don't see any red flags with this. I'll let CI finish the integration coverage, which is the longest of the tests, but I suspect in an hour or so when it's done with that, and the custom-check test, it'll be green and I'll merge this in.

[Myoldmopar]

CI is super happy. Merging.