Fix calculation of node RH, wetbulb, and dewpoint for EMS sensors if not also requested as an output variable #5307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NodeInputManager.unit.cc was not in CMakeLists correct logic for check, correct string comparison, correct schedule number got unit test work single run
…CalcMoreNodeInfo-detect-EMS-Sensors
remove extra semicolon
| @@ -1141,8 +1145,21 @@ namespace NodeInputManager { | |||
| } | |||
| } | |||
| } | |||
| if ( EMSManager::CheckIfNodeMoreInfoSensedByEMS( iNode, "System Node Wetbulb Temperature" ) ) { | |||
There was a problem hiding this comment.
@Myoldmopar Style question - do we have a preference for new code for "using" verses full reference?
EMSManager::CheckIfNodeMoreInfoSensedByEMS( )
vs
using EMSManager
...
CheckIfNodeMoreInfoSensedByEMS( )
There was a problem hiding this comment.
I much prefer the full scope instead of using statements. This goes against the majority of the code, but that is likely where we are going eventually...
mjwitte
changed the title
mjwitte
added a commit
that referenced
this pull request
Nov 10, 2015
…ensors Fix calculation of node RH, wetbulb, and dewpoint for EMS sensors if not also requested as an output variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4232.