Improve invalid zenith angle handling in Sandia PV model #5529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add recurring warning if any generator produces negative electric or thermal power
Add simple test of function AbsoluteAirMass.
3 tasks
Forgot that there are times when microcogen and PVT will producing cooling (heat capacity in cold engine and night sky cooling)
…rap-Neg-SandiaPV-Zenith
|
@EnergyArchmage I then pulled this branch down and merged in my conflict resolution and updating from over in #5512, so this is clean and up to date also. |
… into 5528-Generators-Trap-Neg-SandiaPV-Zenith
…ap-Neg-SandiaPV-Zenith
|
Code changes look good. I ran the defect file in develop and saw the failure. This branch runs well. Things are good. Merging. |
|
#5570 for build warning here. |
Myoldmopar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #5528. branches off of and depends on PR 5512