Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard air density to calculate oa mass flow rate in dual duct for consistency #5781

Conversation

lgu1234
Copy link
Contributor

@lgu1234 lgu1234 commented Jul 19, 2016

Pull request overview

Addresses #5769.

StdRhoAir is used to calculate OA mass flow rates in DualDuct::CalcOAOnlyMassFlow and DualDuct::CalcOAMassFlow.

Differences were found in DOASDualDuctSchool.idf as expected.

Work Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • At least one of the following appropriate labels must be added to this PR to be consumed into the changelog:
    • Defect: This pull request repairs a github defect issue. The github issue should be referenced in the PR description
    • Refactoring: This pull request includes code changes that don't change the functionality of the program, just perform refactoring
    • NewFeature: This pull request includes code to add a new feature to EnergyPlus
    • Performance: This pull request includes code changes that are directed at improving the runtime performance of EnergyPlus
    • DoNoPublish: This pull request includes changes that shouldn't be included in the changelog

Review Checklist

This will not be exhaustively relevant to every PR.

  • Code style (parentheses padding, variable names)
  • Functional code review (it has to work!)
  • If defect, results of running current develop vs this branch should exhibit the fix
  • CI status: all green or justified
  • Performance: CI Linux results include performance check -- verify this
  • Unit Test(s)
  • C++ checks:
    • Argument types
    • If any virtual classes, ensure virtual destructor included, other things
  • IDD changes:
    • Verify naming conventions and styles, memos and notes and defaults
    • Open windows IDF Editor with modified IDD to check for errors
    • If transition, add rules to spreadsheet
    • If transition, add transition source
    • If transition, update idfs
  • If new idf included, locally check the err file and other outputs
  • Documentation changes in place
  • ExpandObjects changes??
  • If output changes, including tabular output structure, add to output rules file for interfaces

@mjwitte mjwitte added the Defect Includes code to repair a defect in EnergyPlus label Jul 21, 2016
@nrel-bot-3
Copy link

@mjwitte @lgu1234 @lgentile it has been 16 days since this pull request was last updated.

@Myoldmopar Myoldmopar merged commit f7f9e52 into develop Aug 12, 2016
@Myoldmopar Myoldmopar deleted the 126082187-Use-StdRhoAir-to-calculate-OA-mass-flow-rate-in-DualDuct-for-consistency-#5769 branch August 12, 2016 11:35
@mjwitte mjwitte changed the title 126082187 use std rho air to calculate oa mass flow rate in dual duct for consistency #5769 Use standard air density to calculate oa mass flow rate in dual duct for consistency Aug 15, 2016
@mjwitte
Copy link
Contributor

mjwitte commented Aug 15, 2016

@Myoldmopar OK to close #5769?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants