PTAC hot water heating coil undersized for ventilation load #6079

rraustad · 2017-03-23T02:44:04Z

Pull request overview

User file has PTACs with hot water heating coils. PTACs provide ventilation air. For zones with a zero design heating load, the PTAC heating coil is undersized and cannot temper the ventilation load. This change addresses #6028 and results in a 3 to 4 fold increase in water heating coil size in some cases. This change also results in component air flow sizing the same as the Packaged Terminal unit.

Work around: adding a small negative other equipment load to those zones in order to force a non-zero design heating load fixes the coil sizing.

Work Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
At least one of the following appropriate labels must be added to this PR to be consumed into the changelog:
- Defect: This pull request repairs a github defect issue. The github issue should be referenced in the PR description
- Refactoring: This pull request includes code changes that don't change the functionality of the program, just perform refactoring
- NewFeature: This pull request includes code to add a new feature to EnergyPlus
- Performance: This pull request includes code changes that are directed at improving the runtime performance of EnergyPlus
- DoNoPublish: This pull request includes changes that shouldn't be included in the changelog

Review Checklist

This will not be exhaustively relevant to every PR.

Code style (parentheses padding, variable names)
Functional code review (it has to work!)
If defect, results of running current develop vs this branch should exhibit the fix
CI status: all green or justified
Performance: CI Linux results include performance check -- verify this
Unit Test(s)
C++ checks:
- Argument types
- If any virtual classes, ensure virtual destructor included, other things
IDD changes n/a

…-PTAC-heating-coil-undersized-for-ventilation-load-when-zone-design-heating-load-is-zero

rraustad · 2017-03-23T02:45:40Z

Defect file now meets heating set point temperature.

rraustad · 2017-03-23T10:49:27Z

OK, so the fix appears to work but it highlights another issue for sizing. Diff's in EMSCurveOverride_PTHP. The "design" flow rate is now the user specified in the PTHP since we tell the sizing routine what the PTHP wants the child component flow to size to. What the "design" flow was before was the design zone heating flow rate, what it is now is what the parent sized to. If the parent was autosized, the flow would be the "design". Since the parent is not autosized, the "design" for the children is the user specified parent flow (not the sizing results). So this is right but it's wrong.

- Component Sizing Information, Fan:OnOff, ZONE1PTHPFAN, Design Size Maximum Flow Rate [m3/s], 0.36202
+ Component Sizing Information, Fan:OnOff, ZONE1PTHPFAN, Design Size Maximum Flow Rate [m3/s], 0.32000
 Component Sizing Information, Fan:OnOff, ZONE1PTHPFAN, User-Specified Maximum Flow Rate [m3/s], 0.32000
- Component Sizing Information, Coil:Cooling:DX:SingleSpeed, ZONE1PTHPDXCOOLCOIL, Design Size Rated Air Flow Rate [m3/s], 0.36202
+ Component Sizing Information, Coil:Cooling:DX:SingleSpeed, ZONE1PTHPDXCOOLCOIL, Design Size Rated Air Flow Rate [m3/s], 0.32000
- Component Sizing Information, Coil:Heating:DX:SingleSpeed, ZONE1PTHPDXHEATCOIL, Design Size Rated Air Flow Rate [m3/s], 0.36202
+ Component Sizing Information, Coil:Heating:DX:SingleSpeed, ZONE1PTHPDXHEATCOIL, Design Size Rated Air Flow Rate [m3/s], 0.32000

ZoneHVAC:PackagedTerminalHeatPump,
  Zone1PTHP,               !- Name
  FanAndCoilAvailSched,    !- Availability Schedule Name
  Zone1PTHPAirInletNode,   !- Air Inlet Node Name
  Zone1PTHPAirOutletNode,  !- Air Outlet Node Name
  OutdoorAir:Mixer,        !- Outdoor Air Mixer Object Type
  Zone1PTHPOAMixer,        !- Outdoor Air Mixer Name
  0.32,                    !- Cooling Supply Air Flow Rate {m3/s}
  0.32,                    !- Heating Supply Air Flow Rate {m3/s}

Fan:OnOff,
  Zone1PTHPFan,            !- Name
  FanAndCoilAvailSched,    !- Availability Schedule Name
  0.5,                     !- Fan Total Efficiency
  75.0,                    !- Pressure Rise {Pa}
  0.32,                    !- Maximum Flow Rate {m3/s}

rraustad · 2017-03-23T13:52:08Z

I think I have a method to save the design values and report these instead of the parent object values. This isn't fully tested with things like scalable sizing, etc. but appears to work (i.e., logic of where to switch the saved value with the design value may change).

We'll see what the CI thinks.

mjwitte · 2017-03-23T13:55:59Z

Is that really what we want? One could argue that the size set by the parent is the design size, which the user might override with a hard value. Just thinking out loud.

rraustad · 2017-03-23T14:03:03Z

There are many options to what we may want to report. And your right, if the parent object passes information to the child, the parent object report of design vs user is still valid. So the user could look there for that type of info. I had also thought of supressing the "design" report for child components since it doesn't mean much when the parent sets the size. I just wanted to be able to get back to where we were and see if I could do it without much effort. Well, as to effort, this would have to be added in many places in ReportSizingManager if we choose this route.

This one is borderline as to getting into V8.7 so getting back to where we were and making a decision later is not a bad move.

Also, the water heating coil sizes are much larger now. This sort of makes sense but am weary of the consequences.

rraustad · 2017-03-23T17:25:43Z

OK, now OutdoorAirUnit fails and changes the design size from what is specified by the parent to the zone design air flow rate. This is wrong since the OA flow rate is not the same as the zone flow rate to meet the zone load. So unless non-zone related equipment is treated differently, then what we do now is OK for the time being.

…-PTAC-heating-coil-undersized-for-ventilation-load-when-zone-design-heating-load-is-zero

rraustad · 2017-03-23T23:17:38Z

Nothing unexpected here except the convergence issue with MicroCogeneration, loads exceed 0.04W and hits a whopping 0.06W max. Also a few more plant loop temp warnings (from 4 to 25 with max temps rising from 108 to 127). The water heating coils did increase by x3-x4 in size.

rraustad · 2017-03-23T23:52:04Z

MicroCogeneration passes warmup convergence in 6 warmup days on Windows. So why does this fail on Mac and Linux?

nrel-bot-3 · 2017-04-08T00:33:12Z

@rraustad @lgentile it has been 14 days since this pull request was last updated.

…PTAC-heating-coil-undersized-for-ventilation-load-when-zone-design-heating-load-is-zero

EnergyArchmage · 2017-04-21T14:42:23Z

src/EnergyPlus/ReportSizingManager.cc

@@ -1094,10 +1099,16 @@ namespace ReportSizingManager {
 						NominalCapacityDes = DesMassFlow * DataWaterCoilSizHeatDeltaT * Cp * rho;
 						// if coil is part of a zonal unit, calc coil load to get hot water flow rate
 					} else {
+						if ( ZoneEqSizing( CurZoneEqNum ).SystemAirFlow ) {
+							DesMassFlow = ZoneEqSizing( CurZoneEqNum ).AirVolFlow * StdRhoAir;
+						} else if ( ZoneEqSizing( CurZoneEqNum ).HeatingAirFlow ) {


The logic flow here seems a little suspect. I would expect an if - else-if block to be such that only one would be satisfied at a given time, but here both ZoneEqSizing( CurZoneEqNum ).SystemAirFlow and ZoneEqSizing( CurZoneEqNum ).HeatingAirFlow are often true at the same time, like it is in the unit test now. So it will flow to the if and skip the else-if even though it is also satisfied. That may be what you want but it seems hard to follow.

I look at this as priority order when more than 1 is true.

EnergyArchmage · 2017-04-21T14:42:28Z

src/EnergyPlus/PackagedTerminalHeatPump.cc

@@ -4186,6 +4186,15 @@ namespace PackagedTerminalHeatPump {
 		if ( CurZoneEqNum > 0 ) {
 			ZoneEqSizing( CurZoneEqNum ).OAVolFlow = max( PTUnit( PTUnitNum ).CoolOutAirVolFlow, PTUnit( PTUnitNum ).HeatOutAirVolFlow );
 			ZoneEqSizing( CurZoneEqNum ).AirVolFlow = max( PTUnit( PTUnitNum ).MaxCoolAirVolFlow, PTUnit( PTUnitNum ).MaxHeatAirVolFlow );
+			// save air flow rates for child object sizing
+			if( PTUnit( PTUnitNum ).MaxCoolAirVolFlow > 0.0 ) {


The bools SystemAirFlow, CoolingAirFlow, and HeatingAirFlow are true whenever the values are calculated, but what is really needed is to know which one needs to be used. So instead of a test like "PTUnit( PTUnitNum ).MaxCoolAirVolFlow > 0.0," I would look for conditions like "PTUnit( PTUnitNum ).MaxCoolAirVolFlow > PTUnit( PTUnitNum ).MaxHeatAirVolFlow." I just find it a bit confusing that both CoolingAirFlow and HeatingAirFlow can be true at the same time. just a minor comment since this is already the way it is.

The PTAC and PTHP have inputs for cooling, heating and OA flow rates. So this was set up to allow cooling and heating flow rates to be sized differently (e.g., scalable sizing).

EnergyArchmage · 2017-04-28T13:37:28Z

okay, think this is ready to merge.

Only serious diff from CI is in MicroCogeneration integration test and the lack of convergence in the heating design day. The hot water loop is coming out 2.7 times larger, which is expected with these changes, but the model has a mix of hard sizes and autosizes. The increased flow rate on the stratified tank use side is now washing out the tank's stratification compared to the reference case and makes for less stable hot water supply. Increasing the tank's volume (a hardsized value) solves the convergence problem. commited a modified MicroCogeneration.idf file.

Other diffs are expected. will merge once CI comes back.

nrel-bot-3 · 2017-05-14T00:30:49Z

@rraustad @lgentile it has been 15 days since this pull request was last updated.

…-heating-coil-undersized-for-ventilation-load-when-zone-design-heating-load-is-zero Conflicts: src/EnergyPlus/ReportSizingManager.cc

mjwitte

@rraustad I've merged in develop and tested the defect file (which fails in debug mode due to messed up geometry - probably need a new issue for that . . .) with both design days and annual. The 2000+ hours of setpoint not met during occupied heating are now down to 9. Success.

But spot checking a couple of coils show they are significantly oversized compared to the max load on the heating design day.

THERMAL ZONE FLR1 CORE1 PTAC HEATING COIL, Design Size 9486W, max load 3678W.
UNIT 116 PTAC HEATING COIL, Design Size 2475W, max load 1380W.

Is that expected? Could we do better?

Looking at HVACTemplate-5ZonePTAC, the SPACE2-1 PTAC HEATING COIL design coil load was 3890W and now it's 20272W. And the max load across design days and annual is only 4432W. Can we explain this?

rraustad · 2017-05-26T18:19:48Z

Zone Sizing Information, THERMAL ZONE FLR1 CORE1, Cooling, 5295.37915, 6089.68603, 0.50085, 0.57598, DENVER-STAPLETON ANN CLG .4% CONDNS DB=>MWB, 7/21 17:45:00, 30.83200, 6.29873E-003, 235.68707, 1.64367, 4.01155E-002, 0.00000
Zone Sizing Information, THERMAL ZONE FLR1 CORE1, Heating, 2394.80752, 2993.50940, 0.22671, 0.28339, DENVER-STAPLETON ANN HTG 99.6% CONDNS DB, 12/21 24:00:00, -20.00000, 7.70947E-004, 235.68707, 1.64367, 4.01155E-002, 0.00000

The packaged units are sizing cooling and heating air flow rate as the max of either, when non-HP type units could operate at their own air flow rate as with the UnitarySystem?

Component Sizing Information, ZoneHVAC:PackagedTerminalAirConditioner, THERMAL ZONE FLR1 CORE1 PTAC, Design Size Cooling Supply Air Flow Rate [m3/s], 0.57598
Component Sizing Information, ZoneHVAC:PackagedTerminalAirConditioner, THERMAL ZONE FLR1 CORE1 PTAC, Design Size Heating Supply Air Flow Rate [m3/s], 0.57598

Both heating and cooling air flow rate are sized as:

AutosizeDes = max( FinalZoneSizing( CurZoneEqNum ).DesCoolVolFlow, FinalZoneSizing( CurZoneEqNum ).DesHeatVolFlow );

So yes, I'd say this is expected given how these models size air flow rate. Should this be changed, probably.

rraustad · 2017-05-26T18:29:17Z

I'll have to look at HVACTemplate-5ZonePTAC a little closer to see why that coil is sized so large.

mjwitte · 2017-05-26T18:30:38Z

I haven't looked closely at the equations used here, but seems that this should be able to size closer to the zone heating load plus ventilation load, regardless of the supply air flow rate, similar to how reheat coils are sized.

rraustad · 2017-08-06T00:53:52Z

@mjwitte I like this one, it makes sense to me.

rraustad · 2017-08-06T02:29:12Z

If I plot SAT again with this change, with Unit 206 coil capacity being 1/3 the size of the original fix, and it still maintains the same SAT, what does that say? It says this looks good.

rraustad · 2017-08-06T19:33:23Z

The defect file looks good now. The peak heating capacity needed to meet the TSTAT temp is about 3000 W for Unit 116 and 4000 W for Unit 206. The coils sized at 4051 W and 5928 W. UA looks reasonable as well after I corrected the design inlet air temperature used for water coils.

Component Sizing Information, Coil:Heating:Water, UNIT 116 PTAC HEATING COIL, Design Size Rated Capacity [W], 4051.19022
Component Sizing Information, Coil:Heating:Water, UNIT 116 PTAC HEATING COIL, Design Size Maximum Water Flow Rate [m3/s], 3.48497E-005
Component Sizing Information, Coil:Heating:Water, UNIT 116 PTAC HEATING COIL, Design Size U-Factor Times Area Value [W/K], 52.89808
Water Heating Coil Capacity Information,Coil:Heating:Water,UNIT 116 PTAC HEATING COIL,2609.03

Component Sizing Information, Coil:Heating:Water, UNIT 206 PTAC HEATING COIL, Design Size Rated Capacity [W], 5928.76053
Component Sizing Information, Coil:Heating:Water, UNIT 206 PTAC HEATING COIL, Design Size Maximum Water Flow Rate [m3/s], 5.10012E-005
Component Sizing Information, Coil:Heating:Water, UNIT 206 PTAC HEATING COIL, Design Size U-Factor Times Area Value [W/K], 76.96975
Water Heating Coil Capacity Information,Coil:Heating:Water,UNIT 206 PTAC HEATING COIL,3818.03

rraustad · 2017-08-17T02:01:43Z

src/EnergyPlus/ReportSizingManager.cc

+						} else {
+							OutAirFrac = 0.0;
+						}
+						CoilInTemp = ( 1.0 - OutAirFrac ) * FinalZoneSizing( CurZoneEqNum ).ZoneTempAtHeatPeak + OutAirFrac * FinalZoneSizing( CurZoneEqNum ).OutTempAtHeatPeak;


What is changed throughout water coil sizing is how the inlet air temperature is calculated. The FinalZoneSizing variable for DesHeatCoilInTemp is wrong at times where the zone air flow rate is <= the OA flow rate. When this happens, the coil inlet temp is = the OA temp. But it's not really, when the water coil is in a parent that operates at a higher air flow rate. So to correct this, the operating coil inlet temp is calculated based on the OA fraction. This is done for water coil inlet T, w, and for the capacity and UA calculation. This method took many iterations as can be seen in the discussion. The result with this method is still a larger coil, but not 4 or 5 times larger as with the initial attempts.

rraustad · 2017-08-17T02:09:33Z

src/EnergyPlus/ReportSizingManager.cc

@@ -806,10 +806,21 @@ namespace ReportSizingManager {
 					} else if ( ZoneEqUnitHeater || ZoneEqVentedSlab ) {  // for unit ventilator the cp value is calculated at 5.05(InitConvTemp) for the child and 60.0C for the unit ventilator //|| ZoneEqUnitVent
 						AutosizeDes = ZoneEqSizing( CurZoneEqNum ).MaxHWVolFlow;
 					} else {
-						CoilInTemp = FinalZoneSizing( CurZoneEqNum ).DesHeatCoilInTemp;


These new sections get the parent air flow rate and then calculate the OA fraction so a "revised" variable can be calculated based on the zone temp/humrat and OA temp/humrat.

rraustad · 2017-08-20T02:54:12Z

This is ready for final review.

rraustad · 2017-08-20T02:54:36Z

Except for the conflicts.

…-PTAC-heating-coil-undersized-for-ventilation-load-when-zone-design-heating-load-is-zero Conflicts: tst/EnergyPlus/unit/PackagedTerminalHeatPump.unit.cc

…-heating-coil-undersized-for-ventilation-load-when-zone-design-heating-load-is-zero

mjwitte

Defect file results look very good. Total boiler capacity is about 50% greater and unmet heating hours are down to 5 now from >2000 before. Merge up to latest develop - hoping the build warnings go away.

mjwitte · 2017-08-24T00:05:14Z

src/EnergyPlus/ReportSizingManager.cc

+						} else {
+							OutAirFrac = 0.0;
+						}
+						CoilInTemp = ( 1.0 - OutAirFrac ) * FinalZoneSizing( CurZoneEqNum ).ZoneTempAtHeatPeak + OutAirFrac * FinalZoneSizing( CurZoneEqNum ).OutTempAtHeatPeak;
 						CoilInHumRat = FinalZoneSizing( CurZoneEqNum ).DesHeatCoilInHumRat;


Doesn't CoilInHumRat also need to be calculated as a combination of OA and Zone conditions?
Also, more general comment, not following why essentially the same code needs to be inserted in this function multiple times. This is the 4th or 5th place now.

Also, don't we need similar changes for cooling coil sizing?

I didn't think that humrat would severely affect heating coil sizing, but yes, it should use the same method (and I was just trying the get this to work and ran out of steam). These changes evolved to a point where I think now I understand why the sizing data (T and w) isn't applicable when a zone coil is used in a parent object operating at a higher flow rate. So I think this type of change would be pervasive throughout sizing.

Same code 4 or 5 times... anytime coil inlet T needs to be calculated, the new method should be used.

Just seems like that could all happen in one block of code. It's fine for now, but at some future point, this could possibly be refactored to consolidate similar calcs.

CoilInHumRat only needed to be changed here.

CoolingWaterDesAirInletTempSizing already uses this method for ZoneEqFanCoil except it needs to use the parent flow rate if applicable and the else needs to be fixed.

CoolingWaterDesAirInletHumRatSizing already uses this method for ZoneEqFanCoil except it needs to use the parent flow rate if applicable and the else needs to be fixed.

CoolingCapacitySizing needs these changes

I think that's it.

It looks like there's a place in HeatingCapacitySizing (non-water coils) that could use this change, but without a defect file I'm scared to change it. I'm going to add a warning there to see if any example files use that line of code.

mjwitte · 2017-08-24T00:10:20Z

src/EnergyPlus/ZoneEquipmentManager.cc

 						}
 						FinalZoneSizing( CtrlZoneNum ).ZoneHumRatAtHeatPeak = ZoneSizing( DDNumF, CtrlZoneNum ).HeatZoneHumRatSeq( TimeStepAtPeakF );
+						FinalZoneSizing( CtrlZoneNum ).OutHumRatAtHeatPeak = ZoneSizing( DDNumF, CtrlZoneNum ).HeatOutHumRatSeq( TimeStepAtPeakF );


Are we already saving OutTempAtCoolPeak and OutHumRatAtCoolPeak somwhere?

Same comment as above, I was focusing on getting this fix to work. This same change needs to be applied to zone cooling coil.

So, do you want to add to this PR or open a new one for additional changes?

I guess I still have time. I'll go through and update humrat for zone heating coils and take a look at what the cooling coils need. I may not change those due to diff's but I guess we know what diff's this change caused so any change in diff's would be due to changes in cooling coil sizing.

If you remember this issue, these same changes were never applied to cooling since we've never really seen sizing problems with cooling coils.

// issue 6006, heating coils sizing to 0 when no heating load in zone if ( ZoneSizing( DDNumF, CtrlZoneNum ).DesHeatSetPtSeq.empty() ) { ShowSevereError( RoutineName + ": Thermostat heating set point temperatures not initialized for Zone = " + FinalZoneSizing( CtrlZoneNum ).ZoneName ); ShowFatalError( "Please send your input file to the EnergyPlus support/development team for further investigation." ); } else { FinalZoneSizing( CtrlZoneNum ).ZoneTempAtHeatPeak = *std::max_element( ZoneSizing( DDNumF, CtrlZoneNum ).DesHeatSetPtSeq.begin(), ZoneSizing( DDNumF, CtrlZoneNum ).DesHeatSetPtSeq.end() ); FinalZoneSizing( CtrlZoneNum ).OutTempAtHeatPeak = *std::min_element( ZoneSizing( DDNumF, CtrlZoneNum ).HeatOutTempSeq.begin(), ZoneSizing( DDNumF, CtrlZoneNum ).HeatOutTempSeq.end() ); }

Oh wait, I see it now. That change was made for both cooling and heating. Line 2776 of ZoneEquipmentManager.

In the above code snippet, this line is missing for cooling at line 2782. Same for OutHumRatAtCoolPeak.

FinalZoneSizing( CtrlZoneNum ).OutTempAtHeatPeak = *std::min_element( ZoneSizing( DDNumF, CtrlZoneNum ).HeatOutTempSeq.begin(), ZoneSizing( DDNumF, CtrlZoneNum ).HeatOutTempSeq.end() );

…lLoadUsedForUASizing

mjwitte · 2017-08-24T22:36:09Z

@rraustad Is this ready for final review?

rraustad · 2017-08-24T23:18:07Z

No, I added this warning to find the files that used a place where I want to make a change. Now I have test files to look at while making this change.

+   ** Warning ** SizeUnitVentilator: Sizing for ZoneHVAC:UnitVentilator TU1 using DesHeatCoilInTemp without checking for OA fraction.

rraustad · 2017-08-25T01:06:38Z

Wow, this is so risky. If the equipment models are not set up properly I could break something. In addition, the SystemAirFlow flag should only be used for fans. HeatingAirFlow and CoolingAirFlow are used for coils. The way the equipment models are set up now, some set SystemAirFlow only, some don't set any, and some set one or both coil flags. In the ReportSizingManager sizing functions for coils (e.g., HeatingCapacitySizing or CoolingCapacitySizing) there should not be a SystemAirFlow test, nor a test for the opposite coil type. Then there's the zone equipment scaling functions, they all use SystemAirFlow. This all needs to be sorted out eventually, it's just that it's too close to release to be taking a crack at it now.

…-PTAC-heating-coil-undersized-for-ventilation-load-when-zone-design-heating-load-is-zero

rraustad · 2017-08-25T01:31:26Z

Sorry, I just see too many black holes.

I updated issue #6172.

rraustad · 2017-08-25T02:14:39Z

@mjwitte I did take a crack at it tonight and saw too many issues that scared the steel out of me.

mjwitte · 2017-08-25T16:06:45Z

Ran all of the files with diffs as annuals. Annual energy use and not met hrs diffs are tiny.

rraustad added 2 commits March 22, 2017 22:42

Correct child component sizing

e7c1cca

Merge branch 'develop' of https://github.com/NREL/EnergyPlus into #6028…

7ded76a

…-PTAC-heating-coil-undersized-for-ventilation-load-when-zone-design-heating-load-is-zero

Add tentative method to save actual design data for reporting

fe0f88e

rraustad added 2 commits March 23, 2017 13:36

Revert attempt to align design sizing with child components

84b035d

Merge branch 'develop' of https://github.com/NREL/EnergyPlus into #6028…

a8b658f

…-PTAC-heating-coil-undersized-for-ventilation-load-when-zone-design-heating-load-is-zero

rraustad changed the title ~~ptac heating coil undersized for ventilation load when zone design heating load is zero #6028~~ ptac water heating coil undersized for ventilation load #6028 Mar 23, 2017

rraustad self-assigned this Mar 24, 2017

rraustad requested a review from mjwitte March 24, 2017 13:11

rraustad added the Defect Includes code to repair a defect in EnergyPlus label Mar 24, 2017

Merge remote-tracking branch 'refs/remotes/origin/develop' into #6028-…

a609699

…PTAC-heating-coil-undersized-for-ventilation-load-when-zone-design-heating-load-is-zero

EnergyArchmage reviewed Apr 21, 2017

View reviewed changes

MicroCogeneration.idf, increase stratified tank volume

7729a39

Merge remote-tracking branch 'remotes/origin/develop' into #6028-PTAC…

08e69b8

…-heating-coil-undersized-for-ventilation-load-when-zone-design-heating-load-is-zero Conflicts: src/EnergyPlus/ReportSizingManager.cc

mjwitte changed the title ~~ptac water heating coil undersized for ventilation load #6028~~ PTAC hot water heating coil undersized for ventilation load May 26, 2017

mjwitte reviewed May 26, 2017

View reviewed changes

Calculate mixed air temp for sizing zone water coils

7c26f0d

rraustad added 2 commits August 6, 2017 15:54

Final changes

be9e39f

Update unit test, correct coil inlet air temp calculation

a7c38d0

mjwitte modified the milestone: EnergyPlus 8.8.0 Aug 14, 2017

rraustad commented Aug 17, 2017

View reviewed changes

rraustad assigned mjwitte Aug 20, 2017

rraustad and others added 2 commits August 19, 2017 23:14

Merge branch 'develop' of https://github.com/NREL/EnergyPlus into #6028…

e3b346e

…-PTAC-heating-coil-undersized-for-ventilation-load-when-zone-design-heating-load-is-zero Conflicts: tst/EnergyPlus/unit/PackagedTerminalHeatPump.unit.cc

Merge remote-tracking branch 'remotes/origin/develop' into #6028-PTAC…

a00ab1a

…-heating-coil-undersized-for-ventilation-load-when-zone-design-heating-load-is-zero

mjwitte reviewed Aug 24, 2017

View reviewed changes

Update humrat calculation for water coil sizing in HeatingWaterDesCoi…

a6e1d7e

…lLoadUsedForUASizing

rraustad added 2 commits August 24, 2017 21:29

Leave well enough alone

780ff25

Merge branch 'develop' of https://github.com/NREL/EnergyPlus into #6028…

4a9fe52

…-PTAC-heating-coil-undersized-for-ventilation-load-when-zone-design-heating-load-is-zero

rraustad mentioned this pull request Aug 25, 2017

Sizing Consolidation - Next Steps #6172

Open

23 tasks

mjwitte merged commit 8856cdf into develop Aug 25, 2017

mjwitte deleted the #6028-PTAC-heating-coil-undersized-for-ventilation-load-when-zone-design-heating-load-is-zero branch August 25, 2017 16:08

rraustad added a commit that referenced this pull request Aug 26, 2017

Add OutTempAtCoolPeak and OutHumRatAtCoolPeak (#6079)

08075a5

mjwitte mentioned this pull request Jan 8, 2018

PTAC heating coil undersized for ventilation load when zone design heating load is zero #6028

Closed

3 tasks

PTAC hot water heating coil undersized for ventilation load #6079

PTAC hot water heating coil undersized for ventilation load #6079

Conversation

rraustad commented Mar 23, 2017 • edited by mjwitte

Pull request overview

Work Checklist

Review Checklist

rraustad commented Mar 23, 2017

rraustad commented Mar 23, 2017

rraustad commented Mar 23, 2017

mjwitte commented Mar 23, 2017

rraustad commented Mar 23, 2017

rraustad commented Mar 23, 2017 • edited

rraustad commented Mar 23, 2017

rraustad commented Mar 23, 2017

nrel-bot-3 commented Apr 8, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

EnergyArchmage commented Apr 28, 2017

nrel-bot-3 commented May 14, 2017

mjwitte left a comment

Choose a reason for hiding this comment

rraustad commented May 26, 2017

rraustad commented May 26, 2017

mjwitte commented May 26, 2017

rraustad commented Aug 6, 2017

rraustad commented Aug 6, 2017 • edited

rraustad commented Aug 6, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rraustad commented Aug 20, 2017

rraustad commented Aug 20, 2017

mjwitte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rraustad Aug 24, 2017 • edited

Choose a reason for hiding this comment

rraustad Aug 24, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mjwitte commented Aug 24, 2017

rraustad commented Aug 24, 2017

rraustad commented Aug 25, 2017

rraustad commented Aug 25, 2017 • edited

rraustad commented Aug 25, 2017

mjwitte commented Aug 25, 2017

rraustad commented Mar 23, 2017 •

edited by mjwitte

rraustad commented Mar 23, 2017 •

edited

rraustad commented Aug 6, 2017 •

edited

rraustad Aug 24, 2017 •

edited

rraustad Aug 24, 2017 •

edited

rraustad commented Aug 25, 2017 •

edited