Glazing enhancements - input glazing properties as a function of incident angle #6114

lgu1234 · 2017-05-02T17:45:45Z

Pull request overview

This new feature allows users to input glazing properties of transmittance, front reflectance, and back reflectance as a function of incident angle, in addition to existing inputs as a function of wavelength.

Work Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
At least one of the following appropriate labels must be added to this PR to be consumed into the changelog:
- Defect: This pull request repairs a github defect issue. The github issue should be referenced in the PR description
- Refactoring: This pull request includes code changes that don't change the functionality of the program, just perform refactoring
- NewFeature: This pull request includes code to add a new feature to EnergyPlus
- Performance: This pull request includes code changes that are directed at improving the runtime performance of EnergyPlus
- DoNoPublish: This pull request includes changes that shouldn't be included in the changelog

Review Checklist

This will not be exhaustively relevant to every PR.

mjwitte

Some initial comments on the code. Have not reviewed docs or tried the run this yet.

mjwitte · 2017-05-10T13:48:50Z

idd/Energy+.idd.in

@@ -85322,7 +85330,122 @@ Table:TwoIndependentVariables,
  N720,N721,N722,N723,N724,N725,N726,N727,N728,N729,N730,N731,N732,N733,N734,N735,N736,N737,N738,N739, \note fields as indicated
  N740,N741,N742,N743,N744,N745,N746,N747,N748,N749,N750,N751,N752,N753,N754,N755,N756,N757,N758,N759, \note fields as indicated
  N760,N761,N762,N763,N764,N765,N766,N767,N768,N769,N770,N771,N772,N773,N774,N775,N776,N777,N778,N779, \note fields as indicated
-  N780,N781,N782,N783,N784,N785,N786,N787,N788,N789,N790,N791,N792,N793,N794,N795,N796,N797,N798,N799; \note fields as indicated
+  N780,N781,N782,N783,N784,N785,N786,N787,N788,N789,N790,N791,N792,N793,N794,N795,N796,N797,N798,N799, \note fields as indicated


Why extend this object in the idd if we expect to read the data from a file?

It provides flexibility to allow optical data inputs either from a file or directly from the same idf. It is also easy to add an example without adding extra files.
If you think no needs to input data from an idf file, I can remove it.

The new example file only goes to N565 and the object is extensible, so the only reason to extend this in the IDD would be to edit a longer table object in IDF Editor. My guess is that most users will prefer the external file format, so I would drop the extra fields here and leave it at N799.

OK. I am going to revise idd to make max N = N799,

mjwitte · 2017-05-10T14:11:31Z

src/EnergyPlus/CurveManager.cc

@@ -2547,6 +2554,18 @@ namespace CurveManager {
 				}
 			}

+			IndVarSwitch = false;
+			if ( SameString( Alphas( 4 ), "WAVELENGTH" ) && SameString( Alphas( 5 ), "ANGLE" ) ) {
+				IndVarSwitch = true;


Is it really worth all the trouble to flip the variables? The unit type fields are not required, so you can't be sure these will be input. And, in general, when a component model uses a curve/table object, it expects X1 to be a specific variable (e.g. Outdoor dry bulb temperature). Seems it would be better to enforce X1 is always angle and X2 is always wavelength (or the opposite) and in the function that calls this, check the max/min values for X1 and X2 and throw a warning if they don't line up with the proper variable type.

No problem, I can force variable types to specify X1 as angle and X2 as wavelength.

mjwitte · 2017-05-10T14:12:37Z

src/EnergyPlus/CurveManager.cc

+		Tables( 2 ) = PerfCurve( FRefleCurveIndex ).TableIndex;
+		Tables( 3 ) = PerfCurve( BRefleCurveIndex ).TableIndex;
+
+		// Set up independent variable size to cover all independent varaible values in 3 tables


Typo - varaible

Thanks. I am going to revise them.

Actually, I found many typos in other modules. I will also fix them. See a screen shot below.

mjwitte · 2017-05-10T14:15:01Z

src/EnergyPlus/CurveManager.cc

+			int const ConstrNum,
+			int const NGlass,
+			int & TotalIPhi,
+			Array1A_int Tables


Indent is one too many here and a few lines above.

Done. Thanks.

mjwitte · 2017-05-10T14:43:21Z

src/EnergyPlus/CurveManager.hh

+	GetCurveInterpolationMethodNum( int const CurveIndex ); // index of curve in curve array
+
+	void
+	ReadTableDataFromFile(


There is an existing function named ReadTableData that is used by Table:MultiVariableLookup and this new function is named ReadTableDataFromFile. Since this one is specific to Table:TwoIndependentVariables, it should be renamed. Maybe ReadTwoVarTableData or ReadTwoVarTableDataFromFile .

I will use ReadTwoVarTableDataFromFile.

nrel-bot · 2017-05-28T01:11:20Z

@lgu1234 @lgentile it has been 16 days since this pull request was last updated.

nrel-bot-2 · 2017-06-12T02:44:43Z

@lgu1234 @lgentile it has been 15 days since this pull request was last updated.

mjwitte · 2017-06-12T17:09:32Z

@lgu1234 There are conflicts now on this branch. Also, do you want me to add the transition rule or will you? I will review soon. Also, please add an overview in the pull request describing the changes.

lgu1234 · 2017-06-12T17:38:08Z

@mjwitte I am going to add transition. I will name it as Rules8-7-0-to-8-8-0.md.

Conflicts: src/EnergyPlus/CurveManager.cc src/EnergyPlus/CurveManager.hh tst/EnergyPlus/unit/WindowManager.unit.cc

lgu1234 · 2017-06-12T18:29:46Z

@mjwitte Conflicts have been solved.

mjwitte · 2017-06-14T15:42:20Z

doc/input-output-reference/src/overview/group-performance-tables.tex

@@ -204,6 +206,10 @@ \subsubsection{Inputs}\label{inputs-1-029}
  Distance
 \item
  Power
+\item
+  Wavelength


@mjwitte Yes. Thanks.

mjwitte · 2017-06-14T15:42:34Z

doc/input-output-reference/src/overview/group-performance-tables.tex

+\item
+  Wavelength
+\item
+  Angle


@mjwitte Yes. Remove the Angle item.

mjwitte · 2017-06-14T15:45:25Z

doc/input-output-reference/src/overview/group-surface-construction-elements.tex

+\paragraph{Field: Window Glass Spectral and Incident Angle Transmittance Data Set Table Name}\label{field-window-glass-spectral-and-incident-angle-transmittance-data}
+
+If Optical Data Type = SpectralAndAngle, this is the name of a spectral and angle data set of transmittance defined with a Table:TwoIndependentVariables object.
+


Explain here (or above) that the x variable must be angle and the y variable must be wavelength, and what the format of the table file should be. Or explain that in the Table:TwoIndependetVariables object and refer to that here.

@mjwitte I am going to add explanation.

mjwitte · 2017-06-14T15:53:09Z

src/EnergyPlus/CurveManager.cc

+				ShowContinueError( "In order to input correct variable type for optical properties, " + cAlphaFieldNames( 4 ) + " should be ANGLE, and " + cAlphaFieldNames( 5 ) + " should be WAVELENGTH " );
+				ErrorsFound = true;
+			}
+			if ( SameString( Alphas( 4 ), "ANGLE" ) && !SameString( Alphas( 5 ), "WAVELENGTH" ) ) {


So, what happens if these fields are left blank? Does the window model check this elsewhere? Or does it check the range of values to throw a warning if they don't make sense?

mjwitte

@lgu1234 Comments based on code review only. Haven't tested this yet. @Myoldmopar Would be good for you to review code also.

mjwitte · 2017-06-14T15:55:31Z

src/EnergyPlus/CurveManager.cc

+		// FUNCTION INFORMATION:
+		//       AUTHOR         L. Gu
+		//       DATE WRITTEN   Feb. 2017
+		//       MODIFIED       na


Remove unused comments

mjwitte · 2017-06-14T15:55:52Z

src/EnergyPlus/CurveManager.cc

+		// Return value
+		int TableInterpolationMethodNum;
+
+		// Locals


more unused comments to remove

mjwitte · 2017-06-14T15:58:10Z

src/EnergyPlus/CurveManager.cc

+
+		CheckForActualFileName( FileName, FileExists, TempFullFileName );
+		if ( !FileExists ) {
+			ShowSevereError( "CurveManager: SearchTableDataFile: Could not open Table Data File, expecting it as file name = " + FileName );


CurveManager: SearchTableDatafile --> CurveManager::ReadTwoVarTableDataFromFile

@mjwitte Done. Thanks.

mjwitte · 2017-06-14T16:02:26Z

src/EnergyPlus/CurveManager.cc

+			ShowFatalError( "Program terminates due to these conditions." );
+		}
+
+		TableNum = PerfCurve( CurveNum ).TableIndex;


Should there be a check to make sure this is a Table:TwoIndependentVariables curve type?

mjwitte · 2017-06-14T16:07:27Z

src/EnergyPlus/CurveManager.cc

+
+		// Re-organize performance curve table data structure
+		for ( TableNum = 1; TableNum <= int( Tables.size( ) ); TableNum++ ) {
+			PerfCurveTableData( Tables( TableNum ) ).X1.allocate( int( XX1.size( ) ) );


Is it proper to allocate again (here and below) without first deallocating these? Or is redimension better here? @Myoldmopar

Don't redimension. If the Arrays function like std::vector, which I believe they do, then you can just allocate again and it will work properly.

mjwitte · 2017-06-14T16:51:26Z

src/EnergyPlus/WindowManager.cc

+					if ( !BGFlag ) AllGlassIsSpectralAverage = false;
+					numptDAT = TableLookup( PerfCurve( Material( LayPtr ).GlassSpecAngTransDataPtr ).TableIndex ).NumX2Vars;
+					numpt( IGlass ) = numptDAT;
+					TotalIPhi = TableLookup( PerfCurve( Material( LayPtr ).GlassSpecAngTransDataPtr ).TableIndex ).NumX1Vars;


MaxNumOfIncidentAngles is hardcoded to 20, what if this comes back with TotalIPhi > 20? Has that been checked elsewhere? Or should be checked earlier and MaxNumOfIncidentAngles set to the greatest of these?

It has not been checked. I am going to add a check.

mjwitte · 2017-06-14T17:03:43Z

src/EnergyPlus/WindowManager.cc

+	Array1D< Real64 > CosPhiIndepVar( MaxNumOfIncidentAngles, 0.0 ); // Cos of incidence angles at 10-deg increments for curve fits
+
+	Array1D< int > LayerNum( 5, 0 ); // Glass layer number
+	Array1D< int > AngleNum( 5, 0 ); // Glass layer number for spetral and angular data only


spetral --> spectral

Done. Thanks.

mjwitte · 2017-06-14T17:04:32Z

src/EnergyPlus/WindowManager.cc

+					AngleNum( IGlass ) = LayerNum( IGlass );
+				}
+			}
+			SetCommonIncidentAngles( ConstrNum, NGlass, TotalIPhi, AngleNum );


Having trouble following all of the logic here, but it seems like SetCommonIncidentAngles should be inside an if that checks if this construction even includes a spectralandangle layer.

@mjwitte Actually, this check needs to be performed as long as a single layer is SpectralAndAngle. For example, one layer is Spectral and other layer is SpectralAndAngle. If none of layers is SpectralAndAngle, the function will return without setting common incident angle. This is checked inside the function.

mjwitte · 2017-06-14T17:08:02Z

src/EnergyPlus/WindowManager.cc

 				Phi = double( IPhi - 1 ) * 10.0;
+				for ( IGlass = 1; IGlass <= NGlass; ++IGlass ) {


A comment here would be good to explain that the normal value for Phi above gets overridden if there's a layer that is SpectralAndAngle. And that TotalIPhi is 10 when it's not.

Comments are added.

mjwitte · 2017-06-14T17:11:01Z

src/EnergyPlus/WindowManager.cc

 				}
 			} // End of loop over glass layers in the construction for back calculation

 			// Loop over incidence angle from 0 to 90 deg in 10 deg increments.
 			// Get bare glass layer properties, then glazing system properties at each incidence angle.
 			// The glazing system properties include the effect of inter-reflection among glass layers,
 			// but exclude the effect of a shade or blind if present in the construction.
-			for ( IPhi = 1; IPhi <= 10; ++IPhi ) {
+			for ( IPhi = 1; IPhi <= TotalIPhi; ++IPhi ) {


Again, a comment here explaining the difference for SpectralAndAngle

Comments are added.

mbadams5 · 2017-06-14T19:53:36Z

src/EnergyPlus/CurveManager.cc

+		}
+
+		// ascend sort
+		for ( i = 1; i <= int( XX1.size() ); i++ ) {


You should use std::sort() instead. It will be faster O(n log n) vs O(n^2) and it is less code.

@mbadams5 Do we allow to use std::sort? In addition, how to make descend or ascend? Could you provide an example?

Yes, you can and should use std::sort().
The documentation for sort is here.

This is untested code, but it should be as follows.

std::sort( XX1.begin(), XX1.end() );

By default, it will sort in ascending order. If you want to sort in descending order you can do the following...

std::sort( XX1.begin(), XX1.end(), []( Real64 i, Real64 j ){ return i > j; } );

@mbadams5 Changed.

mbadams5 · 2017-06-14T20:28:06Z

src/EnergyPlus/CurveManager.cc

+			}
+		}
+
+		for ( i = 1; i <= int( XX2.size( ) ); i++ ) {


You should use std::sort() instead.

@mbadams5 Changed. Thanks.

mbadams5 · 2017-06-14T20:30:07Z

src/EnergyPlus/CurveManager.cc

+		if ( !Anglefound ) return;
+
+		// ascend sort
+		for ( i = 1; i <= int( XX1.size( ) ); i++ ) {


You should use std::sort() instead.

mbadams5 · 2017-06-14T20:40:04Z

src/EnergyPlus/CurveManager.cc

+
+		// Re-organize performance curve table data structure
+		for ( TableNum = 1; TableNum <= int( Tables.size( ) ); TableNum++ ) {
+			PerfCurveTableData( Tables( TableNum ) ).X1.allocate( int( XX1.size( ) ) );


Don't redimension. If the Arrays function like std::vector, which I believe they do, then you can just allocate again and it will work properly.

lgu1234 · 2017-06-14T21:04:55Z

@mbadams5 You just said: Don't redimension and just allocate again with new size. Can the array keep old values before new allocate?

mbadams5 · 2017-06-14T21:08:45Z

@lgu1234 I don't really understand what you mean by "Can the array keep old values before new allocate". If you call allocate on the array, it will (or should) allocate a new array and all the old data in the array will be gone.

lgu1234 · 2017-06-15T20:36:46Z

@mbadams5 I am not clear what you request. The following line is allocate for X1 for a new size:

PerfCurveTableData( Tables( TableNum ) ).X1.allocate( int( XX1.size( ) ) );

Could you let me know which way is better?

mbadams5 · 2017-06-16T00:41:17Z

@lgu1234 I was responding to a comment made by @mjwitte. The way it is currently coded is correct and you should leave it.

Conflicts: src/EnergyPlus/DataHeatBalance.hh src/Transition/InputRulesFiles/Rules8-7-0-to-8-8-0.md

mjwitte · 2017-07-01T15:59:15Z

doc/input-output-reference/src/overview/group-surface-construction-elements.tex

@@ -1303,6 +1305,19 @@ \subsubsection{Inputs}\label{inputs-13-015}

 The ratio, when a sample object is stretched, of the contraction or transverse strain (perpendicular to the applied load), to the extension or axial strain (in the direction of the applied load). This value is used only with complex fenestration systems defined through the Construction:ComplexFenestrationState object. The default value for glass is 0.22.

+\paragraph{Field: Window Glass Spectral and Incident Angle Transmittance Data Set Table Name}\label{field-window-glass-spectral-and-incident-angle-transmittance-data}
+
+If Optical Data Type = SpectralAndAngle, this is the name of a spectral and angle data set of transmittance defined with a Table:TwoIndependentVariables object. The first and second independent variables must be Angle, and Wavelenght, respectively. The restriction is based on iternal dataset use. Each dateset is divided into subsets for each inceident angle internally.


Here and below:
Wavelenght --> Wavelength
dateset --> dataset
inceident --> incident

mjwitte · 2017-07-01T16:06:51Z

idd/Energy+.idd.in

       \type real
  N19, \field Output Value #4
-       \required-field


Now that these are not required fields, will the getinput throw an error if these fields are not present when used without an external file?

mjwitte · 2017-07-01T16:17:31Z

src/EnergyPlus/CurveManager.hh

@@ -292,6 +293,7 @@ namespace CurveManager {
 		Array1D< TriQuadraticCurveDataStruct > Tri2ndOrder; // structure for triquadratic curve data
 		bool EMSOverrideOn; // if TRUE, then EMS is calling to override curve value
 		Real64 EMSOverrideCurveValue; // Value of curve result EMS is directing to use
+		bool OpticalProperty; // if TRUE, this table is used to stro optical property


stro --> store

mjwitte · 2017-07-01T17:01:02Z

src/EnergyPlus/CurveManager.cc

+		int const ConstrNum,
+		int const NGlass,
+		int & TotalIPhi,
+		Array1A_int Tables


It's hard to follow what this array represents here. From the calling function, I think it's an array of size NGlass (which is the number of glass layers in construction ConstrNum) which holds the material layer numbers for the glass layers which are SpectralAndAngle. For glass layers which are not SpectralAndAngle, this will be zero. This at least needs a comment to define what this array is. A different variable name might make this function more readable. This is too wordy, but my understanding of this array is SpectralAndAngleGlassLayerMaterialLayerPointers ? Or TableMaterialPointers?

Here are comments in CurveManger.hh
int const ConstrNum, // Construction number
int const NGlass, // The number of glass layers in the construction with index = ConstrNum
int & TotalIPhi, // The number of incident angles
Array1A_int const Tables // Glass layer number for SpectralAndAngleGlassLayer only. Otherwise = 0 for other layers.

Much better, but the value in Tables is the Glass layer material number, correct?

It is glass layer number with optical property of SpectralAndAngle. Material number is Construct( ConstrNum ).LayerPoint( AngleNum( IGlass ) ).

Well, OK, but "Glass layer number" is still confusing, because of the dual layer numbering, one just for glass layers, and the other for all layers in the construction. This one is within all material layers in the construction.

You are right. It should be construction layer number for SpectralAndAngle glass. Hope it is clear enough.

mjwitte · 2017-07-03T18:58:53Z

testfiles/SpectralAngularOpticalProperties_TableData.idf

+! SpectralAngularOpticalProperties_TableData.idf
+! Basic file description:  1 story building divided into 3 interior conditioned zones and 1 unconditioned zone over the
+!                          conditioned zones. Roof with no plenum. No ground contact with floor.
+!                          Outdoor air is modulated based on occupancy and floor area.


Is this based on another example file? That would be useful to mention here.

mjwitte · 2017-07-03T18:59:33Z

testfiles/SpectralAngularOpticalProperties_TableData.idf

+!
+! Highlights:              This file does the basic test of window properties as a function of wavelength and incident angle
+!                          based on Winklemann approach. Table adta are uased to input optical properties. Linear interpolation 
+!                          is porformed to caluclate optical properties with a given incident angle.


Some typos in this paragraph. "adta", "uased", "porformed".

Done. Thanks.

mjwitte · 2017-07-03T22:39:18Z

src/EnergyPlus/CurveManager.cc

+		std::ifstream infile( FileName );
+		std::string line;
+
+		CheckForActualFileName( FileName, FileExists, TempFullFileName );


@lgu1234 I found the problem with reading the file on my machine. When run with ep-launch, CheckForActualFileName looks in several places to find the file and sets TempFullFileName. But here, infile is already set using FileName. So, when I run this, FileExists is true, but later on the std::getline( infile, line ) comes back false (wrong path) and he while loop never executes and lineNum is zero.

mjwitte · 2017-07-03T22:39:23Z

src/EnergyPlus/CurveManager.cc

+			ShowFatalError( "Program terminates due to these conditions." );
+		}
+
+		TableNum = PerfCurve( CurveNum ).TableIndex;


If you move std::ifstream infile( FileName ); here from above and use TempFullFileName it solves the problem on my machine running with EP-Launch.

Thanks for find the problem. Here is my understanding:

Remove the line " std::ifstream infile( FileName );"

Replace "infile" by TempFullFileName in the line below
while (std::getline( infile, line )) {
Please let me know if these actions are OK.

No, you need to insert the std::ifstream... line here using TempFullFileName.

My understanding was wrong. Here are my changes:

TableNum = PerfCurve( CurveNum ).TableIndex; std::ifstream infile( TempFullFileName );

Please confirm.

Yes, that's good.

mjwitte · 2017-07-03T22:43:56Z

src/EnergyPlus/CurveManager.cc

+		TableData( TableNum ).Y.allocate( 0 );
+		lineNum = 0;
+		while (std::getline( infile, line )) {
+			std::vector<std::string> strings = splitString( line, ',' );


@Myoldmopar is this method ok here? All other file reads are using gio functions, such as ReadTableData. This is different here.

This function is from OpenStudio and recommended by Jason.

mjwitte · 2017-07-03T22:45:08Z

src/EnergyPlus/CurveManager.cc

+				TableData( TableNum ).Y.push_back( std::stod( strings[2] ) );
+			}
+		}
+


Would be good to add a fatal error here if lineNum is zero for whatever reason.

mjwitte

External file fix works now. I/O Ref looks good. Question below about Engineering Ref (and typo). Added and tested the transition rule and fixed some typos in the example file. Waiting for CI results to come back. @Myoldmopar Do you want to look at this again before merge?

mjwitte · 2017-07-05T21:44:43Z

doc/engineering-reference/src/daylighting-and-window-calculations/window-calculation-module.tex

@@ -392,6 +392,8 @@ \subsection{Glazing System Properties}\label{glazing-system-properties}

 where \({E_s}(\lambda )\) is the solar spectral irradiance function and \(V(\lambda )\) is the photopic response function of the eye. The default functions are shown in Table~\ref{table:solar-spectral-irradiance-function.} and Table~\ref{table:photopic-response-function.}. They can be overwritten by user defined solar and/or visible spectrum using the objects Site:SolarAndVisibleSpectrum and Site:SpectrumData. They are expressed as a set of values followed by the corresponding wavelengths for values.

+When a choice of Spectral is entered as optical data type, the correlations to store glazing system's angular performance are generated based on angular performance at 10 degree increments. When a choice of SpectralAndAngel is entered as optical data type, no correlations will be generated. The optical properties will be calculated by linear interpolation at a given incident angle.


@lgu1234 Does this need to be revised? Also, SpectralAndAngel-->SpectralAndAngle.

@mjwitte Here is my revision.

When a choice of Spectral is entered as optical data type, the correlations to store glazing system's angular performance are generated based on angular performance at 10 degree increments. When a choice of SpectralAndAngle is entered as optical data type, no correlations will be generated. The optical properties will be calculated by linear interpolation at a given incident angle to generate table data. The common incident angles are applied to all glass layers in the same construction. These table data of optical properties are used to generate polynomial curve fits with 6 coefficients as a function of cos of incident angles. The polynomial curves are used in simulations to calculate optical properties.

Please let me know your opinion.

mjwitte · 2017-07-05T22:13:15Z

Also, @Myoldmopar when I built transition locally, the v8-7-0-Energy+.idd was overwritten with the contents of the current idd instead of making a v8-8-0-Energy+.idd Is there something that needs fixing in the cmake files or is this how it is until we move the main version number forward?

lgu1234 added 3 commits May 2, 2017 13:44

Upload code based on Winkelmann approach

57260fe

Removed unused variables

bd6cc0f

Removed a warning message

ee8f812

mjwitte added IDDChange Code changes impact the IDD file (cannot be merged after IO freeze) NewFeature Includes code to add a new feature to EnergyPlus labels May 10, 2017

mjwitte reviewed May 10, 2017

View reviewed changes

lgu1234 added 3 commits May 10, 2017 16:43

Revised code based on comments

ba2f3c2

Merge branch 'develop' into GlazingEnahncementsWinkelmann

e531ee5

Removed unused variables

5fcff00

lgu1234 added 3 commits June 12, 2017 13:49

Add a transition file

07d5c70

Merge branch 'develop' into GlazingEnahncementsWinkelmann

1377ac9

Conflicts: src/EnergyPlus/CurveManager.cc src/EnergyPlus/CurveManager.hh tst/EnergyPlus/unit/WindowManager.unit.cc

Solved conflict

f9f3bea

mjwitte changed the title ~~Glazing enhancements based on Winkelmann approach~~ Glazing enhancements - input glazing properties as a function of incident angle Jun 14, 2017

NREL deleted a comment from amirroth Jun 14, 2017

mjwitte reviewed Jun 14, 2017

View reviewed changes

mbadams5 reviewed Jun 14, 2017

View reviewed changes

Revise code based on comments

3737267

Merge branch 'develop' into GlazingEnahncementsWinkelmann

addb9d5

Myoldmopar mentioned this pull request Jun 28, 2017

Fix four pipe beam crash when system sizing is off #6137

Merged

18 tasks

Merge branch 'develop' into GlazingEnahncementsWinkelmann

7a3972e

Conflicts: src/EnergyPlus/DataHeatBalance.hh src/Transition/InputRulesFiles/Rules8-7-0-to-8-8-0.md

mjwitte reviewed Jul 1, 2017

View reviewed changes

Revise code based on comments

6980df3

mjwitte reviewed Jul 3, 2017

View reviewed changes

lgu1234 and others added 4 commits July 5, 2017 16:02

More revisions

c9e2449

Transition 8-7-0 to 8-8-0 replace missing section

28c83d1

Add v8.8 transition rule for Table:TwoIndependentVariables

2c3d3eb

Example file SpectralAngularOpticalProperties_TableData.idf typos

2baccbb

mjwitte reviewed Jul 5, 2017

View reviewed changes

mjwitte mentioned this pull request Jul 5, 2017

IDF Editor cleanup for v8.8 release #6199

Closed

4 tasks

Add Mike's revision in Engineering Reference

bb71113

mjwitte merged commit db38b38 into develop Jul 7, 2017

mjwitte deleted the GlazingEnahncementsWinkelmann branch July 7, 2017 21:17

mjwitte mentioned this pull request Jul 8, 2017

Glazing enhancements #6110

Closed

20 tasks

Myoldmopar mentioned this pull request Aug 21, 2017

Hybrid unitary air conditioner #6246

Closed

20 tasks

mjwitte mentioned this pull request Jul 27, 2018

Remove curve-type dependencies #6810

Merged

13 tasks

		\paragraph{Field: Window Glass Spectral and Incident Angle Transmittance Data Set Table Name}\label{field-window-glass-spectral-and-incident-angle-transmittance-data}

		If Optical Data Type = SpectralAndAngle, this is the name of a spectral and angle data set of transmittance defined with a Table:TwoIndependentVariables object.

		Phi = double( IPhi - 1 ) * 10.0;
		for ( IGlass = 1; IGlass <= NGlass; ++IGlass ) {

		@@ -392,6 +392,8 @@ \subsection{Glazing System Properties}\label{glazing-system-properties}

		where \({E_s}(\lambda )\) is the solar spectral irradiance function and \(V(\lambda )\) is the photopic response function of the eye. The default functions are shown in Table~\ref{table:solar-spectral-irradiance-function.} and Table~\ref{table:photopic-response-function.}. They can be overwritten by user defined solar and/or visible spectrum using the objects Site:SolarAndVisibleSpectrum and Site:SpectrumData. They are expressed as a set of values followed by the corresponding wavelengths for values.

		When a choice of Spectral is entered as optical data type, the correlations to store glazing system's angular performance are generated based on angular performance at 10 degree increments. When a choice of SpectralAndAngel is entered as optical data type, no correlations will be generated. The optical properties will be calculated by linear interpolation at a given incident angle.

Glazing enhancements - input glazing properties as a function of incident angle #6114

Glazing enhancements - input glazing properties as a function of incident angle #6114

Conversation

lgu1234 commented May 2, 2017 • edited by mjwitte Loading

Pull request overview

Work Checklist

Review Checklist

mjwitte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nrel-bot commented May 28, 2017

nrel-bot-2 commented Jun 12, 2017

mjwitte commented Jun 12, 2017

lgu1234 commented Jun 12, 2017

lgu1234 commented Jun 12, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mjwitte Jun 14, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mjwitte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lgu1234 commented Jun 14, 2017

mbadams5 commented Jun 14, 2017

lgu1234 commented Jun 15, 2017

mbadams5 commented Jun 16, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lgu1234 commented May 2, 2017 •

edited by mjwitte

Loading

mjwitte Jun 14, 2017 •

edited

Loading