Use local nodes for air flow network calculation #6263

xuanluo113 · 2017-08-22T23:12:03Z

Pull request overview

Use local nodes for air flow network calculation
Tests and docs for local environmental data for urban context

Work Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
At least one of the following appropriate labels must be added to this PR to be consumed into the changelog:
- Defect: This pull request repairs a github defect issue. The github issue should be referenced in the PR description
- Refactoring: This pull request includes code changes that don't change the functionality of the program, just perform refactoring
- NewFeature: This pull request includes code to add a new feature to EnergyPlus
- Performance: This pull request includes code changes that are directed at improving the runtime performance of EnergyPlus
- DoNoPublish: This pull request includes changes that shouldn't be included in the changelog

Review Checklist

This will not be exhaustively relevant to every PR.

Spacing only change to clean up diffs

Remove {Basedon . . . } endline tags

… in the idf [#80741292]

…used in GetInput. EvaporativeCoolers correction fixed issue, ChillerElectricEIR was found during diagnosis. Example file now shows increased water use rate since drift and blowdown are now being used correctly.

This should clear up reports of IdfEditor and EPLaunch failing on Windows 8 and perhaps other systems. [#81032236]

This fixed the NaN issue on my Linux machine, will have to try on Windows and see; Perhaps this will fix #4529; [#71605704]

[#81032236]

…eparate function ProcessZoneData.

Seems it is nearly a bug spread between g++ and gtest. Gtest does some template magic that is OK by C++ standard, but could be modified to work better. In any case, for these true/false cases, just go with the EXPECT_TRUE and EXPECT_FALSE functions instead of EXPECT_EQ( true, ... ) and the warning wont show up; http://code.google.com/p/googletest/issues/detail?id=322 [#82514990]

The data for DaylightMaps was not getting inserted into the SQLite database due to an incorrect variable used in the preparedStatement.

During conversion from Fortran to C++ a bug was introduced causing the row and column labels of tabular reports in sqlite db to be mixed up. The origins having to do with FArray being column major and the offending sqlite output code using the linearized index. [#83704438] Fixes #4602

[#1306026]

[#83857394]

This file is used by EP-Launch to notify about updates. The old url would not render properly in a browser because of how GitHub servers raw.github.com content. This change points to a github pages page, which renders html as expected.

…alNodeNetwork

Myoldmopar · 2017-09-18T21:16:26Z

src/EnergyPlus/AirflowNetworkBalanceManager.cc

+					SimObjectError = true;
+					break;
+				}
+			}


@jasondegraw I mean this seems OK to me. Inside the SurfaceAverageCalculation block, looping over all nodes and throwing if any of them are local nodes. That's the gist of what error you were wanting, right?

@Myoldmopar I guess, but it still doesn't look quite right to me. If it looks OK to you, it's probably OK, though, so I'll approve here in a second.

Thanks @jasondegraw, I think the only issue holding this up now is the unit test failure.

Myoldmopar · 2017-09-20T16:06:10Z

There is still a unit test failure here. @XuanLuoLBL please address. Once this unit test failure is fixed, CI will be all clean.

…odeNetwork # Conflicts: # src/EnergyPlus/HeatBalanceManager.cc

…into LocalNodeNetwork

Myoldmopar · 2017-09-20T17:23:00Z

@XuanLuoLBL you just pulled master into this branch. That's bad. You need to revert that back out. We work off of develop, not master.

Myoldmopar · 2017-09-20T17:26:34Z

But the diffs on the PR files changed tab look fine. What happened here?

xuanluo113 · 2017-09-20T18:36:38Z

@Myoldmopar Weird that the file changes are rendering the reverted commit. And actually commit "dcd5a01" doesn't show any file change at all.

My branch is up to date to develop right now.

Got trapped by this and I'll never ever ever use that windows git console again...

Are things back to normal now?

mjwitte · 2017-09-20T19:06:08Z

@XuanLuoLBL If I'm following this correctly, you haven't reverted the problem merge from master yet. That was 2169d45 But don't do anything more until @Myoldmopar confirms.

Myoldmopar · 2017-09-20T19:13:25Z

Correct; something is still wrong.

xuanluo113 · 2017-09-20T19:13:42Z

@mjwitte @Myoldmopar 2169d45 only added a blank space. And dcd5a01 did nothing at all. And that's why it didn't bother me then.
And now when I wish to pull from origin/develop, it shows up-to-date, which is not...

xuanluo113 · 2017-09-20T19:17:06Z

@Myoldmopar I actually feel if I revert the reverted commit things gonna be fine. Or shall I checkout some specific commit?

Myoldmopar · 2017-09-20T19:18:04Z

I will push up a different branch in a minute and we're closing this PR and opening a new one to merge from.

xuanluo113 · 2017-09-20T19:19:43Z

Okay thanks. Sorry about the mess.

…NodeNetwork

Myoldmopar · 2017-09-20T20:45:23Z

I still can't get it. I'll have to try again tomorrow.

xuanluo113 · 2017-09-20T20:52:26Z

@Myoldmopar Can I just open up another branch and delete this one? I dare not do anything before you confirm now.

The unit test issue is killing me as well. It passes perfectly on my local machine every time from the very beginning and I just don't know what might trigger the difference. Tried lots of time.

Myoldmopar · 2017-09-20T20:56:46Z

I just opened #6335 after what may have been a successful last try. If that works, we'll just move forward with that one. If not, then we'll just figure it out tomorrow.

xuanluo113 · 2017-09-20T21:08:46Z

@Myoldmopar Thanks.

lefticus and others added 30 commits December 3, 2014 11:50

Correct when -<BuildType> is added to package name

d98f66a

Remove int main from BCVTB; should fix strange test failures

cade114

Update RetailPackagedTESCoil.idf with proper discharge SHR curve

b1ac76f

Update RetailPackagedTESCoil.idf

31bb925

Spacing only change to clean up diffs

Update RetailPackagedTESCoil.idf

d9b13e5

Remove {Basedon . . . } endline tags

Update DataStringGlobals so it only searches for the X.Y version form…

21c6603

… in the idf [#80741292]

2 places found where GetObjectItem argument variables were blank yet …

25fe1a5

…used in GetInput. EvaporativeCoolers correction fixed issue, ChillerElectricEIR was found during diagnosis. Example file now shows increased water use rate since drift and blowdown are now being used correctly.

Correct UnitarySystem error message for multi-speed coils

f2a78e7

Forgot to correct UnitarySystem performance object idd.

d53dc7a

Install runtime libraries to support VB Programs

05f8f99

This should clear up reports of IdfEditor and EPLaunch failing on Windows 8 and perhaps other systems. [#81032236]

Adding the float-store flag for basement compilation;

9aa1d35

This fixed the NaN issue on my Linux machine, will have to try on Windows and see; Perhaps this will fix #4529; [#71605704]

Forcing -O1 for basement compilation

dd7f01e

Remove trailing "]" in install MSINET.OCX

5a927e6

[#81032236]

Add missing calculation of ExteriorEquipment power (rate)

e50a103

Delete trailing space in string comparison in GetZoneData

d98ffdc

Refactor to put Zone object data processing from GetZoneData into a s…

8894192

…eparate function ProcessZoneData.

Add unit test for Zone object input data processing

150dd3a

Forgot to add new unit test to CMakeLists.txt

0de38c6

Fix missing data in DaylightMaps table

7cc15a4

The data for DaylightMaps was not getting inserted into the SQLite database due to an incorrect variable used in the preparedStatement.

Help CMake find non-standard git.exe location

744b1dc

Fix array bound for sql lastDayOfMonth

f42ba07

[#1306026]

Fix array bound for sql intervalInMinutes

b2c1235

[#1306026]

Update readme and addressed issues

566b849

[#83857394]

Update epupdate url

8397c2e

This file is used by EP-Launch to notify about updates. The old url would not render properly in a browser because of how GitHub servers raw.github.com content. This change points to a github pages page, which renders html as expected.

Merge tag 'v8.2.0-Update-1.2'

38e6a13

Merge tag 'v8.3.0'

76f71b7

Local Air Node

70158ee

Merge branch 'develop' of https://github.com/NREL/EnergyPlus into Loc…

7487a22

…alNodeNetwork

xuanluo113 added 2 commits September 7, 2017 10:39

Fix grammar

b48ace5

Merge branch 'develop' of https://github.com/NREL/EnergyPlus into Loc…

7f037f5

…alNodeNetwork

Myoldmopar approved these changes Sep 18, 2017

View reviewed changes

Myoldmopar reviewed Sep 18, 2017

View reviewed changes

Merge remote-tracking branch 'origin/develop' into LocalNodeNetwork

3afc959

jasondegraw approved these changes Sep 20, 2017

View reviewed changes

xuanluo113 added 3 commits September 20, 2017 10:12

Fix unit test

ad62d89

Merge remote-tracking branch 'refs/remotes/origin/master' into LocalN…

2169d45

…odeNetwork # Conflicts: # src/EnergyPlus/HeatBalanceManager.cc

Merge branch 'LocalNodeNetwork' of https://github.com/NREL/EnergyPlus …

dcd5a01

…into LocalNodeNetwork

Myoldmopar added the NewFeature Includes code to add a new feature to EnergyPlus label Sep 20, 2017

Myoldmopar force-pushed the LocalNodeNetwork branch from a603862 to ad62d89 Compare September 20, 2017 20:07

Merge remote-tracking branch 'refs/remotes/origin/develop' into Local…

5090d43

…NodeNetwork

xuanluo113 mentioned this pull request Sep 21, 2017

Use local nodes for air flow network calculation #6335

Merged

xuanluo113 closed this Sep 21, 2017

xuanluo113 deleted the LocalNodeNetwork branch September 21, 2017 16:25

xuanluo113 mentioned this pull request Mar 2, 2020

AirflowNetwork:MultiZone:ExternalNode interaction with OutdoorAir:Node is confusing when using surface local environments #7656

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use local nodes for air flow network calculation #6263

Use local nodes for air flow network calculation #6263

xuanluo113 commented Aug 22, 2017

Myoldmopar Sep 18, 2017

jasondegraw Sep 20, 2017

Myoldmopar Sep 20, 2017

Myoldmopar commented Sep 20, 2017

Myoldmopar commented Sep 20, 2017

Myoldmopar commented Sep 20, 2017

xuanluo113 commented Sep 20, 2017

mjwitte commented Sep 20, 2017

Myoldmopar commented Sep 20, 2017

xuanluo113 commented Sep 20, 2017

xuanluo113 commented Sep 20, 2017

Myoldmopar commented Sep 20, 2017

xuanluo113 commented Sep 20, 2017

Myoldmopar commented Sep 20, 2017

xuanluo113 commented Sep 20, 2017

Myoldmopar commented Sep 20, 2017

xuanluo113 commented Sep 20, 2017

Use local nodes for air flow network calculation #6263

Use local nodes for air flow network calculation #6263

Conversation

xuanluo113 commented Aug 22, 2017

Pull request overview

Work Checklist

Review Checklist

Myoldmopar Sep 18, 2017

Choose a reason for hiding this comment

jasondegraw Sep 20, 2017

Choose a reason for hiding this comment

Myoldmopar Sep 20, 2017

Choose a reason for hiding this comment

Myoldmopar commented Sep 20, 2017

Myoldmopar commented Sep 20, 2017

Myoldmopar commented Sep 20, 2017

xuanluo113 commented Sep 20, 2017

mjwitte commented Sep 20, 2017

Myoldmopar commented Sep 20, 2017

xuanluo113 commented Sep 20, 2017

xuanluo113 commented Sep 20, 2017

Myoldmopar commented Sep 20, 2017

xuanluo113 commented Sep 20, 2017

Myoldmopar commented Sep 20, 2017

xuanluo113 commented Sep 20, 2017

Myoldmopar commented Sep 20, 2017

xuanluo113 commented Sep 20, 2017