Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local nodes for air flow network calculation #6335

Merged
merged 6 commits into from Sep 22, 2017

Conversation

Myoldmopar
Copy link
Member

@Myoldmopar Myoldmopar commented Sep 20, 2017

Pull request overview

  1. Use local nodes for air flow network calculation
  2. Tests and docs for local environmental data for urban context

@mjwitte mjwitte added this to the EnergyPlus 8.8.0 milestone Sep 20, 2017
@xuanluo113 xuanluo113 added the NewFeature Includes code to add a new feature to EnergyPlus label Sep 21, 2017
@Myoldmopar
Copy link
Member Author

It looks like 8746f3b did the trick. Assuming it stays green as CI gets around to it, this will go in.

@Myoldmopar
Copy link
Member Author

Myoldmopar commented Sep 21, 2017

@XuanLuoLBL can you update this PR?

  • Copy the description and title from the old PR into this one
  • Update all PR labels/milestones to be like the old one
  • Reference the old one in this description to point back to the old one so that we can get back to the original conversation if needed.
  • Close the other PR without merging.

@xuanluo113
Copy link
Contributor

@Myoldmopar Guess 8746f3b works!

@xuanluo113 xuanluo113 changed the title Local node network try 5 Use local nodes for air flow network calculation Sep 21, 2017
@xuanluo113
Copy link
Contributor

#6227
The original feature PR - Improving Building Energy Simulation in an Urban Context
#6263
The orignal feature update PR - Use local nodes for air flow network calculation

@xuanluo113
Copy link
Contributor

@Myoldmopar Done.

@Myoldmopar
Copy link
Member Author

This is good to go in. Merging.

@Myoldmopar Myoldmopar merged commit fc8cc8d into develop Sep 22, 2017
@Myoldmopar Myoldmopar deleted the LocalNodeNetworkTry5 branch September 22, 2017 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Includes code to add a new feature to EnergyPlus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants