-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
179d reporting based on v8.8.0 #6461
Conversation
Currently this just downloads and extracts OpenStudio in preparation for executing the report.
* Report files go to: doc-build/179d_compliance * This currently relies on the public mirror of the OS_Bestest repository until the official one is made public * The doc-build result folder has the files staged for automatic upload to AWS * The reports use the current build of EnergyPlus against the last official version of OpenStudio * There will need to be a lock-step updating of OS with E+ for testing
* Currently enabled for all builds, not release only
* This has the 179D testing ready for PR
The PR has now been updated to include posting of results to the CI dashboard. This PR is enabled for building the reporting only on release builds. A separate branch was made that created the reports for all builds. The result of that can been seen here: http://nrel.github.io/EnergyPlusBuildResults/EnergyPlus-c0f6d73f5f9a2cdb630e343e44ba5ab3531d70ef-x86_64-Linux-Ubuntu-14.04-gcc-4.8-179D_Reporting.html#build with the posted reports available: http://energyplus.s3-website-us-east-1.amazonaws.com/assets/2018-02-08-EnergyPlus-c0f6d73f5f-x86_64-gcc-4.8179-DR/ |
1 similar comment
@lefticus I was going to push on this to get it in, but it's going to add CI effort and we can't really afford that at the moment. I think we should still use this branch to build the CI results, but not merge it into develop at the moment. This doesn't affect any C++ code so it doesn't matter to bring it up to date for the style update. |
5 similar comments
I'm going to go ahead and merge this and later today I'll trigger a tag build. If something goes awry, I'll leave the core changes in place but remove the -D179D_COMPLIANCE to OFF and figure out what we need to do to actually get it going. |
Actually, let me get develop in here first to make sure CI is OK. |
Ahh there we go, finally some good clean results. I'll let CI run overnight though. |
Actually, let me go ahead and tag a release of this branch and let that populate overnight. 👍 |
Merging this in as-is right now to get the code in there with the package build disabled for now. |
Pull request overview
This PR adds a new option "179D_COMPLIANCE" to the EnergyPlus build which tests the current build of EnergyPlus with the last release of OpenStudio to generate 179D Compliance reports and stages them for upload to the CI.
Work Checklist
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Review Checklist
This will not be exhaustively relevant to every PR.