Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

179d reporting based on v8.8.0 #6461

Merged
merged 19 commits into from
Jul 13, 2018
Merged

179d reporting based on v8.8.0 #6461

merged 19 commits into from
Jul 13, 2018

Conversation

lefticus
Copy link
Contributor

@lefticus lefticus commented Feb 2, 2018

Pull request overview

This PR adds a new option "179D_COMPLIANCE" to the EnergyPlus build which tests the current build of EnergyPlus with the last release of OpenStudio to generate 179D Compliance reports and stages them for upload to the CI.

Work Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • At least one of the following appropriate labels must be added to this PR to be consumed into the

Review Checklist

This will not be exhaustively relevant to every PR.

  • Code style (parentheses padding, variable names)
  • Functional code review (it has to work!)
  • If defect, results of running current develop vs this branch should exhibit the fix
  • CI status: all green or justified
  • Performance: CI Linux results include performance check -- verify this
  • Unit Test(s)
  • C++ checks:
    • Argument types
    • If any virtual classes, ensure virtual destructor included, other things
  • IDD changes:
    • Verify naming conventions and styles, memos and notes and defaults
    • Open windows IDF Editor with modified IDD to check for errors
    • If transition, add rules to spreadsheet
    • If transition, add transition source
    • If transition, update idfs
  • If new idf included, locally check the err file and other outputs
  • Documentation changes in place
  • Changed docs build successfully
  • ExpandObjects changes?
  • If output changes, including tabular output structure, add to output rules file for interfaces

Currently this just downloads and extracts OpenStudio in preparation
for executing the report.
 * Report files go to: doc-build/179d_compliance
 * This currently relies on the public mirror of the OS_Bestest repository
   until the official one is made public
 * The doc-build result folder has the files staged for automatic
   upload to AWS
 * The reports use the current build of EnergyPlus against the last
   official version of OpenStudio
 * There will need to be a lock-step updating of OS with E+ for testing
 * Currently enabled for all builds, not release only
 * This has the 179D testing ready for PR
@lefticus lefticus added the NewFeature Includes code to add a new feature to EnergyPlus label Feb 2, 2018
@lefticus
Copy link
Contributor Author

lefticus commented Feb 9, 2018

The PR has now been updated to include posting of results to the CI dashboard.

This PR is enabled for building the reporting only on release builds. A separate branch was made that created the reports for all builds. The result of that can been seen here: http://nrel.github.io/EnergyPlusBuildResults/EnergyPlus-c0f6d73f5f9a2cdb630e343e44ba5ab3531d70ef-x86_64-Linux-Ubuntu-14.04-gcc-4.8-179D_Reporting.html#build with the posted reports available: http://energyplus.s3-website-us-east-1.amazonaws.com/assets/2018-02-08-EnergyPlus-c0f6d73f5f-x86_64-gcc-4.8179-DR/

@Myoldmopar Myoldmopar added the NotIDDChange Code does not impact IDD (can be merged after IO freeze) label Feb 14, 2018
@Myoldmopar Myoldmopar added this to the EnergyPlus 8.9.0 milestone Feb 14, 2018
@nrel-bot
Copy link

@lefticus @lgentile it has been 14 days since this pull request was last updated.

1 similar comment
@nrel-bot
Copy link

@lefticus @lgentile it has been 14 days since this pull request was last updated.

@Myoldmopar
Copy link
Member

@lefticus I was going to push on this to get it in, but it's going to add CI effort and we can't really afford that at the moment. I think we should still use this branch to build the CI results, but not merge it into develop at the moment. This doesn't affect any C++ code so it doesn't matter to bring it up to date for the style update.

@Myoldmopar Myoldmopar modified the milestones: EnergyPlus 8.9.0, EnergyPlus Next Mar 16, 2018
@nrel-bot
Copy link

@lefticus @lgentile it has been 14 days since this pull request was last updated.

5 similar comments
@nrel-bot
Copy link

@lefticus @lgentile it has been 14 days since this pull request was last updated.

@nrel-bot
Copy link

@lefticus @lgentile it has been 14 days since this pull request was last updated.

@nrel-bot-3
Copy link

@lefticus @lgentile it has been 14 days since this pull request was last updated.

@nrel-bot-2
Copy link

@lefticus @lgentile it has been 14 days since this pull request was last updated.

@nrel-bot-2
Copy link

@lefticus @lgentile it has been 14 days since this pull request was last updated.

@Myoldmopar
Copy link
Member

I'm going to go ahead and merge this and later today I'll trigger a tag build. If something goes awry, I'll leave the core changes in place but remove the -D179D_COMPLIANCE to OFF and figure out what we need to do to actually get it going.

@Myoldmopar
Copy link
Member

Actually, let me get develop in here first to make sure CI is OK.

@Myoldmopar Myoldmopar self-assigned this Jul 5, 2018
@Myoldmopar
Copy link
Member

Ahh there we go, finally some good clean results. I'll let CI run overnight though.

@Myoldmopar
Copy link
Member

Actually, let me go ahead and tag a release of this branch and let that populate overnight. 👍

@Myoldmopar
Copy link
Member

Merging this in as-is right now to get the code in there with the package build disabled for now.

@Myoldmopar Myoldmopar merged commit 378755c into develop Jul 13, 2018
@Myoldmopar Myoldmopar deleted the 179D_Reporting-v8.8.0 branch July 13, 2018 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Includes code to add a new feature to EnergyPlus NotIDDChange Code does not impact IDD (can be merged after IO freeze)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants