-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include impact of AirTerminal:SingleDuct:Mixer in ZoneHVAC coil sizing #6788
Changes from 5 commits
4192eb6
ac5ebb8
768e2ec
7cd40cf
319592c
7183182
ecc43a9
e124fef
6df2e42
2752ebf
c332518
fc91e74
66b8644
13b29b1
bf4326d
688128a
ee5caf5
ad70076
9384c1d
de30829
9bf0efa
dddb185
b338312
afbab6f
be61d9e
26b6d5b
41e2928
4677015
00cf8dd
4b61de3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -639,24 +639,29 @@ namespace DataSizing { | |
struct ZoneEqSizingData // data saved from zone eq component sizing and passed to subcomponents | ||
{ | ||
// Members | ||
Real64 AirVolFlow; // design air vol flow rate for zone equipment unit [m3/s] | ||
Real64 MaxHWVolFlow; // design Hot Water vol flow for zone equipment unit [m3/s] | ||
Real64 MaxCWVolFlow; // design Cold Water vol flow for zone equipment unit [m3/s] | ||
Real64 OAVolFlow; // design outside air flow for zone equipment unit [m3/s] | ||
Real64 DesCoolingLoad; // design cooling load used for zone equipment [W] | ||
Real64 DesHeatingLoad; // design heating load used for zone equipment [W] | ||
Real64 CoolingAirVolFlow; // design cooling air vol flow rate for equipment[m3/s] | ||
Real64 HeatingAirVolFlow; // design heating air vol flow rate for equipment[m3/s] | ||
Real64 SystemAirVolFlow; // design heating air vol flow rate for equipment[m3/s] | ||
bool AirFlow; // TRUE if AirloopHVAC system air flow rate is calcualted | ||
bool CoolingAirFlow; // TRUE if AirloopHVAC system cooling air flow rate is calcualted | ||
bool HeatingAirFlow; // TRUE if AirloopHVAC system heating air flow rate is calcualted | ||
bool SystemAirFlow; // TRUE if AirloopHVAC system heating air flow rate is calcualted | ||
bool Capacity; // TRUE if AirloopHVAC system capacity is calculated | ||
bool CoolingCapacity; // TRUE if AirloopHVAC system cooling capacity is calculated | ||
bool HeatingCapacity; // TRUE if AirloopHVAC system heating capacity is calculated | ||
bool SystemCapacity; // TRUE if AirloopHVAC system heating capacity is calculated | ||
bool DesignSizeFromParent; // TRUE if design size is set by parent object - normally false, set to true for special cases e.g. ERV | ||
Real64 AirVolFlow; // design air vol flow rate for zone equipment unit [m3/s] | ||
Real64 MaxHWVolFlow; // design Hot Water vol flow for zone equipment unit [m3/s] | ||
Real64 MaxCWVolFlow; // design Cold Water vol flow for zone equipment unit [m3/s] | ||
Real64 OAVolFlow; // design outside air flow for zone equipment unit [m3/s] | ||
Real64 ATMixerVolFlow; // design ventilation air flow rate from air terminal mixer (central DOAS) [m3/s] //TRANE AT Mixer sizing | ||
Real64 ATMixerCoolPriDryBulb; // design ventilation drybulb temperature from air terminal mixer during cooling (central DOAS) [C] | ||
Real64 ATMixerCoolPriHumRat; // design ventilation humidity ratio from air terminal mixer during cooling (central DOAS) [kgH20/kgDryAir] | ||
Real64 ATMixerHeatPriDryBulb; // design ventilation drybulb temperature from air terminal mixer during heating (central DOAS) [C] | ||
Real64 ATMixerHeatPriHumRat; // design ventilation humidity ratio from air terminal mixer during heating (central DOAS) [kgH20/kgDryAir] | ||
Real64 DesCoolingLoad; // design cooling load used for zone equipment [W] | ||
Real64 DesHeatingLoad; // design heating load used for zone equipment [W] | ||
Real64 CoolingAirVolFlow; // design cooling air vol flow rate for equipment[m3/s] | ||
Real64 HeatingAirVolFlow; // design heating air vol flow rate for equipment[m3/s] | ||
Real64 SystemAirVolFlow; // design heating air vol flow rate for equipment[m3/s] | ||
bool AirFlow; // TRUE if AirloopHVAC system air flow rate is calcualted | ||
bool CoolingAirFlow; // TRUE if AirloopHVAC system cooling air flow rate is calcualted | ||
bool HeatingAirFlow; // TRUE if AirloopHVAC system heating air flow rate is calcualted | ||
bool SystemAirFlow; // TRUE if AirloopHVAC system heating air flow rate is calcualted | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. While you're in here, can fix "calcualted". |
||
bool Capacity; // TRUE if AirloopHVAC system capacity is calculated | ||
bool CoolingCapacity; // TRUE if AirloopHVAC system cooling capacity is calculated | ||
bool HeatingCapacity; // TRUE if AirloopHVAC system heating capacity is calculated | ||
bool SystemCapacity; // TRUE if AirloopHVAC system heating capacity is calculated | ||
bool DesignSizeFromParent; // TRUE if design size is set by parent object - normally false, set to true for special cases e.g. ERV | ||
Array1D_int SizingMethod; // supply air flow rate sizing method (SupplyAirFlowRate, FlowPerFloorArea, FractionOfAutosizedCoolingAirflow and | ||
// FractionOfAutosizedHeatingAirflow) | ||
Array1D_int CapSizingMethod; // capacity sizing methods (HeatingDesignCapacity, CoolingDesignCapacity, CapacityPerFloorArea, | ||
|
@@ -665,6 +670,11 @@ namespace DataSizing { | |
// Default Constructor | ||
ZoneEqSizingData() | ||
: AirVolFlow(0.0), MaxHWVolFlow(0.0), MaxCWVolFlow(0.0), OAVolFlow(0.0), | ||
ATMixerVolFlow(0.0), // design ventilation air flow rate from air terminal mixer (central DOAS) [m3/s] | ||
ATMixerCoolPriDryBulb(0.0), // design air terminal mixer cooling outlet temperture [C] | ||
ATMixerCoolPriHumRat(0.0), // design air terminal mixer cooling outlet humidity ratio [kgH20/kgDryAir] | ||
ATMixerHeatPriDryBulb(0.0), // design air terminal mixer heating outlet temperture [C] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And "temperture". |
||
ATMixerHeatPriHumRat(0.0), // design air terminal mixer cheating outlet humidity ratio [kgH20/kgDryAir] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "cheating" --> "heating"? |
||
DesCoolingLoad(0.0), // design cooling load used for zone equipment [W] | ||
DesHeatingLoad(0.0), // design heating load used for zone equipment [W] | ||
CoolingAirVolFlow(0.0), // design cooling air vol flow rate for equipment[m3/s] | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -276,7 +276,7 @@ namespace FanCoilUnits { | |
ZoneEqFanCoil = true; | ||
|
||
// Initialize the fan coil unit | ||
InitFanCoilUnits(FanCoilNum, ZoneNum); | ||
InitFanCoilUnits(FanCoilNum, ZoneNum, ControlledZoneNum); | ||
|
||
// Select the correct unit type | ||
{ | ||
|
@@ -1050,8 +1050,9 @@ namespace FanCoilUnits { | |
} | ||
} | ||
|
||
void InitFanCoilUnits(int const FanCoilNum, // number of the current fan coil unit being simulated | ||
int const ZoneNum // number of zone being served | ||
void InitFanCoilUnits(int const FanCoilNum, // number of the current fan coil unit being simulated | ||
int const ZoneNum, // number of zone being served | ||
int const ControlledZoneNum // index into ZoneEquipConfig array may not be equal to ZoneNum | ||
) | ||
{ | ||
|
||
|
@@ -1196,7 +1197,7 @@ namespace FanCoilUnits { | |
|
||
if (!SysSizingCalc && MySizeFlag(FanCoilNum) && !MyPlantScanFlag(FanCoilNum)) { | ||
|
||
SizeFanCoilUnit(FanCoilNum); | ||
SizeFanCoilUnit(FanCoilNum, ControlledZoneNum); | ||
|
||
MySizeFlag(FanCoilNum) = false; | ||
} | ||
|
@@ -1312,7 +1313,9 @@ namespace FanCoilUnits { | |
} | ||
} | ||
|
||
void SizeFanCoilUnit(int const FanCoilNum) | ||
void SizeFanCoilUnit(int const FanCoilNum, | ||
int const ControlledZoneNum // index into ZoneEquipConfig array may not be equal to ZoneNum | ||
) | ||
{ | ||
|
||
// SUBROUTINE INFORMATION: | ||
|
@@ -1671,6 +1674,10 @@ namespace FanCoilUnits { | |
} | ||
} | ||
} | ||
ZoneEqSizing(CurZoneEqNum).OAVolFlow = FanCoil(FanCoilNum).OutAirVolFlow; | ||
if (FanCoil(FanCoilNum).ATMixerExists) { | ||
SingleDuct::setATMixerSizingProperties(FanCoil(FanCoilNum).ATMixerIndex, ControlledZoneNum, CurZoneEqNum); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This function will be used in each zone equipment type to set up ATMixer inlet conditions. |
||
} | ||
} | ||
|
||
|
@@ -2048,7 +2055,6 @@ namespace FanCoilUnits { | |
if (CurZoneEqNum > 0) { | ||
ZoneEqSizing(CurZoneEqNum).MaxHWVolFlow = FanCoil(FanCoilNum).MaxHotWaterVolFlow; | ||
ZoneEqSizing(CurZoneEqNum).MaxCWVolFlow = FanCoil(FanCoilNum).MaxColdWaterVolFlow; | ||
ZoneEqSizing(CurZoneEqNum).OAVolFlow = FanCoil(FanCoilNum).OutAirVolFlow; | ||
ZoneEqSizing(CurZoneEqNum).AirVolFlow = FanCoil(FanCoilNum).MaxAirVolFlow; | ||
ZoneEqSizing(CurZoneEqNum).DesCoolingLoad = FanCoil(FanCoilNum).DesCoolingLoad; | ||
ZoneEqSizing(CurZoneEqNum).DesHeatingLoad = FanCoil(FanCoilNum).DesHeatingLoad; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't really need comments tagging TRANE in here. If there's anything else to change in this PR, comments like this should go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed that one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still needs cleanup.