Include impact of AirTerminal:SingleDuct:Mixer in ZoneHVAC coil sizing #6788

rraustad · 2018-06-19T20:22:54Z

Pull request overview

Zone equipment does not include impacts of DOAS system (i.e., when zone equipment uses AirTerminal:SingleDuct:Mixer) on coil inlet conditions during sizing. This corrects Issue #6712. Cooling coil sizing now includes the impact of the DOAS air stream, either conditioned or unconditioned, on the mixed inlet condition of the zone equipment's cooling coil. This change will typically allow smaller cooling coil sizes.

Zone models included in this update:

ZoneHVAC:FourPipeFanCoil
ZoneHVAC:WaterToAirHeatPump
ZoneHVAC:PackagedTerminalAirConditioner
ZoneHVAC:PackagedTerminalHeatPump
ZoneHVAC:TerminalUnit:VariableRefrigerantFlow
ZoneHVAC:UnitVentilator
AirLoopHVAC:UnitarySystem

Work Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
At least one of the following appropriate labels must be added to this PR to be consumed into the changelog:
- Defect: This pull request repairs a github defect issue. The github issue should be referenced in the PR description
- Refactoring: This pull request includes code changes that don't change the functionality of the program, just perform refactoring
- NewFeature: This pull request includes code to add a new feature to EnergyPlus
- Performance: This pull request includes code changes that are directed at improving the runtime performance of EnergyPlus
- DoNoPublish: This pull request includes changes that shouldn't be included in the changelog

Review Checklist

This will not be exhaustively relevant to every PR.

rraustad · 2018-06-19T20:28:28Z

src/EnergyPlus/ReportSizingManager.cc

@@ -3577,6 +3609,102 @@ namespace ReportSizingManager {
        }
    }

+    void setHeatingOAFracAndInletTempForZoneEq(Real64 &OutAirFrac, Real64 &CoilInTemp, Real64 &DesMassFlow)


Anyone want to comment on these new functions? Too busy? Break out OutAirFrac, CoilInTemp and CoilInHumRat to individual functions? If change to individual functions change to Real64 instead of void ? etc.

rraustad · 2018-06-19T23:45:21Z

Interesting. Won't build on the CI but builds at work and home on 64 bit Windows 7 and 8.

rraustad · 2018-06-20T01:58:05Z

tst/EnergyPlus/unit/WaterCoils.unit.cc

+    EXPECT_NEAR(WaterCoil(CoilNum).InletAirTemp, -1.99999, 0.0001); // a mixture of zone air (20 C) and 10% OA (-20 C) = 16 C
+    EXPECT_NEAR(WaterCoil(CoilNum).DesTotWaterCoilLoad, 3908.2603, 0.0001);
+    EXPECT_NEAR(WaterCoil(CoilNum).UACoil, 94.9905, 0.0001);
+    EXPECT_NEAR(WaterCoil(CoilNum).OutletAirTemp, 30.2984, 0.0001); // reasonable delta T above inlet air temp


Made this change just to get it to pass. Have already corrected these so that the results are identical to before.

rraustad · 2018-06-20T19:34:55Z

src/EnergyPlus/FanCoilUnits.cc

+                ZoneEqSizing(CurZoneEqNum).OAVolFlow = FanCoil(FanCoilNum).OutAirVolFlow;
+                if (FanCoil(FanCoilNum).ATMixerExists) {
+                    SingleDuct::setATMixerSizingProperties(FanCoil(FanCoilNum).ATMixerIndex, ControlledZoneNum, CurZoneEqNum);
+                }


This function will be used in each zone equipment type to set up ATMixer inlet conditions.

rraustad · 2018-06-20T19:36:06Z

src/EnergyPlus/ReportSizingManager.cc

+                        //                        CoilInTemp = (1.0 - OutAirFrac) * FinalZoneSizing(CurZoneEqNum).ZoneTempAtHeatPeak +
+                        //                                      OutAirFrac * FinalZoneSizing(CurZoneEqNum).OutTempAtHeatPeak;
+                        // this will change above CoilInTemp equation to use ZoneRetTempAtHeatPeak which accounts for lights to return fraction
+                        CoilInTemp = setHeatCoilInletTempForZoneEqSizing(setOAFracForZoneEqSizing(DesMassFlow));


The coil inlet condition is now a function call which replaces many duplicate code blocks.

rraustad · 2018-06-20T19:37:00Z

src/EnergyPlus/SingleDuct.cc

+            ZoneEqSizing(curZoneEqNum).ATMixerHeatPriHumRat = SysSizInput(sysSizIndex).HeatSupHumRat;
+        }
+    }
+


And here is the ATMixer function that sets up inlet conditions the same for all equipment.

rraustad · 2018-06-20T19:40:35Z

src/EnergyPlus/ReportSizingManager.cc

+            coilInTemp = (1.0 - outAirFrac) * DataSizing::FinalZoneSizing(DataSizing::CurZoneEqNum).ZoneRetTempAtCoolPeak +
+                         outAirFrac * DataSizing::ZoneEqSizing(DataSizing::CurZoneEqNum).ATMixerCoolPriDryBulb;
+        } else if (DataSizing::ZoneEqSizing(DataSizing::CurZoneEqNum).OAVolFlow > 0.0) { // adjust for raw OA mixed inlet temp
+            coilInTemp = (1.0 - outAirFrac) * DataSizing::FinalZoneSizing(DataSizing::CurZoneEqNum).ZoneTempAtCoolPeak +


This should probably use ZoneRetTempAtCoolPeak as setHeatCoilInletTempForZoneEqSizing does.

rraustad · 2018-06-20T19:45:30Z

@mjwitte @Myoldmopar @EnergyArchmage this is the method used to update fan coil units to include ATMixer impact on coil sizing. This method will be ported to all other zone equipment types so if there is a comment on chosen method now is the time to comment.

rraustad · 2018-06-20T20:38:10Z

Here's some results for the DOAToFanCoilInlet example file. Sizing apparently thinks the OA is zero for the fan coil. Sizing also doesn't know there is an ATMixer attached.

Sizing:Zone,
  SPACE1-1,                !- Zone or ZoneList Name
  SZ DSOA SPACE1-1,        !- Design Specification Outdoor Air Object Name

DesignSpecification:OutdoorAir,
  SZ DSOA SPACE1-1,        !- Name
  flow/person,             !- Outdoor Air Method
  0.00944,                 !- Outdoor Air Flow per Person {m3/s-person}
  0.0,                     !- Outdoor Air Flow per Zone Floor Area {m3/s-m2}
  0.0;                     !- Outdoor Air Flow per Zone {m3/s}

ZoneHVAC:FourPipeFanCoil,
  SPACE1-1 Fan Coil,       !- Name
  FanAvailSched,           !- Availability Schedule Name
  ConstantFanVariableFlow, !- Capacity Control Method
  autosize,                !- Maximum Supply Air Flow Rate {m3/s}
  ,                        !- Low Speed Supply Air Flow Ratio
  ,                        !- Medium Speed Supply Air Flow Ratio
  0,                       !- Maximum Outdoor Air Flow Rate {m3/s}
  ,                        !- Outdoor Air Schedule Name
  SPACE1-1 Fan Coil Inlet, !- Air Inlet Node Name
  SPACE1-1 Supply Inlet,   !- Air Outlet Node Name
  ,                        !- Outdoor Air Mixer Object Type
  ,                        !- Outdoor Air Mixer Name

AirTerminal:SingleDuct:Mixer,
  SPACE1-1 DOAS Air Terminal,  !- Name
  ZoneHVAC:FourPipeFanCoil,!- ZoneHVAC Unit Object Type
  SPACE1-1 Fan Coil,       !- ZoneHVAC Unit Object Name
  SPACE1-1 Fan Coil Inlet, !- Mixer Outlet Node Name
  SPACE1-1 Air Terminal Mixer Primary Inlet,  !- Mixer Primary Air Inlet Node Name
  SPACE1-1 Air Terminal Mixer Secondary Inlet,  !- Mixer Secondary Air Inlet Node Name
  InletSide;               !- Mixer Connection Type

So when the ATMixer impact on mixed air conditions is considered, the inlet conditions to the coil are actually lower than is shown in the current develop branch. So coil sizing is now impacted for inlet ATMixers. Basically lower cooling and higher heating coil sizes.

rraustad · 2018-06-21T00:33:31Z

There are diff's showing in UnitVentilator when I only added the new ATMixer function call to fan coils. This is because I changed the return temp from ZoneTempAtHeatPeak to ZoneRetTempAtHeatPeak to account for lighting heat to return. Not sure if that makes sense now but will think more about it. Reverting this for now to get to minimal, and explainable, diff's before moving on.

rraustad · 2018-06-21T00:43:23Z

src/EnergyPlus/SingleDuct.cc

@@ -6015,6 +6015,26 @@ namespace SingleDuct {
        }
    }

+    void setATMixerSizingProperties(int const &inletATMixerIndex, int const &controlledZoneNum, int const &curZoneEqNum)
+    {
+        ZoneEqSizing(curZoneEqNum).ATMixerVolFlow = SingleDuct::SysATMixer(inletATMixerIndex).DesignPrimaryAirVolRate;


Maybe I should move this air vol flow down into if (SizingDesRunThisAirSys) so that all are set or none are set?

rraustad · 2018-06-21T01:47:37Z

Perfect, now only the 7 fan coil example files have diff's. I'll worry about that subtle change to the coil inlet temp calc later. I can now move on and make the simple change to all other zone equipment. Should be easy sailing now. This code snippet should be all that is needed in other zone equipment sizing routines (before any child equipment are called).

if (FanCoil(FanCoilNum).ATMixerExists) {
    SingleDuct::setATMixerSizingProperties(FanCoil(FanCoilNum).ATMixerIndex, ControlledZoneNum, CurZoneEqNum);
}

rraustad · 2018-06-21T03:02:58Z

Just figuring out which zone temp to use for zone equipment. The only difference I see is:

if (ReturnNode > 0) {
    RetTemp = Node(ReturnNode).Temp;
} else {
    RetTemp = Node(ZoneNode).Temp;
}

CalcZoneSizing(CurOverallSimDay, ControlledZoneNum).HeatZoneRetTemp = RetTemp;
CalcZoneSizing(CurOverallSimDay, ControlledZoneNum).CoolZoneRetTemp = RetTemp;

So why would zone equipment ever use return temp to size the coils? Zone equipment draws air from the zone and any heat gain to return should be met by the air loop. And when there is no air loop these are the same value. I am now thinking this was just a mistake during equipment model development and it propagated through to some/all zone equipment models. There is going to be diffs during sizing consolidation, probably for zone equipment that serve the same zone as an air loop, but I wonder if I want to tackle that here or in a different issue. Leaning towards saving this for the existing sizing consolidation issue #6172.

…irTerminalSingleDuctMixer' of https://github.com/NREL/EnergyPlus into #6712-Zone-Coil-Autosizing-does-not-include-impact-of-AirTerminalSingleDuctMixer

rraustad · 2018-06-21T18:12:25Z

@Myoldmopar @mjwitte this should now be complete. I will review CI diffs and try to post more comparisons.

rraustad · 2018-06-22T01:55:15Z

Seeing non-DOAS diffs with fan coils I am switching back to ZoneRetTemp on the else to see if that fixes non-DOAS files. Also flipped priority on CoolingCapacitySizing to honor ATMixer over anything else.

…turn temp to check diffs.

mjwitte · 2018-09-13T12:03:59Z

Regarding the new warnings, 7 files now have warnings. Good to exercise the warnings here, but now we need to correct those test files so the warnings go away.

In DOAToUnitarySystem, the warnings are happening twice per zone.

In OutdoorAirUnit and OutdoorAirUnitwithAirloopHVAC (and maybe others), the desiccant regen coil capacity has changed - it shouldn't.

Minor - the warnings seem a bit verbose.

   ** Warning ** AirTerminal:SingleDuct:Mixer: SPACE1-1 DOAS AIR TERMINAL
   **   ~~~   **  Sizing:Zone object sets input Account for Dedicated Outdoor Air System = Yes.
   **   ~~~   **  This inlet side Air Terminal Mixer will also adjust coil sizing and may result in inappropriately sized coils.
   **   ~~~   **  Set Account for Dedicated Outdoor Air System = No in Sizing:Zone object for zone = SPACE1-1

   ** Warning ** AirTerminal:SingleDuct:Mixer: SPACE4-1 DOAS AIR TERMINAL
   **   ~~~   **  Sizing:Zone object sets input Account for Dedicated Outdoor Air System = No.
   **   ~~~   **  This supply side Air Terminal Mixer will not adjust coil sizing and may result in inappropriately sized coils.
   **   ~~~   **  Set Account for Dedicated Outdoor Air System = Yes in Sizing:Zone object for zone = SPACE4-1

Suggest

   ** Warning ** AirTerminal:SingleDuct:Mixer: SPACE1-1 DOAS AIR TERMINAL
   **   ~~~   **  Inlet side Air Terminal Mixer automatically adjusts zone equipment coil sizing.
   **   ~~~   **  Set Account for Dedicated Outdoor Air System = No in Sizing:Zone object for zone = SPACE1-1.

   ** Warning ** AirTerminal:SingleDuct:Mixer: SPACE4-1 DOAS AIR TERMINAL
   **   ~~~   **  Supply side Air Terminal Mixer does not adjust zone equipment coil sizing and may result in inappropriately sized coils.
   **   ~~~   **  Set Account for Dedicated Outdoor Air System = Yes in Sizing:Zone object for zone = SPACE4-1.

mjwitte · 2018-09-13T13:03:09Z

DOAToPTAC - Current results show the heating coil sensible capacity is now the same as total (that was broken before), but the coil inlet temp is the OA temp? And cooling coil inlet conditions are nearly the same as outdoor also? In the component sizing summary design cooling and heating flow rates for the PTAC 1-1 are both 0.22, and the ATMixer flow rate is 0.0572, so it seems like the coil entering conditions should be closer to zone conditions than outdoor. But the coil sizing details show the heating coil design flow rate at 0.572? Similar questions for other systems.

rraustad · 2018-09-13T14:02:59Z

Looking at OutdoorAirUnit at the moment. The heating coil is sizing differently because I added the new function call in heating coils thinking it would reduce code. What is happening is that the desiccant heating coil previously sized using DesHeatCoilInTemp and now it sizes using ZoneTempAtHeatPeak, which is of course wrong. The OAUnit sizing function doesn't set ZoneEqSizing::OAVolFlow (it does now). The problem I see here is that zone sizing does not know what type of equipment there is or how many. In this case there is only the OutdoorAirUnit. But what if there were the OAUnit and a PTAC with no OA, then the PTAC would be using -17C to size the heating coil? I've seen this before with the OA unit. My change corrects the heating coil size but there is still this other lurking issue. Now on to other things you noticed.

ZoneHVAC:EquipmentConnections,
  SPACE1-1,                !- Zone Name
  Zone1Equipment,          !- Zone Conditioning Equipment List Name
  Zone1Inlets,             !- Zone Air Inlet Node or NodeList Name
  Zone1Exhausts,           !- Zone Air Exhaust Node or NodeList Name
  Zone 1 Node,             !- Zone Air Node Name
  Zone 1 Outlet Node;      !- Zone Return Air Node or NodeList Name

ZoneHVAC:EquipmentList,
  Zone1Equipment,          !- Name
  SequentialLoad,          !- Load Distribution Scheme
  ZoneHVAC:OutdoorAirUnit, !- Zone Equipment 1 Object Type
  Zone1OutAir,             !- Zone Equipment 1 Name
  1,                       !- Zone Equipment 1 Cooling Sequence
  1;                       !- Zone Equipment 1 Heating or No-Load Sequence

Sizing:Zone,
  SPACE1-1,                !- Zone or ZoneList Name
  SZ DSOA SPACE1-1,        !- Design Specification Outdoor Air Object Name

DesignSpecification:OutdoorAir,
  SZ DSOA SPACE1-1,        !- Name
  Flow/Zone,               !- Outdoor Air Method
  0,                       !- Outdoor Air Flow per Person {m3/s-person}
  0.0,                     !- Outdoor Air Flow per Zone Floor Area {m3/s-m2}
  0.42;                    !- Outdoor Air Flow per Zone {m3/s}

rraustad · 2018-09-13T14:28:25Z

For DOAToPTAC, when capacity is sized, where CoilInTemp is also set and used to calculate capacity, the capacity gets reported but the coil conditions do not. So at the bottom of request sizing where capacity is reported, when it jumps over the setCoilCoolingCapacity, that function sets coil inlet temp as the ATMixer primary air temp. Since there are no coils in the ATMixer, the supply air temp = OA temp. I have fixed this over in #5763 (New Feature - Include fan heat in coil sizing). I've got a lot of kettles on the fire. Maybe a followup issue to make sure these are corrected after all PR's are merged? Or merge in those changes here to get these results correct?

rraustad · 2018-09-13T14:30:20Z

I've fixed the duplicate warnings and desiccant heating coil sizing issues. Just need to push those changes.

mjwitte · 2018-09-13T14:36:35Z

Would it be better to review and merge the fan heat PR before this to set a new baseline for comparison?

rraustad · 2018-09-13T14:42:28Z

Good idea. That would fix this last issue when merged into this branch.

…-Zone-Coil-Autosizing-does-not-include-impact-of-AirTerminalSingleDuctMixer

mjwitte · 2018-09-14T19:05:23Z

@rraustad Please resolve the conflict here and merge up today if you can.

…-Zone-Coil-Autosizing-does-not-include-impact-of-AirTerminalSingleDuctMixer

rraustad · 2018-09-14T20:05:22Z

Need to verify this comment when results are available:

DOAToPTAC - Current results show the heating coil sensible capacity is now the same as total (that was broken before), but the coil inlet temp is the OA temp? And cooling coil inlet conditions are nearly the same as outdoor also? In the component sizing summary design cooling and heating flow rates for the PTAC 1-1 are both 0.22, and the ATMixer flow rate is 0.0572, so it seems like the coil entering conditions should be closer to zone conditions than outdoor. But the coil sizing details show the heating coil design flow rate at 0.572? Similar questions for other systems.

mjwitte · 2018-09-14T20:16:44Z

Just to be clear, the "0.572" should be "0.0572" - equal to the OA flow.

rraustad · 2018-09-14T21:13:10Z

So if PTAC flow = OA flow then coil inlet temp = OA temp.

mjwitte · 2018-09-14T21:16:28Z

Yes, but the question here is that the reported design cooling and heating flow rates for the PTAC 1-1 are both 0.22, so why is it sizing the heating coil for only 0.0572?

rraustad · 2018-09-14T23:39:17Z

Looking at this now, DOAToPTAC. I see that SPACE1-1 PTAC air flow is sized larger than before. This is a little surprising since I only expect coil entering/exiting conditions (and capacity) to change. So comment here if you wish as I look at what is happening.

 ! <Component Sizing Information>, Component Type, Component Name, Input Field Description, Value
- Component Sizing Information, ZoneHVAC:PackagedTerminalAirConditioner, SPACE1-1 PTAC, Design Size Cooling Supply Air Flow Rate [m3/s], 0.22088
- Component Sizing Information, ZoneHVAC:PackagedTerminalAirConditioner, SPACE1-1 PTAC, Design Size Heating Supply Air Flow Rate [m3/s], 0.22088
+ Component Sizing Information, ZoneHVAC:PackagedTerminalAirConditioner, SPACE1-1 PTAC, Design Size Cooling Supply Air Flow Rate [m3/s], 0.26879
+ Component Sizing Information, ZoneHVAC:PackagedTerminalAirConditioner, SPACE1-1 PTAC, Design Size Heating Supply Air Flow Rate [m3/s], 0.26879
  Component Sizing Information, ZoneHVAC:PackagedTerminalAirConditioner, SPACE1-1 PTAC, User-Specified No Load Supply Air Flow Rate [m3/s], 0.00000
- Component Sizing Information, Fan:OnOff, SPACE1-1 SUPPLY FAN, Design Size Maximum Flow Rate [m3/s], 0.22088
- Component Sizing Information, Coil:Cooling:DX:SingleSpeed, SPACE1-1 PTAC CCOIL, Design Size Rated Air Flow Rate [m3/s], 0.22088
- Component Sizing Information, Coil:Cooling:DX:SingleSpeed, SPACE1-1 PTAC CCOIL, Design Size Gross Rated Total Cooling Capacity [W], 5469.07698
- Component Sizing Information, Coil:Cooling:DX:SingleSpeed, SPACE1-1 PTAC CCOIL, Design Size Gross Rated Sensible Heat Ratio, 0.69880
+ Component Sizing Information, Fan:OnOff, SPACE1-1 SUPPLY FAN, Design Size Maximum Flow Rate [m3/s], 0.26879
+ Component Sizing Information, Coil:Cooling:DX:SingleSpeed, SPACE1-1 PTAC CCOIL, Design Size Rated Air Flow Rate [m3/s], 0.26879
+ Component Sizing Information, Coil:Cooling:DX:SingleSpeed, SPACE1-1 PTAC CCOIL, Design Size Gross Rated Total Cooling Capacity [W], 5858.00167
+ Component Sizing Information, Coil:Cooling:DX:SingleSpeed, SPACE1-1 PTAC CCOIL, Design Size Gross Rated Sensible Heat Ratio, 0.74025
 ! <DX Cooling Coil Standard Rating Information>, Component Type, Component Name, Standard Rating (Net) Cooling Capacity {W}, Standard Rated Net COP {W/W}, EER {Btu/W-h}, SEER {Btu/W-h}, IEER {Btu/W-h}
- DX Cooling Coil Standard Rating Information, Coil:Cooling:DX:SingleSpeed, SPACE1-1 PTAC CCOIL, 5297.4, 2.66, 9.07, 9.63, 9.51
+ DX Cooling Coil Standard Rating Information, Coil:Cooling:DX:SingleSpeed, SPACE1-1 PTAC CCOIL, 5649.2, 2.61, 8.92, 9.47, 9.28
  Component Sizing Information, Coil:Heating:Fuel, SPACE1-1 HEATING COIL, Design Size Nominal Capacity [W], 2899.74027

rraustad · 2018-09-15T00:43:35Z

So it's sizing the heating coil based on the zone heating air flow rate (DesHeatMassFlow). This should probably size using the PTAC flow rate? But it's a fuel heating coil, you've told me many times that this type of coil shouldn't size the same as the DX. Shouldn't fix this here.

ZoneHVAC:PackagedTerminalAirConditioner,
  SPACE1-1 PTAC,           !- Name
  Coil:Heating:Fuel,       !- Heating Coil Object Type
  SPACE1-1 Heating Coil,   !- Heating Coil Name

rraustad · 2018-09-15T00:53:23Z

Bear in mind I could set any of these, HeatingCapacity, DataCoolCap or DataFlowUsedForSizing, But we have decided to size the heating coil based on the zone load when that coil wasn't DX.

            } else if (SizingType == HeatingCapacitySizing) {
                if (ZoneEqSizing(CurZoneEqNum).HeatingCapacity) {
                    NominalCapacityDes = ZoneEqSizing(CurZoneEqNum).DesHeatingLoad;
                    if (DataFlowUsedForSizing > 0.0) {
                        DesVolFlow = DataFlowUsedForSizing;
                    }
                } else if (DataCoolCoilCap > 0.0 && DataFlowUsedForSizing > 0.0) {
                    NominalCapacityDes = DataCoolCoilCap;
                    DesVolFlow = DataFlowUsedForSizing;
                } else if (FinalZoneSizing(CurZoneEqNum).DesHeatMassFlow >= SmallMassFlow) {
                    if (DataFlowUsedForSizing > 0.0) {
                        DesVolFlow = DataFlowUsedForSizing;
                    }

mjwitte · 2018-09-16T19:56:42Z

Regarding the PTAC heating coil sizing, I recall there have been some fixes to this over time. I'm going to move that file to Chicago and see if it can hold setpoint for a year. That checks out OK, very similar loads not met before and after this. However, for zones 4 and 5, the heating coils are signficantly smaller now than current develop. Running a design day zone 5 is ok, but zone 4 is maxing out the heating coil. So, PTAC may still need some work.

Here's some zips with results. I haven't looked at the other system types this closely.
6712-ATMixerSizing-After.zip
6712-ATMixerSizing-Before.zip

Reviewing the err diffs.
PackagedTerminalHeatPumpVSAS and PackagedTerminalAirConditionerVSAS have new warnings:

+   ** Warning ** ZoneHVAC:PackagedTerminalHeatPump - air flow rate = 0.2148646 in fan object is less than the MSHP system air flow rate when cooling is required (0.2725907).
+   **   ~~~   **  The MSHP system flow rate when cooling is required is reset to the fan flow rate and the simulation continues.
+   **   ~~~   **  Occurs in ZoneHVAC:PackagedTerminalHeatPump = ZONE2PTAC

DOAToFanCoilSupply and DOAToWaterToAirHPSupply

+   ** Warning ** AirTerminal:SingleDuct:Mixer: SPACE5-1 DOAS AIR TERMINAL
+   **   ~~~   **  Supply side Air Terminal Mixer does not adjust zone equipment coil sizing and may result in inappropriately sized coils.
+   **   ~~~   **  Set Account for Dedicated Outdoor Air System = Yes in Sizing:Zone object for zone = SPACE5-1

These should get cleaned up, but I'm not going to hold this up for that. You can throw in a separate little PR for that if there aren't any other changes to do here.

mjwitte · 2018-09-16T19:59:55Z

Probably should have some doc changes, too for this to explain the sizing difference for inletside vs supplyside, in the mixer object and in the Sizing:Zone DOAS fields.

mjwitte · 2018-09-17T00:38:47Z

But zone 4 is a supply side mixer, it maxes out the heating coil on the winter design day before this changes as well. Oh, I see, the DOAS inputs in Sizing:Zone don't work for Chicago, because it's an unconditioned DOAS. So, these example files could use a little more tweaking. Merging this.

mjwitte · 2018-09-17T00:40:03Z

But it would still be good to add some notes in the I/O Ref about when an what sizing does with ATMixers now.

First pass at including ATMixer in fan coil sizing

4192eb6

rraustad mentioned this pull request Jun 19, 2018

Zone Coil Autosizing does not include impact of AirTerminal:SingleDuct:Mixer #6712

Closed

3 tasks

rraustad commented Jun 19, 2018

View reviewed changes

Correct energyplus_tests so CI will compile

ac5ebb8

rraustad commented Jun 20, 2018

View reviewed changes

Revised new functions. Ready to move forward to other Eq types.

768e2ec

rraustad commented Jun 20, 2018

View reviewed changes

rraustad self-assigned this Jun 20, 2018

rraustad added Defect Includes code to repair a defect in EnergyPlus PriorityHigh This defect or feature has been declared high priority labels Jun 20, 2018

Clean up comments in new functions

7cd40cf

rraustad added 2 commits June 20, 2018 20:34

Revert return temp change to eliminate spurious diffs.

319592c

Forgot one.

7183182

rraustad commented Jun 21, 2018

View reviewed changes

Merge branch '#6712-Zone-Coil-Autosizing-does-not-include-impact-of-A…

ecc43a9

…irTerminalSingleDuctMixer' of https://github.com/NREL/EnergyPlus into #6712-Zone-Coil-Autosizing-does-not-include-impact-of-AirTerminalSingleDuctMixer

rraustad changed the title ~~First pass at including ATMixer in fan coil sizing~~ Include impact of AirTerminal:SingleDuct:Mixer in ZoneHVAC coil sizing Jun 21, 2018

Include other zone equipment for ATMixer coil sizing and add unit tests

e124fef

rraustad added 2 commits June 21, 2018 22:05

Clean up commented lines for final pass, revert zone temp for zone re…

6df2e42

…turn temp to check diffs.

Set ZoneEqSizing.OAFlow before coils size.

2752ebf

rraustad added 2 commits September 8, 2018 22:15

Update unit tests based on recent changes

be61d9e

Add warnings to account for DOAS coil sizing

26b6d5b

rraustad added 3 commits September 13, 2018 11:23

Correct duplicate message and sizing of desiccant heating coil

41e2928

Merge branch 'develop' of https://github.com/NREL/EnergyPlus into #6712…

4677015

…-Zone-Coil-Autosizing-does-not-include-impact-of-AirTerminalSingleDuctMixer

Update example files based on new warning

00cf8dd

Merge branch 'develop' of https://github.com/NREL/EnergyPlus into #6712…

4b61de3

…-Zone-Coil-Autosizing-does-not-include-impact-of-AirTerminalSingleDuctMixer

mjwitte approved these changes Sep 17, 2018

View reviewed changes

mjwitte merged commit 40434b6 into develop Sep 17, 2018

mjwitte deleted the #6712-Zone-Coil-Autosizing-does-not-include-impact-of-AirTerminalSingleDuctMixer branch September 17, 2018 00:40

mjwitte mentioned this pull request Sep 20, 2018

Addressed zone hvac heating coil sizing with DOAS mixer #6838

Closed

8 tasks

mjwitte mentioned this pull request Jul 5, 2019

Ideal loads heating capacity sizing does not account for OA load - was ok in v8.9 #7375

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Include impact of AirTerminal:SingleDuct:Mixer in ZoneHVAC coil sizing #6788

Include impact of AirTerminal:SingleDuct:Mixer in ZoneHVAC coil sizing #6788

rraustad commented Jun 19, 2018 •

edited by mjwitte

rraustad Jun 19, 2018 •

edited

rraustad commented Jun 19, 2018

rraustad Jun 20, 2018

rraustad Jun 20, 2018

rraustad Jun 20, 2018

rraustad Jun 20, 2018

rraustad Jun 20, 2018

rraustad commented Jun 20, 2018

rraustad commented Jun 20, 2018

rraustad commented Jun 21, 2018

rraustad Jun 21, 2018

rraustad commented Jun 21, 2018

rraustad commented Jun 21, 2018

rraustad commented Jun 21, 2018

rraustad commented Jun 22, 2018

mjwitte commented Sep 13, 2018

mjwitte commented Sep 13, 2018

rraustad commented Sep 13, 2018

rraustad commented Sep 13, 2018

rraustad commented Sep 13, 2018

mjwitte commented Sep 13, 2018

rraustad commented Sep 13, 2018

mjwitte commented Sep 14, 2018

rraustad commented Sep 14, 2018

mjwitte commented Sep 14, 2018

rraustad commented Sep 14, 2018

mjwitte commented Sep 14, 2018

rraustad commented Sep 14, 2018

rraustad commented Sep 15, 2018 •

edited

rraustad commented Sep 15, 2018

mjwitte commented Sep 16, 2018

mjwitte commented Sep 16, 2018

mjwitte commented Sep 17, 2018

mjwitte commented Sep 17, 2018

Include impact of AirTerminal:SingleDuct:Mixer in ZoneHVAC coil sizing #6788

Include impact of AirTerminal:SingleDuct:Mixer in ZoneHVAC coil sizing #6788

Conversation

rraustad commented Jun 19, 2018 • edited by mjwitte

Pull request overview

Work Checklist

Review Checklist

rraustad Jun 19, 2018 • edited

Choose a reason for hiding this comment

rraustad commented Jun 19, 2018

rraustad Jun 20, 2018

Choose a reason for hiding this comment

rraustad Jun 20, 2018

Choose a reason for hiding this comment

rraustad Jun 20, 2018

Choose a reason for hiding this comment

rraustad Jun 20, 2018

Choose a reason for hiding this comment

rraustad Jun 20, 2018

Choose a reason for hiding this comment

rraustad commented Jun 20, 2018

rraustad commented Jun 20, 2018

rraustad commented Jun 21, 2018

rraustad Jun 21, 2018

Choose a reason for hiding this comment

rraustad commented Jun 21, 2018

rraustad commented Jun 21, 2018

rraustad commented Jun 21, 2018

rraustad commented Jun 22, 2018

mjwitte commented Sep 13, 2018

mjwitte commented Sep 13, 2018

rraustad commented Sep 13, 2018

rraustad commented Sep 13, 2018

rraustad commented Sep 13, 2018

mjwitte commented Sep 13, 2018

rraustad commented Sep 13, 2018

mjwitte commented Sep 14, 2018

rraustad commented Sep 14, 2018

mjwitte commented Sep 14, 2018

rraustad commented Sep 14, 2018

mjwitte commented Sep 14, 2018

rraustad commented Sep 14, 2018

rraustad commented Sep 15, 2018 • edited

rraustad commented Sep 15, 2018

mjwitte commented Sep 16, 2018

mjwitte commented Sep 16, 2018

mjwitte commented Sep 17, 2018

mjwitte commented Sep 17, 2018

rraustad commented Jun 19, 2018 •

edited by mjwitte

rraustad Jun 19, 2018 •

edited

rraustad commented Sep 15, 2018 •

edited