Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct ERV sizing reports to eio file #6989

Conversation

rraustad
Copy link
Contributor

@rraustad rraustad commented Sep 26, 2018

Pull request overview

ZoneHVAC:EnergyRecoveryVentilator sizing reports were missing or duplicating information to the eio file. This corrects #6820 and #6987.

Work Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • At least one of the following appropriate labels must be added to this PR to be consumed into the changelog:
    • Defect: This pull request repairs a github defect issue. The github issue should be referenced in the PR description
    • Refactoring: This pull request includes code changes that don't change the functionality of the program, just perform refactoring
    • NewFeature: This pull request includes code to add a new feature to EnergyPlus
    • Performance: This pull request includes code changes that are directed at improving the runtime performance of EnergyPlus
    • DoNoPublish: This pull request includes changes that shouldn't be included in the changelog

Review Checklist

This will not be exhaustively relevant to every PR.

  • Functional code review (it has to work!)
  • If defect, results of running current develop vs this branch should exhibit the fix
  • CI status: all green or justified
  • Performance: CI Linux results include performance check
  • Unit Test(s)
  • C++ checks:
    • Argument types
    • If any virtual classes, ensure virtual destructor included, other things
  • IDD changes:
    • Verify naming conventions and styles, memos and notes and defaults
    • Open windows IDF Editor with modified IDD to check for errors
    • If transition, add to input rules file for interfaces
    • If transition, add transition source
    • If transition, update idfs
  • If new idf included, locally check the err file and other outputs
  • Required documentation updates?
  • ExpandObjects changes?
  • If output changes, including tabular output structure, add to output rules file for interfaces

@Myoldmopar
Copy link
Member

image
YES!

@Myoldmopar
Copy link
Member

@rraustad I merged develop and cleaned up the build warning. It should come back all green now. I'll review and see if we can drop this in today before I tag 9.0.

@rraustad
Copy link
Contributor Author

Perfect, thank you. I thought you might want this in the release so I worked to get it quickly.

@rraustad
Copy link
Contributor Author

@Myoldmopar @RKStrand no unhandled exceptions here.

@Myoldmopar Myoldmopar merged commit 2ef880d into develop Sep 27, 2018
@Myoldmopar Myoldmopar deleted the #6987-ZoneHVACEnergyRecoveryVentilator-sizing-issue-when-using-FanSystemModel branch September 27, 2018 20:27
@Myoldmopar Myoldmopar added the Defect Includes code to repair a defect in EnergyPlus label Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants