Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and Refactoring of Plant Structures #7141

Merged
merged 10 commits into from Feb 4, 2019
Merged

Conversation

Myoldmopar
Copy link
Member

Pull request overview

This cleans up a few things in the code:

  • Eliminate a repeated allocation made within the iteration loop
  • Initial cleanup of some plant utility functions
  • Change the plant data structure to use scalars for splitter and mixer -- we only allow a max of one each anyway, this should make a tiny dent in the runtime by not having to do lookups in the arrays (which are always allocated to 1...)

@Myoldmopar Myoldmopar added the Refactoring Includes code changes that don't change the functionality of the program, just perform refactoring label Jan 29, 2019
@Myoldmopar Myoldmopar added this to the EnergyPlus 9.1.0 milestone Jan 29, 2019
@Myoldmopar Myoldmopar self-assigned this Jan 29, 2019
@Myoldmopar
Copy link
Member Author

Ahhh, another nice no-diff cleanup. Merging.

@Myoldmopar Myoldmopar merged commit 347e8b0 into develop Feb 4, 2019
@Myoldmopar Myoldmopar deleted the Cleanups_201901 branch February 4, 2019 19:04
@Myoldmopar Myoldmopar added the Performance Includes code changes that are directed at improving the runtime performance of EnergyPlus label Feb 21, 2019
@Myoldmopar Myoldmopar changed the title Cleanup and Refactoring Cleanup and Refactoring of Plant Structures Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Includes code changes that are directed at improving the runtime performance of EnergyPlus Refactoring Includes code changes that don't change the functionality of the program, just perform refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants