Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable test_pressure_vessel.py #200

Closed
camirmas opened this issue Aug 22, 2023 · 1 comment
Closed

Re-enable test_pressure_vessel.py #200

camirmas opened this issue Aug 22, 2023 · 1 comment
Labels
bug Something isn't working refactor Associated with the refactor of HOPP

Comments

@camirmas
Copy link
Collaborator

There's some issue where PySAM 3.0.0 and CoolProp don't play well together in our Linux CI build. Re-enable this test once we've upgraded to PySAM 4.x
@camirmas camirmas added refactor Associated with the refactor of HOPP bug Something isn't working labels Aug 22, 2023
@camirmas camirmas mentioned this issue Aug 22, 2023
Closed
@camirmas
Copy link
Collaborator Author

camirmas commented Nov 2, 2023

This is tied to #248

camirmas added a commit to camirmas/HOPP that referenced this issue Nov 9, 2023
@camirmas
[ref NREL#200] Re-enable test_pressure_vessel.py
8f06f53
@camirmas camirmas mentioned this issue Nov 9, 2023
Merged
camirmas added a commit that referenced this issue Nov 10, 2023
@camirmas
[ref #200] Re-enable test_pressure_vessel.py (#254)
e8d8b86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working refactor Associated with the refactor of HOPP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@camirmas