-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable custom financial models #109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a last quick documentation request, but then it's good to merge!
@@ -27,12 +27,15 @@ def __init__(self, | |||
'layout_config': optional dict, contains all keys for PVLayoutConfig dataclass. Required for layout modeling | |||
""" | |||
system_model = Pvsam.default("FlatPlatePVSingleOwner") | |||
financial_model = Singleowner.from_existing(system_model, "FlatPlatePVSingleOwner") | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add this option of pv_config to the docstring above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, and removed parameter in docstring that will come next with the detailed layout implementation
@dguittet The actual custom financial model templates will be added on the other feature branch. At that point, any missing functionality that is discovered can be implemented here in master.