Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H2 optimize tests #28

Merged
merged 27 commits into from
May 21, 2022
Merged

H2 optimize tests #28

merged 27 commits into from
May 21, 2022

Conversation

pjstanle
Copy link
Collaborator

@pjstanle pjstanle commented May 2, 2022

Gradient-free H2 optimization scripts running with most recent changes. Test for optimization script.

@dguittet
Copy link
Collaborator

dguittet commented May 4, 2022

This test has revealed that h2_setup_optimize.py has a seg fault on Linux / HPC. It ran fine on Mac though.

(/home/dguittet/.conda-envs/hybrid) [dguittet@el3 H2_Analysis]$ python h2_setup_optimize.py 
Segmentation fault (core dumped)

@dguittet
Copy link
Collaborator

dguittet commented May 4, 2022

For the documentation, please describe what the functions do, what assumptions they make, how they do it, what the design variables are.

Here are some examples of other optimization scripts with documentation:
https://github.com/NREL/HOPP/blob/merge_H2/examples/optimization/layout_opt/hybrid_optimization_problem.py
https://github.com/NREL/HOPP/blob/merge_H2/examples/optimization/layout_opt/hybrid_parametrization.py

@dguittet
Copy link
Collaborator

dguittet commented May 4, 2022

The seg faults may have to do with battery sizing where the power capacity is 0 but the energy is non-zero. This doesn't really make sense model-wise. Is the battery duration a fixed or a design variable?

image

@pjstanle
Copy link
Collaborator Author

pjstanle commented May 6, 2022

I added doc strings to all of the functions in the optimization files. I also added a flag to check for zero battery capacity and changed the bounds in the GF optimization. Hopefully that will fix the seg fault issue.

Base automatically changed from merge_H2 to master May 21, 2022 03:14
@dguittet dguittet changed the base branch from master to merge_H2 May 21, 2022 16:08
@dguittet dguittet changed the base branch from merge_H2 to master May 21, 2022 16:10
@dguittet dguittet changed the base branch from master to merge_H2 May 21, 2022 16:12
@dguittet dguittet merged commit 84d9f05 into merge_H2 May 21, 2022
@dguittet dguittet deleted the H2_optimize_tests branch May 21, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants