Unify resource files location #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dguittet
approved these changes
May 23, 2024
| @@ -76,7 +76,7 @@ def __init__(self, lat, lon, | |||
| # paths | |||
| self.path_current = os.path.dirname(os.path.abspath(__file__)) | |||
| self.path_results = os.path.join(self.path_current) | |||
| self.path_rates = os.path.join(self.path_current, '..', 'resource_files', 'utility_rates') | |||
| self.path_rates = os.path.join(self.path_current, '../', 'resource_files', 'utility_rates') | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify resource file location
There were two locations in HOPP where resource files were being stored: (1)
HOPP/resource_files/, (2)HOPP/hopp/simulation/resource_files/. This pull request moves all necessary files from (1) to (2) and removes (1). All references to (1) have been redirected to (2).Related issue
While an official issue was never made, location (1) was problematic because the data in (1) could not be directly referenced when HOPP was installed on an HPC system and could likely cause problems in other environments. Moving all resource files to (2) enables storing the resource data files inside the installed hopp package and will thus be available for all installation approaches and environments.
Impacted areas of the software
Additional supporting information
Test results, if applicable