Support BuildingAmerica seasons in BuildResHPXML measure #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shorowit
reviewed
Aug 11, 2022
|
@afontani reports that this change works for ResStock: NREL/resstock#975 (comment) |
|
@joseph-robertson Can you update the PR checklist? |
shorowit
approved these changes
Aug 16, 2022
shorowit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
When seasons arguments are
BuildingAmerica, get month arrays fromweatherobject, and use them to populate season fields of HPXML file. This should simplify things on the ResStock end.Checklist
PR Author: Check these when they're done. Not all may apply.
strikethroughand check any that do not apply.PR Reviewer: Verify each has been completed.
Schematron validator (EPvalidator.xml) has been updatedSample files have been added/updated (viatasks.rb)HPXMLtoOpenStudio/tests)openstudio tasks.rb update_measureshas been run