Support auto_seasons arguments #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like a lot of code/complexity in ResStock just to support this. Would it make more sense to make the changes upstream? E.g., Update the heating/cooling season arguments in the BuildResHPXML measure to support a string like "BuildingAmerica". |
|
Probably. Seems like it would also eliminate a good amount of duplicate code, too. |
…998f9 495d9e998f9 Add a sample file for auto seasons. 1abffd95325 Optionally populate BA season. 8c6011c7d8b Add BA enum and new schedules method. bd50992f914 Update docs. b9515c3c60c Merge pull request #1147 from NREL/seer2_hspf2 9595b26cb31 Latest results. ccd0516c5b0 Fix ASHP test. 7614fe4689d Allow SEER2/HSPF2 efficiency types for central air conditioners and heat pumps. Also speeds up tasks.rb update_hpxmls. b76e21a4af2 Merge pull request #1146 from NREL/weather_tests 4d76f22f4fa Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into weather_tests 80739f5d5a8 Add unit test for NREL/OpenStudio-HPXML#1144. c9c88488d9c Merge pull request #1145 from NREL/sch-warn-bugfix cadf93c6c4a Check for more schedule file and multiplier warnings. 131a3b60ffa Merge branch 'master' into sch-warn-bugfix 9ef3399e26c Update README.md [ci skip] 8a38889ad18 Missing runner. d06272bbc22 Merge pull request #1144 from NREL/weather_dump_bugfix git-subtree-dir: resources/hpxml-measures git-subtree-split: 495d9e998f98c361101f5779756fef98d0eaa9a9
…d439d c52084d439d Latest results. 46b7628d111 Small fix in schedule file measure. 555c5636f41 Fix new defaulting changes. d69e75c5fd7 Consolidate sim calendar year code and write seasons test. bbde7a89a96 Remove extra sample file. ee5cd7c3b10 Latest results. git-subtree-dir: resources/hpxml-measures git-subtree-split: c52084d439dc65aef26f7f5d75b78d599aff73b4
|
I can confirm this change works. |
8 tasks
…73252 397ce673252 Merge pull request #1152 from NREL/building-america-seasons f3a00795b6c Make suggested optional simplification. 0ddfbe2ac18 Clean up after tests. git-subtree-dir: resources/hpxml-measures git-subtree-split: 397ce673252c8091ea74f57eb852274513eca4ff
afontani
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Looks like OS-HPXML auto_seasons related arguments may have been updated, but ResStockArguments subsequently was not. I believe this was not caught because our testing project does not currently sample any setpoint options which enable the auto_seasons arguments.
Checklist
Not all may apply:
openstudio tasks.rb update_measureshas been run