Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor HPXML class bugfix #1766

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Minor HPXML class bugfix #1766

merged 1 commit into from
Jul 2, 2024

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Jul 2, 2024 •
edited
Loading

Pull Request Description

Fixes possible error in HPXML class for an edge case situation.

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit added the bug Something isn't working label Jul 2, 2024
@shorowit shorowit self-assigned this Jul 2, 2024
@shorowit shorowit merged commit e10e41e into master Jul 2, 2024
7 checks passed
@shorowit shorowit deleted the hpxml_class_bugfix branch July 2, 2024 14:25
@joseph-robertson joseph-robertson mentioned this pull request Jul 11, 2024
Merged
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shorowit shorowit

Labels
bug Something isn't working
Projects
OpenStudio-HPXML
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shorowit