Check if R libraries install correctly #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needed to fix the eval with timeout method per the error message: |
anyaelena
reviewed
Nov 2, 2018
| @@ -2,7 +2,7 @@ | |||
| # DESCRIPTION: OpenStudio Server R Container | |||
| # TO_BUILD_AND_RUN: docker-compose up | |||
|
|
|||
| FROM nrel/openstudio-r:3.4.2 | |||
| FROM nrel/openstudio-r:3.4.2-2 | |||
There was a problem hiding this comment.
when do we increment the version for openstudio-r?
anyaelena
approved these changes
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in a new R method to check if the R packages are successfully installed.
The issue was seen when installing a newer DoE.base package that required a new dependency to be installed in the base linux image. The first build of this PR will show a failure, demonstrating that the
install_and_verifymethod correctly errors out. The second build will be after the base openstudio-r image has been updated with the change seen here: NREL/docker-openstudio-r@0360dcd#diff-3254677a7917c6c01f55212f86c57fbfR31Note that the 2.7.0 docker images will not work with DoE.base.