Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap SurfaceProperty:SurroundingSurfaces for Modeling Thermal Interactions between Buildings in an Urban Context #4533

Closed
DavidGoldwasser opened this issue Feb 11, 2022 · 2 comments · Fixed by #4535

Comments

@DavidGoldwasser
Copy link
Collaborator

Enhancement Request

Wrap feature from this pull request merged into EnergyPlus 8.8 so it can be used through an OpenStudio measure.
https://github.com/NREL/EnergyPlus/pull/6227/files

Detailed Description

See this paper for detail of functionality
https://escholarship.org/content/qt5261v2kp/qt5261v2kp_noSplash_797b20ea4b4a8652bf208ffabc719425.pdf?t=qaomhp

Possible Implementation

One or more objects need to be added, I'll see if I can identify those objects.

@DavidGoldwasser DavidGoldwasser added Enhancement Request Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Feb 11, 2022
@DavidGoldwasser
Copy link
Collaborator Author

DavidGoldwasser commented Feb 11, 2022

Link to markdown design doc
https://github.com/NREL/EnergyPlus/blob/96be0affe1704093bbf766f5e051c88819a7bfe1/design/FY2017/NFP-Improving%20Building%20Energy%20Simulation%20in%20an%20Urban%20Context.md

(1) External Shading Fraction Schedule for external shading calculation

  • Modify existing ShadowCalculation objet

(2) Surrounding surface properties for long-wave radiation calculation between buildings

  • A new EnergyPlus object SurfaceProperty:SurroundingSurfaces

(3) Local Outdoor Air Node for co-simulation with urban micro-climate

  • Modify existing OutdoorAir:Node

Looking through this, I am primarily interested in item 2 related to SurfaceProperty:SurroundingSurfaces, although the other objects also seem useful, but wouldn't have to be added to OpenStudio at same time as item 2

Here is link to documentation for that object
https://bigladdersoftware.com/epx/docs/9-6/input-output-reference/group-advanced-surface-concepts.html#surfacePropertysurroundingSurfaces

@DavidGoldwasser DavidGoldwasser changed the title Modeling Thermal Interactions between Buildings in an Urban Context Wrap SurfaceProperty:SurroundingSurfaces for Modeling Thermal Interactions between Buildings in an Urban Context Feb 11, 2022
@jmarrec jmarrec self-assigned this Feb 17, 2022
@jmarrec jmarrec removed the Triage Issue needs to be assessed and labeled, further information on reported might be needed label Feb 17, 2022
@jmarrec
Copy link
Collaborator

jmarrec commented Feb 17, 2022

Need the SurfaceProperty:LocalEnvironment as well. I'm almost done implementing this, I need to write FT tests and an OpenStudio-resources regression test (and determine whether I want to do a ReverseTranslator as well or not. I think the other SurfaceProperty objects aren't RT'ed, except the FoundationPerimeter ones)

@tijcolem tijcolem added this to the OpenStudio SDK 3.4.0 milestone Feb 18, 2022
tijcolem added a commit that referenced this issue Feb 18, 2022
…faces

Fix #4533 - Wrap SurfaceProperty:LocalEnvironment and SurfaceProperty:SurroundingSurfaces
@tijcolem tijcolem added this to Done in OpenStudio Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
OpenStudio
  
Done
3 participants