Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4533 - Wrap SurfaceProperty:LocalEnvironment and SurfaceProperty:SurroundingSurfaces #4535

Merged
merged 21 commits into from Feb 18, 2022
Merged

Fix #4533 - Wrap SurfaceProperty:LocalEnvironment and SurfaceProperty:SurroundingSurfaces #4535

merged 21 commits into from Feb 18, 2022

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Feb 18, 2022 •
edited

Pull request overview

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: #4533 - Wrap SurfaceProperty:LocalEnvironment and SurfaceProperty:SurroundingSurfaces OpenStudio-resources#163
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec
SurfaceProperty:SurroundingSurfaces: Copy the E+ IDD as is
202aa90
@jmarrec
SurfaceProperty:SurroundingSurfaces: Make modification to the IDD for…
2d5f85c 
… OpenStudio: the Sky and Ground View Factors are autocalculatable
@jmarrec
Don't see the point in having both isXXXDefaulted and isXXXAutocalcul…
c3c5762 
…ated, so remove default from idd
@jmarrec
Realized that the Surrounding Surface Name is really an alpha, not a …
03ab3c3 
…surface.
@jmarrec
SurfaceProperty:LocalEnvironment is needed to use SurfaceProperty:Sur…
de6e647 
…roundingSurfaces
@jmarrec
Modification to SurfaceProperty:LocalEnvironment for OpenStudio.idd
e7115e1
@jmarrec
E+ has a wrong reference for the surface field, the example file has …
64fd040 
…a fenestration object, so adjust

Filed an E+ issue at NREL/EnergyPlus#9275
@jmarrec
Implement model classes for SurfaceProperty:SurroundingSurface. With …
81793b9 
…a helper class for extensible fields
@jmarrec
Initial pass at model class for SurfacePropertyLocalEnvironment
b94eef1
@jmarrec
SurfacePropertyLocalEnvironment: since it can actually accept subsurf…
377957c 
…aces, make necessary changes
@jmarrec
Add a getter in Surface/SubSurface for surfacePropertyLocalEnvironment
286b5b1
@jmarrec
Model tests for SurfacePropertySurroundingSurfaces
6c8ba99
@jmarrec
Model tests for SurfacePropertyLocalEnvironment
9bd2198
@jmarrec
More tests for SurfacePropertyLocalEnvironment
cd97f16
@jmarrec
FT for SurfacePropertyLocalEnvironment and SurfacePropertySurrounding…
48ca33c 
…Surfaces
@jmarrec
Add FT Test for SurfacePropertySurroundingSurfaces
c9df953
@jmarrec
Add FT Test for SurfacePropertyLocalEnvironment, which is failing due…
2f9252f 
… to E+ idd inconsistency (fix in next commit)
@jmarrec
Adjust ProposedEnergy+.idd to allow pointing SurfaceProperty:LocalEnv…
1ec9bee 
…ironment to a SubSurface

cf NREL/EnergyPlus#9275
@jmarrec jmarrec added Enhancement Request component - Model Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. IDDChange labels Feb 18, 2022
@jmarrec jmarrec self-assigned this Feb 18, 2022
jmarrec added a commit to NREL/OpenStudio-resources that referenced this pull request Feb 18, 2022
@jmarrec
Add a test for #4533 - SurfaceProperty:LocalEnvironment and SurfacePr…
37e276f 
…operty:SurroundingSurfaces

cf NREL/OpenStudio#4535
@jmarrec jmarrec mentioned this pull request Feb 18, 2022
Merged
19 tasks
@ci-commercialbuildings
Copy link
Collaborator

ci-commercialbuildings commented Feb 18, 2022 •
edited

CI Results for 3285797:

tijcolem
tijcolem approved these changes Feb 18, 2022
View reviewed changes
Copy link
Collaborator

@tijcolem tijcolem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmarrec This is great! very fast turnaround.

@tijcolem tijcolem merged commit 2f385d4 into develop Feb 18, 2022
@tijcolem tijcolem deleted the 4533_SurfacePropertySurroundingSurfaces branch February 18, 2022 20:16
@jmarrec
Copy link
Collaborator Author

jmarrec commented Feb 28, 2022 •
edited

@tijcolem Thanks for reviewing and merging. Could you check the corresponding OpenStudio-resources PR quickly please? NREL/OpenStudio-resources#163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tijcolem tijcolem tijcolem approved these changes

Assignees

@jmarrec jmarrec

Labels
component - Model Enhancement Request IDDChange Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Milestone
No milestone
3 participants
@jmarrec @ci-commercialbuildings @tijcolem