AirLoopHVAC::clone will duplicate components that are on the relief and intake air streams of an OutdoorAirSystem

[jmarrec]

Issue overview

Current Behavior

Cloning an airloop with air-to-air heat exchanger doubles the number of heat exchangers:

Expected Behavior

Shouldn't be cloned twice.

Steps to Reproduce

m = Model.new
a = AirLoopHVAC.new(m)
controller = OpenStudio::Model::ControllerOutdoorAir.new(m)
oas = OpenStudio::Model::AirLoopHVACOutdoorAirSystem.new(m, controller)
oas.addToNode(a.supplyOutletNode)
erv = HeatExchangerAirToAirSensibleAndLatent.new(m)
erv.addToNode(oas.outboardOANode.get)

a.supplyComponents.map(&:nameString)
=> ["Node 1", "Air Loop HVAC Outdoor Air System 1", "Node 2"
oas.components.map(&:nameString)
=> ["Node 6", "Heat Exchanger Air To Air Sensible And Latent 1", "Node 9", "Node 10", "Heat Exchanger Air To Air Sensible And Latent 1", "Node 7"]

a2 = a.clone(m).to_AirLoopHVAC.get

a2.supplyComponents.map(&:nameString)
=> ["Node 8", "Air Loop HVAC Outdoor Air System 2", "Node 11"]

oas2 = a2.airLoopHVACOutdoorAirSystem.get
oas2.components.map(&:nameString)
=> ["Node 15",
 "Heat Exchanger Air To Air Sensible And Latent 3",
 "Node 20",
 "Heat Exchanger Air To Air Sensible And Latent 2",
 "Node 18",
 "Node 19",
 "Heat Exchanger Air To Air Sensible And Latent 2",
 "Node 21",
 "Heat Exchanger Air To Air Sensible And Latent 3",
 "Node 16"]

Possible Solution

Details

Environment

Some additional details about your environment for this issue (if relevant):

• Platform (Operating system, version): All
• Version of OpenStudio (if using an intermediate build, include SHA): 3.6.0-rc2

Context

Initially reported at openstudiocoalition/OpenStudioApplication#600

[jmarrec]

The issue is with the AirLoopHVACOutdoorAirSystem::clone, and I'm not surprised we didn't catch it given the "clone" test here which does essentially nothing:

OpenStudio/src/model/test/AirLoopHVACOutdoorAirSystem_GTest.cpp

Lines 67 to 80 in 313d435

	TEST_F(ModelFixture, AirLoopHVACOutdoorAirSystem_clone) {
	Model model = Model();
	Model model2 = Model();
	OptionalModelObject modelObject;
	ControllerOutdoorAir controller(model);
	AirLoopHVACOutdoorAirSystem oaSystem = AirLoopHVACOutdoorAirSystem(model, controller);
	ASSERT_EQ(openstudio::IddObjectType::OS_Controller_OutdoorAir, oaSystem.getControllerOutdoorAir().iddObjectType().value());
	auto oaSystem2 = oaSystem.clone(model2).cast<AirLoopHVACOutdoorAirSystem>();
	ASSERT_EQ(openstudio::IddObjectType::OS_Controller_OutdoorAir, oaSystem2.getControllerOutdoorAir().iddObjectType().value());
	}

[jmarrec]

That is one OLD file... time to modernize and avoid optional casting an object that's already the right type... And this shoudl be AirLoopHVAC as an override from HVACComponent

OpenStudio/src/model/AirLoopHVACOutdoorAirSystem.cpp

Lines 395 to 411 in 313d435

	OptionalAirLoopHVAC AirLoopHVACOutdoorAirSystem_Impl::airLoop() const {
	OptionalAirLoopHVAC result;
	AirLoopHVACVector airLoops = this->model().getConcreteModelObjects<AirLoopHVAC>();
	AirLoopHVACVector::iterator it;
	for (it = airLoops.begin(); it != airLoops.end(); ++it) {
	OptionalAirLoopHVAC airLoop = it->optionalCast<AirLoopHVAC>();
	if (airLoop) {
	if (airLoop->component(this->handle())) {
	return airLoop;
	}
	}
	}
	return result;
	}