Copying an Airloop doubles the components

[Ski90Moo]

Issue overview

Using the copy button with an airloop with air-to-air heat exchanger doubles the number of heat exchangers:

Current Behavior

Expected Behavior

Steps to Reproduce

Possible Solution

Details

Environment

Some additional details about your environment for this issue (if relevant):

• Platform (Operating system, version): Windows 11 Pro
• Version of OpenStudioApplication (if using an intermediate build, include SHA):
  

Context

[jmarrec]

Thanks for reporting @Ski90Moo !

This is not an OpenStudioApp issue, but a SDK one, even without trying to repo in the bindings (though I did repro it to make sure & provide info on the SDK issue I opened)

I'd like to kindly ask you, as a power user, if you could try and think whether problems might be OSApp or SDK related so the issue can be directed appropriately. I know this is annoying and puts the burden on you, but otherwise this puts the burden on us and we have very limited resources to work with.

I opened an SDK issue at NREL/OpenStudio#4869

[Ski90Moo]

Thank you @jmarrec. I will try. Can you give me some pointers as to where the line is drawn?

[jmarrec]

I know it's tricky without knowing the inner code of the OSApp and where it defers to OS SDK, and it's totally fine if some issues are reported to the wrong project. Ideally you should try to do the same in the OS SDK bindings and see if it crashes there. But I can try to give a couple of pointers

Most likely OpenStudioApplication related

• Anything UI related: a button not displaying, something too big, icon missing, etc
• Anything related to geometry editor or viewing reports
• If something crashes when you switch tabs
• Dragging a component from the library to your model makes it crash
• Editing a value makes the App crash

Potentially OS SDK related

Like I said, ideally you do the same in the SDK bindings and see.

• Clicking on x2 button makes it crash (this is usually just a call to the SDK's ModelObject::clone method)
• I'm sure I connected components correctly but I get an E+ fatal error (or crash)
• This component is not allowed in this location when trying to add a component to a loop

When in doubt, do report to OpenStudioApplication and not OS SDK since you found the issue in the OSApp.

[jmarrec]

Should be fixed via NREL/OpenStudio#4872 FYI

[Ski90Moo]

Thank you @jmarrec