Add SetpointManagerWarmestTemperatureFlow #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ControllerOutdoorAir change the default value for field "Heat Recovery Bypass Control Type" from "BypassWhenOAFlowGreaterThanMinimum" to "BypassWhenWithinEconomizerLimits". The old value was majorly messing up oa rates even when there is no heat recovery device. This corrects unmet hours in CBECC lab model, which is approximatly system 7, but with exahaust fans and 100% oa. Many other models could be inflicted with this problem, which ultimately is an EnergyPlus bug documented here: NREL/EnergyPlus#4568. The scope of this issue in OpenStudio models is unclear but is being investigated with the EnergyPlus issue 4568. It may or may not be isolated to 100% OA and/or exhaust fans. [#81583558]
kbenne
changed the title
These new options take into account the availability of SetpointManagerWarmestTemperatureFlow. WarmestResetFlowFirst -> Existing enum Was mapped to SPM:Warmest. Update translator to map to SPM:WarmestTemperatureFlow Strategy = FlowFirst Minimum Setpoint Temperature = AirSys:ClRstSupLow Maximum Setpoint Temperature = AirSys:ClRstSupHi Minimum Turndown Ratio = AirSys:DsgnAirFlowMin WarmestResetTemperatureFirst -> New enum Map to SPM:WarmestTemperatureFlow Strategy = TemperatureFirst Minimum Setpoint Temperature = AirSys:ClRstSupLow Maximum Setpoint Temperature = AirSys:ClRstSupHi Minimum Turndown Ratio = AirSys:DsgnAirFlowMin Warmest -> New enum Map to SPM:Warmest Minimum Setpoint Temperature = AirSys:ClRstSupLow Maximum Setpoint Temperature = AirSys:ClRstSupHi [#79969370]
[#79969370]
kbenne
force-pushed
the
81583558-SetpointManagerWarmestTemperatureFlow
branch
from
0add782
to
0ee8c51
Compare
|
@asparke2 whats the timeline on this one? I need to deliver another package to the cbecc team today so I need to know if I should create a cbecc branch and merge this in there, or if I can work from develop. |
…anagerWarmestTemperatureFlow
[#81583558]
asparke2
added a commit
that referenced
this pull request
Nov 8, 2014
…peratureFlow Add SetpointManagerWarmestTemperatureFlow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#81583558]