Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses #50 and #3347 (ScheduleFile) #3610

Merged
merged 15 commits into from
Sep 5, 2019
Merged

Addresses #50 and #3347 (ScheduleFile) #3610

merged 15 commits into from
Sep 5, 2019

Conversation

joseph-robertson
Copy link
Collaborator

@joseph-robertson joseph-robertson commented Aug 1, 2019

Design docs:

TODO:

  • [Dan] Write CSVFile class and methods
  • [Joe] Optionally call this class in FT for Schedule:FixedInterval
  • [Joe] Test reverse translation of Schedule:File (unit test, OSApp, etc.)
  • [Joe] Write more tests for CSVFile addColumn and getColumn methods
  • [Joe] ScheduleFile::csvFile that returns CSVFile
  • [Joe] Think about multiple schedulefixedintervals in one csv [meh; sounds rough...]
  • [Joe] Add regression tests corresponding to FT (false, true)

@macumber macumber added this to the OpenStudio 2.9.0 milestone Aug 23, 2019
@macumber macumber merged commit 70152ec into develop Sep 5, 2019
@@ -4763,7 +4763,14 @@ OS:Schedule:FixedInterval,
A3, \field Schedule Type Limits Name
\type object-list
\object-list ScheduleTypeLimitsNames
A4, \field Interpolate to Timestep
A4, \field Translate to Schedule File
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@macumber @joseph-robertson Thanks for making this optional and defaulting to No.

@joseph-robertson joseph-robertson deleted the schedule-file branch March 16, 2020 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants