Fixed an issue in Surface splitSurfaceForSubSurfaces which caused the…

[ggartside]

…w routine to return way too may overlapping surfaces

Added a unit test Issue_4374 which uses one surface from the secondary school ref building as test dats

Pull request overview

• Fixes #ISSUENUMBERHERE (IF THIS IS A DEFECT)

Pull Request Author

• Model API Changes / Additions
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• Model API methods are tested (in src/model/test)
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[tijcolem]

@ggartside This is great as this is an important fix.

@DavidGoldwasser Would you be able to use one of the installers to verify this fixes the problem?

[DavidGoldwasser]

Still some issues, see my updates on this issue in measure repo.
NREL/openstudio-model-articulation-gem#76 (comment)

[DavidGoldwasser]

@ggartside ok, so I think we are good with what was in this installer without the new proposed change to change where the split happens. This was misunderstanding on my part. I didn't realize it splits between all sub-surfaces instead of just doors. Here are my proposed fixes to the measure. One removes windows before splitting so it only splits at doors. The other is change in tolerance on rectangle check. NREL/openstudio-model-articulation-gem@3769173

[DavidGoldwasser]

@ggartside and @tijcolem minor correction to my last comment. I'm using ins taller from a few days ago, I'm wondering if the last commit from today should be removed? or maybe it won't create any problems. I'm concerned that when I do clear out windows before split that the new split won't be tight against the door as is expected.
7035a3e

[tijcolem]

@ggartside Sounds like @DavidGoldwasser was able to successfully use your split surface fix ending on commit
42398b6 in this branch. Since this is working, it's probably best to revert to that commit. You don't need to do force push as we can have a record of the other changes (maybe it'll still come into play).

[ggartside]

@DavidGoldwasser If the intention is to only split the surface around doors then I could modify the original routine to skip window openings.

@tijcolem I will revert back to the original method,

One thing I don't understand yet is why this routine is necessary, maybe you can enlighten me?

[DavidGoldwasser]

Task linked: CU-1h1w527 Review Surface matching PR (03)

[ci-commercialbuildings]

CI Results for e732db8:

• Ubuntu 18.04:

  • OpenStudio-3.3.0-alpha+130619c49c-Ubuntu-18.04.deb
  • OpenStudio-3.3.0-alpha+130619c49c-Ubuntu-18.04.tar.gz

• Ubuntu 20.04:

  • OpenStudio-3.3.0-alpha+f73f28b16b-Ubuntu-20.04.deb
  • OpenStudio-3.3.0-alpha+f73f28b16b-Ubuntu-20.04.tar.gz

• Darwin:

  • OpenStudio-3.3.0-alpha+df889172f0-Darwin.dmg
  • OpenStudio-3.3.0-alpha+df889172f0-Darwin.tar.gz

• Windows:

  • OpenStudio-3.3.0-alpha+f2a6a90f26-Windows.exe
  • OpenStudio-3.3.0-alpha+f2a6a90f26-Windows.tar.gz

• Code Coverage:

  • OpenStudio-e732db858f072cbb86bd1032a53a828bf522de10.gcov.html

[tijcolem]

@ggartside Thanks for reverting! This looks good and I'll drop in.