Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4496 - Add gems cbor and msgpack and allow using a package from an openstudio-gems PR #4502

Merged
merged 10 commits into from
Nov 19, 2021
Merged

#4496 - Add gems cbor and msgpack and allow using a package from an openstudio-gems PR #4502

merged 10 commits into from
Nov 19, 2021

Commits on Nov 16, 2021

  1. Support using the openstuido_gems packages produced by CI on a PR and… 

    … use NREL/openstudio-gems#51
    @jmarrec
    jmarrec committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    a8993af View commit details
    Browse the repository at this point in the history

  2. I added a version.txt file on oppenstudio-gems tar.gz, on my PR-51, s… 

    …o read that to make sure you use the right openstudio3-gems tar.gz especially when switching branches on CI.
    @jmarrec
    jmarrec committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    c89f363 View commit details
    Browse the repository at this point in the history

  3. Register the init for the new native extensions

    @jmarrec
    jmarrec committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    21dea81 View commit details
    Browse the repository at this point in the history

  4. It's still not working, not sure why

    @jmarrec
    jmarrec committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    b5e1fb5 View commit details
    Browse the repository at this point in the history

  5. Add a cli test for msgpack/cbor

    @jmarrec
    jmarrec committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    7a796cd View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. It actually had worked, I just needed to clean build. swig for Embedd… 

    …edHelp wasn't picking up the init_cbor/init_msgpack
    @jmarrec
    jmarrec committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    b095a77 View commit details
    Browse the repository at this point in the history

  2. Previous windows gems package built by Jenkins was broken (due to cer… 

    …tificate error), so I retriggered it
    @jmarrec
    jmarrec committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    480090c View commit details
    Browse the repository at this point in the history

  3. And of course it's a new day, so update the filename and sha

    @jmarrec
    jmarrec committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    a887d0c View commit details
    Browse the repository at this point in the history

  4. Cbor is very broken on windows, so removing it. Add the openstudio-ge… 

    …ms package that only includes msgpack (which builds fine)
    @jmarrec
    jmarrec committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    20ecc9b View commit details
    Browse the repository at this point in the history

  5. Remove cbor from embedded help

    @jmarrec
    jmarrec committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    56e4c0e View commit details
    Browse the repository at this point in the history