Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4533 - Wrap SurfaceProperty:LocalEnvironment and SurfaceProperty:SurroundingSurfaces #4535

Merged
merged 21 commits into from
Feb 18, 2022
Merged

Fix #4533 - Wrap SurfaceProperty:LocalEnvironment and SurfaceProperty:SurroundingSurfaces #4535

merged 21 commits into from
Feb 18, 2022

Commits on Feb 17, 2022

  1. SurfaceProperty:SurroundingSurfaces: Copy the E+ IDD as is

    @jmarrec
    jmarrec committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    202aa90 View commit details
    Browse the repository at this point in the history

  2. SurfaceProperty:SurroundingSurfaces: Make modification to the IDD for… 

    … OpenStudio: the Sky and Ground View Factors are autocalculatable
    @jmarrec
    jmarrec committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    2d5f85c View commit details
    Browse the repository at this point in the history

  3. Don't see the point in having both isXXXDefaulted and isXXXAutocalcul… 

    …ated, so remove default from idd
    @jmarrec
    jmarrec committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    c3c5762 View commit details
    Browse the repository at this point in the history

  4. Realized that the Surrounding Surface Name is really an alpha, not a … 

    …surface.
    @jmarrec
    jmarrec committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    03ab3c3 View commit details
    Browse the repository at this point in the history

  5. SurfaceProperty:LocalEnvironment is needed to use SurfaceProperty:Sur… 

    …roundingSurfaces
    @jmarrec
    jmarrec committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    de6e647 View commit details
    Browse the repository at this point in the history

  6. Modification to SurfaceProperty:LocalEnvironment for OpenStudio.idd

    @jmarrec
    jmarrec committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    e7115e1 View commit details
    Browse the repository at this point in the history

  7. E+ has a wrong reference for the surface field, the example file has … 

    …a fenestration object, so adjust

Filed an E+ issue at NREL/EnergyPlus#9275
    @jmarrec
    jmarrec committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    64fd040 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2022

  1. Implement model classes for SurfaceProperty:SurroundingSurface. With … 

    …a helper class for extensible fields
    @jmarrec
    jmarrec committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    81793b9 View commit details
    Browse the repository at this point in the history

  2. Initial pass at model class for SurfacePropertyLocalEnvironment

    @jmarrec
    jmarrec committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    b94eef1 View commit details
    Browse the repository at this point in the history

  3. SurfacePropertyLocalEnvironment: since it can actually accept subsurf… 

    …aces, make necessary changes
    @jmarrec
    jmarrec committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    377957c View commit details
    Browse the repository at this point in the history

  4. Add a getter in Surface/SubSurface for surfacePropertyLocalEnvironment

    @jmarrec
    jmarrec committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    286b5b1 View commit details
    Browse the repository at this point in the history

  5. Model tests for SurfacePropertySurroundingSurfaces

    @jmarrec
    jmarrec committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    6c8ba99 View commit details
    Browse the repository at this point in the history

  6. Model tests for SurfacePropertyLocalEnvironment

    @jmarrec
    jmarrec committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    9bd2198 View commit details
    Browse the repository at this point in the history

  7. More tests for SurfacePropertyLocalEnvironment

    @jmarrec
    jmarrec committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    cd97f16 View commit details
    Browse the repository at this point in the history

  8. FT for SurfacePropertyLocalEnvironment and SurfacePropertySurrounding… 

    …Surfaces
    @jmarrec
    jmarrec committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    48ca33c View commit details
    Browse the repository at this point in the history

  9. Add FT Test for SurfacePropertySurroundingSurfaces

    @jmarrec
    jmarrec committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    c9df953 View commit details
    Browse the repository at this point in the history

  10. Add FT Test for SurfacePropertyLocalEnvironment, which is failing due… 

    … to E+ idd inconsistency (fix in next commit)
    @jmarrec
    jmarrec committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    2f9252f View commit details
    Browse the repository at this point in the history

  11. Adjust ProposedEnergy+.idd to allow pointing SurfaceProperty:LocalEnv… 

    …ironment to a SubSurface

cf NREL/EnergyPlus#9275
    @jmarrec
    jmarrec committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    1ec9bee View commit details
    Browse the repository at this point in the history

  12. Move the warning for uniqueness before removal into the SurfaceProper… 

    …tyLocalEnvironment_Impl::setExteriorSurface
    @jmarrec
    jmarrec committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    d1601fc View commit details
    Browse the repository at this point in the history

  13. Write a RT for SurfaceProperty:SurroundingSurfaces and SurfacePropert… 

    …y:LocalEnvironment
    @jmarrec
    jmarrec committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    75e900d View commit details
    Browse the repository at this point in the history

  14. RT Tests for SurfaceProperty:SurroundingSurfaces and SurfaceProperty:… 

    …LocalEnvironment
    @jmarrec
    jmarrec committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    3285797 View commit details
    Browse the repository at this point in the history