Switch to E+ Space FT by default #4589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-robertson
added
Enhancement Request
component - CLI
Pull Request - Ready for CI
|
CI Results for 62a43cc:
|
jmarrec
approved these changes
May 19, 2022
| @@ -40,7 +40,7 @@ OS:Version, | |||
| \required-field | |||
| A2, \field Version Identifier | |||
| \type alpha | |||
| \default 3.3.1 | |||
| \default 3.4.1 | |||
There was a problem hiding this comment.
ouch, that was wrong defore (which isn't too big of a deal)
| @@ -120,7 +120,7 @@ namespace energyplus { | |||
| m_excludeSQliteOutputReport = false; | |||
| m_excludeHTMLOutputReport = false; | |||
| m_excludeVariableDictionary = false; | |||
| m_excludeSpaceTranslation = true; | |||
| m_excludeSpaceTranslation = false; // At 3.4.1, this was changed to false. | |||
|
I started a Release Notes template, and tried to address the Windows test that failed: |
|
I'm merging, but will check on the Windows runner to see if the test passed. Can be addressed on develop if needed |
jmarrec
reviewed
May 19, 2022
Comment on lines
+70
to
+73
| * [#4589](https://github.com/NREL/OpenStudio/pull/4589) - Switch to E+ Space FT by default | ||
| * OpenStudio SDK 3.3.0 added support to the new EnergyPlus 9.6.0 [space concept](https://github.com/NREL/EnergyPlus/blob/develop/design/FY2021/NFP-Spaces.md). This was an opt-in feature, as it was disabled by default. | ||
| * This is now enabled by default. You can opt-out by by manually calling `ForwardTranslator::setExcludeSpaceTranslation(true)` before calling `ForwardTranslator::translateModel(Model&)` or passing the CLI argument `--no-space-translation` to the `run` method (eg: `openstudio run --no-space-translation -w workflow.osw`) | ||
| * As a reminder, a few limitations due to DaylightingControls/IlluminanceMap exist: in case one of these objects is found in a ThermalZone, spaces will be combined for that ThermalZone (historical behavior) |
There was a problem hiding this comment.
Document the change in the Release Notes
| @@ -242,7 +242,7 @@ TEST_F(EnergyPlusFixture, ForwardTranslator_SpaceInfiltrationDesignFlowRate_Spac | |||
| } | |||
| } | |||
|
|
|||
| EXPECT_EQ(0.687, totalInfiltration); | |||
| EXPECT_DOUBLE_EQ(0.687, totalInfiltration); | |||
There was a problem hiding this comment.
Try to address windows runner failed test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.