Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to E+ Space FT by default #4589

Merged
merged 4 commits into from
May 19, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ if(CCACHE_PROGRAM)
endif()

# Project macro can only take digits in the version, it splits these out to specific variables
project(OpenStudio VERSION 3.4.0)
project(OpenStudio VERSION 3.4.1)

# The RT Manifest file and C# SDK only support the digit portion of patch
string(APPEND PROJECT_VERSION_PATCH_DIGIT ${PROJECT_VERSION_PATCH})
Expand Down
133 changes: 25 additions & 108 deletions developer/doc/ReleaseNotes/ReleaseNotes.md

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions resources/model/OpenStudio.idd
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
!IDD_Version 3.4.0
!IDD_Version 3.4.1
! *****************************************************************************
! This file is the Input Data Dictionary (IDD) for OpenStudio Model.
!
Expand Down Expand Up @@ -40,7 +40,7 @@ OS:Version,
\required-field
A2, \field Version Identifier
\type alpha
\default 3.3.1
\default 3.4.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch, that was wrong defore (which isn't too big of a deal)

A3; \field Prerelease Identifier
\type alpha

Expand Down
2 changes: 1 addition & 1 deletion src/energyplus/ForwardTranslator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ namespace energyplus {
m_excludeSQliteOutputReport = false;
m_excludeHTMLOutputReport = false;
m_excludeVariableDictionary = false;
m_excludeSpaceTranslation = true;
m_excludeSpaceTranslation = false; // At 3.4.1, this was changed to false.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actual change

}

Workspace ForwardTranslator::translateModel(const Model& model, ProgressBar* progressBar) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ TEST_F(EnergyPlusFixture, ForwardTranslator_SpaceInfiltrationDesignFlowRate_Spac
}
}

EXPECT_EQ(0.687, totalInfiltration);
EXPECT_DOUBLE_EQ(0.687, totalInfiltration);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to address windows runner failed test

}

// When including Space translation (new E+ 9.6.0)
Expand Down
9 changes: 7 additions & 2 deletions src/osversion/VersionTranslator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ namespace osversion {
m_updateMethods[VersionString("3.2.1")] = &VersionTranslator::update_3_2_0_to_3_2_1;
m_updateMethods[VersionString("3.3.0")] = &VersionTranslator::update_3_2_1_to_3_3_0;
m_updateMethods[VersionString("3.4.0")] = &VersionTranslator::update_3_3_0_to_3_4_0;
//m_updateMethods[VersionString("3.3.0")] = &VersionTranslator::defaultUpdate;
m_updateMethods[VersionString("3.4.1")] = &VersionTranslator::defaultUpdate;

// List of previous versions that may be updated to this one.
// - To increment the translator, add an entry for the version just released (branched for
Expand Down Expand Up @@ -303,7 +303,8 @@ namespace osversion {
m_startVersions.push_back(VersionString("3.2.0"));
m_startVersions.push_back(VersionString("3.2.1"));
m_startVersions.push_back(VersionString("3.3.0"));
//m_startVersions.push_back(VersionString("3.4.0"));
m_startVersions.push_back(VersionString("3.4.0"));
//m_startVersions.push_back(VersionString("3.4.1"));
}

boost::optional<model::Model> VersionTranslator::loadModel(const openstudio::path& pathToOldOsm, ProgressBar* progressBar) {
Expand Down Expand Up @@ -6910,5 +6911,9 @@ namespace osversion {

} // end update_3_3_0_to_3_4_0

/* std::string VersionTranslator::update_3_4_0_to_3_4_1(const IdfFile& idf_3_4_0, const IddFileAndFactoryWrapper& idd_3_4_1) {

} // end update_3_4_0_to_3_4_1 */

} // namespace osversion
} // namespace openstudio
1 change: 1 addition & 0 deletions src/osversion/VersionTranslator.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@ namespace osversion {
std::string update_3_2_0_to_3_2_1(const IdfFile& idf_3_2_0, const IddFileAndFactoryWrapper& idd_3_2_1);
std::string update_3_2_1_to_3_3_0(const IdfFile& idf_3_2_1, const IddFileAndFactoryWrapper& idd_3_3_0);
std::string update_3_3_0_to_3_4_0(const IdfFile& idf_3_3_0, const IddFileAndFactoryWrapper& idd_3_4_0);
//std::string update_3_4_0_to_3_4_1(const IdfFile& idf_3_4_0, const IddFileAndFactoryWrapper& idd_3_4_1);

IdfObject updateUrlField_0_7_1_to_0_7_2(const IdfObject& object, unsigned index);

Expand Down